Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(snaps): Patch @metamask/snaps-utils #28377

Merged
merged 2 commits into from
Nov 11, 2024

Conversation

GuillaumeRx
Copy link
Contributor

@GuillaumeRx GuillaumeRx commented Nov 8, 2024

Description

This PR patches the @metamask/snaps-utils package after MetaMask/snaps#2876.

Open in GitHub Codespaces

Related issues

Manual testing steps

Screenshots/Recordings

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@GuillaumeRx GuillaumeRx requested a review from a team as a code owner November 8, 2024 10:44
Copy link
Contributor

github-actions bot commented Nov 8, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@github-actions github-actions bot added the team-snaps-platform Snaps Platform team label Nov 8, 2024
FrederikBolding
FrederikBolding previously approved these changes Nov 8, 2024
FrederikBolding
FrederikBolding previously approved these changes Nov 8, 2024
Copy link

socket-security bot commented Nov 8, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher

🚮 Removed packages: npm/@metamask/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected]

View full report↗︎

@metamaskbot
Copy link
Collaborator

Builds ready [1e7d94a]
Page Load Metrics (1838 ± 83 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint15852205183916981
domContentLoaded15772136180815876
load15862209183817283
domInteractive279046147
backgroundConnect97125189
firstReactRender48210954019
getState463192110
initialActions01000
loadScripts11311648132213163
setupStore1077332311
uiStartup17742391205618287
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 684 Bytes (0.01%)
  • ui: 2 KiB (0.03%)
  • common: 433 Bytes (0.01%)

@danjm danjm merged commit d876ccb into Version-v12.7.0 Nov 11, 2024
72 checks passed
@danjm danjm deleted the gr/patch-snaps-utils-v12.7.0 branch November 11, 2024 12:58
@github-actions github-actions bot locked and limited conversation to collaborators Nov 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
team-snaps-platform Snaps Platform team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants