test: [POM] Migrate token tests #29375

cmd-ob · 2024-12-20T06:54:34Z

Description

Updates asset-list Page Object - Adds methods for interacting with token list (i.e sorting, getting list, assertion on increase/decrease price and percentage)
Adds new method for importing a custom token using contract address
Adds new method for adding multiple tokens by search in one step
Minor update to send-token page for warning message
New page object for token-overview
Tests Updated - import-tokens, send-erc20-to-contract, token-list and token-sort

Related issues

Fixes:

Manual testing steps

All tests must pass on CI

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

…tamask-extension into qq-mulitple-tokens-migration

…-send-ecr20-to-contract

github-actions · 2024-12-20T06:54:46Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

test/e2e/page-objects/pages/token-overview-page.ts

metamaskbot · 2024-12-20T09:41:28Z

Builds ready [7f54477]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 13, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1801 ± 78 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	272	2081	1725	368	177
		domContentLoaded	1493	2069	1758	142	68
		load	1498	2084	1801	162	78
		domInteractive	22	93	46	20	10
		backgroundConnect	7	288	43	60	29
		firstReactRender	16	101	50	30	15
		getState	5	65	21	22	11
		initialActions	0	1	0	0	0
		loadScripts	1043	1559	1294	125	60
		setupStore	6	87	13	17	8
		uiStartup	1835	2832	2192	278	134

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

test/e2e/page-objects/pages/home/asset-list.ts

test/e2e/page-objects/pages/token-overview-page.ts

test/e2e/tests/tokens/token-list.spec.ts

test/e2e/page-objects/pages/home/asset-list.ts

metamaskbot · 2024-12-20T14:59:38Z

Builds ready [c09fd7d]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 13, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1613 ± 47 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1458	1852	1622	109	52
		domContentLoaded	1414	1765	1591	94	45
		load	1458	1812	1613	98	47
		domInteractive	23	117	38	23	11
		backgroundConnect	8	102	21	22	10
		firstReactRender	16	73	41	25	12
		getState	4	47	15	15	7
		initialActions	0	1	0	0	0
		loadScripts	1036	1317	1166	82	39
		setupStore	6	67	11	13	6
		uiStartup	1659	2040	1840	104	50

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

metamaskbot · 2025-01-07T11:45:26Z

Builds ready [7888d66]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 13, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1571 ± 47 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1424	1793	1573	93	45
		domContentLoaded	1410	1741	1540	90	43
		load	1424	1795	1571	97	47
		domInteractive	20	77	38	18	9
		backgroundConnect	8	63	31	20	10
		firstReactRender	15	67	29	20	10
		getState	4	56	9	11	5
		initialActions	0	1	0	0	0
		loadScripts	1034	1348	1161	83	40
		setupStore	6	55	18	19	9
		uiStartup	1592	1992	1772	103	49

…tension into qq-more-token-tests

metamaskbot · 2025-01-07T12:28:02Z

Builds ready [15854d4]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 13, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1717 ± 68 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	308	2047	1586	424	204
		domContentLoaded	1518	1955	1688	123	59
		load	1552	2057	1717	141	68
		domInteractive	25	162	46	37	18
		backgroundConnect	8	129	38	35	17
		firstReactRender	16	107	61	33	16
		getState	5	112	22	27	13
		initialActions	0	1	0	0	0
		loadScripts	1118	1495	1250	104	50
		setupStore	6	78	22	24	12
		uiStartup	1761	2941	2106	277	133

chloeYue · 2025-01-07T16:03:29Z

@metamaskbot update-policies

metamaskbot · 2025-01-07T16:16:05Z

Policies updated.
👀 Please review the diff for suspicious new powers.

🧠 Learn how: https://lavamoat.github.io/guides/policy-diff/#what-to-look-for-when-reviewing-a-policy-diff

metamaskbot · 2025-01-07T16:51:00Z

Builds ready [9f39c02]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 13, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1670 ± 71 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1455	2152	1680	155	74
		domContentLoaded	1447	2081	1649	150	72
		load	1456	2086	1670	148	71
		domInteractive	20	107	44	23	11
		backgroundConnect	8	63	27	18	8
		firstReactRender	15	100	43	27	13
		getState	4	68	20	22	11
		initialActions	0	1	0	0	0
		loadScripts	999	1610	1217	136	65
		setupStore	6	87	12	17	8
		uiStartup	1623	2396	1952	178	85

chloeYue

LGTM

seaona

Overall the new changes look good to me! I've just added a couple of small nits. Feel free to take them or leave them

test/e2e/page-objects/pages/home/asset-list.ts

seaona · 2025-01-08T10:00:32Z

test/e2e/page-objects/pages/home/asset-list.ts

+    const isPresent = await this.driver.isElementPresentAndVisible({
+      css: this.tokenIncreaseDecreaseValue,
+      text: expectedChangeValue,
+    });
+    if (!isPresent) {
+      throw new Error(
+        `Token general change value ${expectedChangeValue} not found`,
+      );
+    }


nit: this simplifies a bit the code and readability. Note that waitForSelector already waits for an element with visible state by default

Suggested change

const isPresent = await this.driver.isElementPresentAndVisible({

css: this.tokenIncreaseDecreaseValue,

text: expectedChangeValue,

});

if (!isPresent) {

throw new Error(

`Token general change value ${expectedChangeValue} not found`,

);

}

await this.driver.waitForSelector({

css: this.tokenIncreaseDecreaseValue,

text: expectedChangeValue,

});

test/e2e/tests/tokens/token-sort.spec.ts

cmd-ob added 16 commits December 17, 2024 17:54

migrate test to ts and POM

c5367d0

Merge branch 'main' into qq-mulitple-tokens-migration

6e9112d

update typo, general tidy up

20ba9c4

Merge branch 'qq-mulitple-tokens-migration' of github.com:MetaMask/me…

352dd40

…tamask-extension into qq-mulitple-tokens-migration

add load check methods, make naming consistent

886cf1a

Merge branch 'main' into qq-mulitple-tokens-migration

874c128

linting

d00f8e3

Merge branch 'qq-mulitple-tokens-migration' of github.com:MetaMask/me…

5aa73cf

…tamask-extension into qq-mulitple-tokens-migration

migrate erc-20 to contract test

bab4345

Merge branch 'main' of github.com:MetaMask/metamask-extension into qq…

073579f

…-send-ecr20-to-contract

remove duplicate function

b4d3fec

use seconadar name

e8fbb7a

get buttons by text to avoid flake

f11c25d

Merge branch 'main' of github.com:MetaMask/metamask-extension into qq…

be104ee

…-send-ecr20-to-contract

update token list,sort and import

faffc73

lint

f8a0e0e

metamaskbot added the team-qa QA team label Dec 20, 2024

use largeDelay

10f2f7a

cmd-ob commented Dec 20, 2024

View reviewed changes

test/e2e/page-objects/pages/token-overview-page.ts Show resolved Hide resolved

cmd-ob requested review from seaona and chloeYue December 20, 2024 07:57

cmd-ob marked this pull request as ready for review December 20, 2024 07:58

cmd-ob added 2 commits December 20, 2024 07:58

Merge branch 'main' into qq-more-token-tests

37cbee3

Merge branch 'main' into qq-more-token-tests

7f54477

cmd-ob enabled auto-merge December 20, 2024 09:32

seaona reviewed Dec 20, 2024

View reviewed changes

test/e2e/page-objects/pages/home/asset-list.ts Outdated Show resolved Hide resolved

seaona reviewed Dec 20, 2024

View reviewed changes

test/e2e/page-objects/pages/token-overview-page.ts Show resolved Hide resolved

seaona reviewed Dec 20, 2024

View reviewed changes

test/e2e/tests/tokens/token-list.spec.ts Outdated Show resolved Hide resolved

chloeYue reviewed Dec 20, 2024

View reviewed changes

test/e2e/page-objects/pages/home/asset-list.ts Outdated Show resolved Hide resolved

cmd-ob and others added 4 commits December 20, 2024 12:25

remove getAssetPercentageIncreaseDecrease method

a8ab1ad

fix lint

c166dff

linting

f678372

Merge branch 'main' into qq-more-token-tests

c09fd7d

chloeYue previously approved these changes Dec 20, 2024

View reviewed changes

cmd-ob requested a review from seaona December 20, 2024 15:11

Merge branch 'main' into qq-more-token-tests

7888d66

cmd-ob added 2 commits January 7, 2025 11:48

Merge branch 'qq-more-token-tests' of github.com:MetaMask/metamask-ex…

e1183f0

…tension into qq-more-token-tests

policy update

15854d4

cmd-ob dismissed chloeYue’s stale review via 15854d4 January 7, 2025 11:51

cmd-ob requested review from a team as code owners January 7, 2025 11:51

Update LavaMoat policies

9f39c02

cmd-ob requested a review from chloeYue January 8, 2025 09:40

chloeYue approved these changes Jan 8, 2025

View reviewed changes

seaona reviewed Jan 8, 2025

View reviewed changes

seaona approved these changes Jan 8, 2025

View reviewed changes

cmd-ob added this pull request to the merge queue Jan 8, 2025

Merged via the queue into main with commit 7fe00dc Jan 8, 2025
76 checks passed

cmd-ob deleted the qq-more-token-tests branch January 8, 2025 10:40

github-actions bot locked and limited conversation to collaborators Jan 8, 2025

metamaskbot added the release-12.11.0 Issue or pull request that will be included in release 12.11.0 label Jan 8, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test: [POM] Migrate token tests #29375

test: [POM] Migrate token tests #29375

cmd-ob commented Dec 20, 2024 •

edited

Loading

github-actions bot commented Dec 20, 2024

metamaskbot commented Dec 20, 2024

metamaskbot commented Dec 20, 2024

metamaskbot commented Jan 7, 2025

metamaskbot commented Jan 7, 2025

chloeYue commented Jan 7, 2025

metamaskbot commented Jan 7, 2025

metamaskbot commented Jan 7, 2025

chloeYue left a comment

seaona left a comment

seaona Jan 8, 2025

test: [POM] Migrate token tests #29375

test: [POM] Migrate token tests #29375

Conversation

cmd-ob commented Dec 20, 2024 • edited Loading

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

github-actions bot commented Dec 20, 2024

metamaskbot commented Dec 20, 2024

metamaskbot commented Dec 20, 2024

metamaskbot commented Jan 7, 2025

metamaskbot commented Jan 7, 2025

chloeYue commented Jan 7, 2025

metamaskbot commented Jan 7, 2025

metamaskbot commented Jan 7, 2025

chloeYue left a comment

Choose a reason for hiding this comment

seaona left a comment

Choose a reason for hiding this comment

seaona Jan 8, 2025

Choose a reason for hiding this comment

cmd-ob commented Dec 20, 2024 •

edited

Loading