feat: display full terms of service during onboarding by jonybur · Pull Request #29392 · MetaMask/metamask-extension

jonybur · 2024-12-20T15:28:03Z

Description

During the onboarding process, the user is currently presented with a simple checkbox to agree to terms:

Legal would prefer we show the full terms of service, requiring the user to scroll the entire terms and agree at the end.

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/3013

Manual testing steps

Start onboarding
See checkbox but without full terms.
Verify full terms are displayed, requiring user to scroll and agree.

Screenshots/Recordings

Before

After

demo.mp4

No response

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2024-12-20T15:28:18Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

…-3013

metamaskbot · 2025-01-06T18:35:49Z

Builds ready [5d2206e]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 13, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1771 ± 70 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	242	2089	1706	361	173
		domContentLoaded	1482	2076	1740	146	70
		load	1487	2092	1771	145	70
		domInteractive	26	224	62	47	23
		backgroundConnect	10	85	36	23	11
		firstReactRender	17	76	30	18	9
		getState	5	59	17	16	8
		initialActions	0	1	0	0	0
		loadScripts	1063	1651	1310	132	63
		setupStore	8	55	25	20	9
		uiStartup	1716	2364	2031	160	77

jonybur · 2025-01-09T15:30:33Z

For some reason, this is failing the playwright tests (they are not even being ran).
E2E tests are failing due to a flaky test. They are not failing on lastest commit 5d2206e, but they are on commit 24353cf; which only adds a couple of console logs for debugging purposes.

## **Description** Modify the script to adjust to the new UI for the terms and conditions [![Open in GitHub Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/29616?quickstart=1) ## **Related issues** Fixes: ## **Manual testing steps** 1. Go to this page... 2. 3. ## **Screenshots/Recordings**  ### **Before**  ### **After**  ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

metamaskbot · 2025-01-10T00:37:31Z

Builds ready [426a732]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

Page Load Metrics (1548 ± 48 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1406	1822	1549	97	46
		domContentLoaded	1400	1800	1524	100	48
		load	1405	1824	1548	99	48
		domInteractive	23	137	51	30	15
		backgroundConnect	7	56	22	15	7
		firstReactRender	15	65	30	19	9
		getState	5	52	14	16	8
		initialActions	0	1	0	0	0
		loadScripts	1025	1379	1131	88	42
		setupStore	6	51	16	18	8
		uiStartup	1585	2072	1753	117	56

Bundle size diffs [🚀 Bundle size reduced!]

background: 0 Bytes (0.00%)
ui: 2.63 KiB (0.03%)
common: -66 Bytes (-0.00%)

metamaskbot · 2025-01-13T17:09:44Z

Builds ready [e75aaa3]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

Page Load Metrics (1682 ± 65 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1481	1937	1680	134	64
		domContentLoaded	1453	1919	1655	134	64
		load	1481	1946	1682	135	65
		domInteractive	25	186	45	36	17
		backgroundConnect	6	73	25	20	10
		firstReactRender	15	75	33	21	10
		getState	4	52	15	15	7
		initialActions	0	1	0	0	0
		loadScripts	1075	1432	1236	109	52
		setupStore	6	54	10	10	5
		uiStartup	1681	2371	1928	183	88

Bundle size diffs [🚀 Bundle size reduced!]

background: 0 Bytes (0.00%)
ui: 2.63 KiB (0.03%)
common: -66 Bytes (-0.00%)

metamaskbot · 2025-01-14T17:11:18Z

Builds ready [a73cefe]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

Page Load Metrics (1682 ± 37 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1565	1863	1687	84	40
		domContentLoaded	1531	1836	1655	83	40
		load	1563	1872	1682	78	37
		domInteractive	25	142	55	39	19
		backgroundConnect	7	72	29	21	10
		firstReactRender	16	74	35	23	11
		getState	4	55	14	11	6
		initialActions	0	1	0	0	0
		loadScripts	1093	1404	1234	71	34
		setupStore	6	52	13	13	6
		uiStartup	1745	2054	1898	83	40

Bundle size diffs [🚀 Bundle size reduced!]

background: -103.46 KiB (-1.78%)
ui: 5.43 KiB (0.07%)
common: -33.55 KiB (-0.40%)

metamaskbot · 2025-01-16T12:52:14Z

Builds ready [2a4c065]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

Page Load Metrics (1734 ± 87 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	511	2092	1664	315	151
		domContentLoaded	1483	2078	1697	170	82
		load	1491	2097	1734	181	87
		domInteractive	23	228	56	49	23
		backgroundConnect	5	208	37	48	23
		firstReactRender	15	105	55	34	16
		getState	4	84	32	32	16
		initialActions	0	1	0	0	0
		loadScripts	1066	1581	1263	147	70
		setupStore	5	68	13	15	7
		uiStartup	1692	2901	2162	353	170

Bundle size diffs [🚀 Bundle size reduced!]

background: 0 Bytes (0.00%)
ui: 2.67 KiB (0.03%)
common: -66 Bytes (-0.00%)

…-3013

… jb-3013

…-3013

… jb-3013

…-3013

hesterbruikman · 2025-01-28T20:35:25Z

Adding a Do not merge label because we want to make some improvements to onboarding before introducing this.

github-actions · 2025-06-03T00:03:23Z

This PR has been automatically marked as stale because it has not had recent activity in the last 90 days. It will be closed in 7 days. Thank you for your contributions.

github-actions · 2025-06-10T00:03:27Z

This PR was closed because there has been no follow up activity in 7 days. Thank you for your contributions.

Jonathan Bursztyn added 3 commits December 20, 2024 15:11

Move Terms of Use

fde7819

Fix lint

6353f38

Improvements

60f82c5

jonybur requested a review from a team as a code owner December 20, 2024 15:28

metamaskbot added the team-core-extension-ux Core Extension UX team label Dec 20, 2024

jonybur changed the title ~~feat: add~~ feat: display full terms of service during onboarding Dec 20, 2024

Jonathan Bursztyn and others added 10 commits December 20, 2024 15:44

Extend tests

6db0b37

Update tests

000cd80

Transform terms-of-use from JS to TS

eb5d374

Merge branch 'main' of github.com:MetaMask/metamask-extension into jb…

404ebfb

…-3013

Fix tests

f583885

Remove agreeTermsOfuse

3f2be89

Adapt the onboarding for the new onboarding flow

8c36fb3

Remove timeouts

7c0889f

Fix onboarding flow

0fc0494

Merge branch 'main' into jb-3013

a18b1d8

jonybur self-assigned this Jan 6, 2025

Jonathan Bursztyn added 5 commits January 6, 2025 15:39

Fix app-installed.spec.ts

3b93a21

Fix incremental-security.spec.ts

ac5e45e

Fix metamask-responsive-ui.spec.js

b2a709b

Fix signup-page.ts

f9be294

Fix signup-page

5d2206e

Add console logs

24353cf

davibroc and others added 2 commits January 9, 2025 23:54

Merge branch 'main' into jb-3013

426a732

Merge branch 'main' into jb-3013

8dbcf91

Jonathan Bursztyn and others added 2 commits January 13, 2025 16:27

Fix lint

0e3e67d

Merge branch 'main' into jb-3013

e75aaa3

Jonathan Bursztyn added 2 commits January 14, 2025 16:04

Add label

0a2f977

Update snapshots

a73cefe

jonybur requested a review from a team as a code owner January 14, 2025 16:29

Merge branch 'main' into jb-3013

2a4c065

Jonathan Bursztyn and others added 15 commits January 16, 2025 15:11

Merge branch 'main' of github.com:MetaMask/metamask-extension into jb…

c33eccf

…-3013

Fix up test

0576476

Merge branch 'jb-3013' of github.com:MetaMask/metamask-extension into…

9a43302

… jb-3013

Fix test

9e5d159

Merge branch 'main' into jb-3013

b86a195

Update ToC

01cd96b

Merge branch 'main' into jb-3013

e8044f4

Merge branch 'main' of github.com:MetaMask/metamask-extension into jb…

c1f8dea

…-3013

Merge branch 'jb-3013' of github.com:MetaMask/metamask-extension into…

4a54046

… jb-3013

update snapshot

08247a7

Fix flaky test

dc60abe

Fix snaps issue

05e3901

Fix Regex

4626733

Merge branch 'main' of github.com:MetaMask/metamask-extension into jb…

f62ac3a

…-3013

Merge branch 'main' into jb-3013

1180c1d

hesterbruikman added the DO-NOT-MERGE Pull requests that should not be merged label Jan 28, 2025

github-actions bot added the stale issues and PRs marked as stale label Jun 3, 2025

github-actions bot closed this Jun 10, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: display full terms of service during onboarding#29392

feat: display full terms of service during onboarding#29392
jonybur wants to merge 42 commits intomainfrom
jb-3013

jonybur commented Dec 20, 2024 •

edited

Loading

Uh oh!

github-actions bot commented Dec 20, 2024

Uh oh!

metamaskbot commented Jan 6, 2025

Uh oh!

jonybur commented Jan 9, 2025 •

edited

Loading

Uh oh!

metamaskbot commented Jan 10, 2025

Uh oh!

metamaskbot commented Jan 13, 2025

Uh oh!

metamaskbot commented Jan 14, 2025

Uh oh!

metamaskbot commented Jan 16, 2025

Uh oh!

hesterbruikman commented Jan 28, 2025

Uh oh!

github-actions bot commented Jun 3, 2025

Uh oh!

github-actions bot commented Jun 10, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

jonybur commented Dec 20, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

github-actions bot commented Dec 20, 2024

Uh oh!

metamaskbot commented Jan 6, 2025

Uh oh!

jonybur commented Jan 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

metamaskbot commented Jan 10, 2025

Uh oh!

metamaskbot commented Jan 13, 2025

Uh oh!

metamaskbot commented Jan 14, 2025

Uh oh!

metamaskbot commented Jan 16, 2025

Uh oh!

hesterbruikman commented Jan 28, 2025

Uh oh!

github-actions bot commented Jun 3, 2025

Uh oh!

github-actions bot commented Jun 10, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

jonybur commented Dec 20, 2024 •

edited

Loading

jonybur commented Jan 9, 2025 •

edited

Loading