chore: xchain tx details use short names #29413

infiniteflower · 2024-12-20T21:58:58Z

Description

This PR uses short names for networks to improve spacing.

Related issues

Fixes:

Manual testing steps

Do a bridge tx
Click on bridge tx in Activity
Observe shorter names

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2024-12-20T21:59:08Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

metamaskbot · 2024-12-20T22:31:30Z

Builds ready [84d0af0]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 13, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1684 ± 58 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1563	1968	1683	111	53
		domContentLoaded	1511	1945	1655	115	55
		load	1560	2014	1684	120	58
		domInteractive	26	175	48	35	17
		backgroundConnect	9	64	25	16	8
		firstReactRender	17	76	47	23	11
		getState	5	61	20	20	10
		initialActions	0	1	0	0	0
		loadScripts	1111	1491	1238	101	49
		setupStore	6	49	11	9	4
		uiStartup	1741	2243	1900	134	64

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 560 Bytes (0.01%)
common: 0 Bytes (0.00%)

micaelae · 2025-01-07T19:49:27Z

ui/pages/bridge/transaction-details/transaction-detail-row.tsx

        <Text variant={TextVariant.bodyMd}>{title}</Text>
      </Box>
      <Box
        display={Display.Flex}
+        width={BlockSize.ThreeFourths}


Is there going to be a follow-up to handle extra long network names? Some values don't overflow gracefully even when using the shortened network names

how's this?

Note that it still looks the same for the OP to Arb as before

metamaskbot · 2025-01-07T21:33:03Z

Builds ready [b6f5de7]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 13, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1465 ± 39 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1295	1689	1471	87	42
		domContentLoaded	1255	1642	1447	80	38
		load	1305	1692	1465	82	39
		domInteractive	21	64	33	15	7
		backgroundConnect	7	52	24	16	8
		firstReactRender	15	92	33	27	13
		getState	4	47	10	12	6
		initialActions	0	1	0	0	0
		loadScripts	881	1272	1081	77	37
		setupStore	6	84	13	19	9
		uiStartup	1456	2044	1729	161	77

metamaskbot · 2025-01-08T15:12:30Z

Builds ready [f5c879f]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 13, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1677 ± 54 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1517	1965	1693	120	58
		domContentLoaded	1500	1844	1652	101	48
		load	1509	1915	1677	113	54
		domInteractive	25	180	43	35	17
		backgroundConnect	9	89	31	23	11
		firstReactRender	16	99	58	29	14
		getState	5	78	20	22	11
		initialActions	0	1	0	0	0
		loadScripts	1069	1415	1225	92	44
		setupStore	6	81	17	23	11
		uiStartup	1695	2457	2038	204	98

ui/pages/bridge/transaction-details/transaction-detail-row.tsx

metamaskbot · 2025-01-09T20:36:27Z

Builds ready [9488886]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 13, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1889 ± 108 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	422	2621	1804	384	184
		domContentLoaded	1580	2603	1853	231	111
		load	1630	2626	1889	225	108
		domInteractive	18	116	52	29	14
		backgroundConnect	11	147	43	33	16
		firstReactRender	17	120	55	32	16
		getState	6	91	23	23	11
		initialActions	0	1	0	0	0
		loadScripts	1153	1653	1348	130	62
		setupStore	7	84	19	22	11
		uiStartup	1850	2927	2251	299	143

metamaskbot · 2025-01-09T21:35:18Z

Builds ready [9488886]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

Page Load Metrics (1889 ± 108 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	422	2621	1804	384	184
		domContentLoaded	1580	2603	1853	231	111
		load	1630	2626	1889	225	108
		domInteractive	18	116	52	29	14
		backgroundConnect	11	147	43	33	16
		firstReactRender	17	120	55	32	16
		getState	6	91	23	23	11
		initialActions	0	1	0	0	0
		loadScripts	1153	1653	1348	130	62
		setupStore	7	84	19	22	11
		uiStartup	1850	2927	2251	299	143

metamaskbot added the team-swaps label Dec 20, 2024

infiniteflower changed the title ~~Mb1833 xchain tx details short names~~ chore: xchain tx details use short names Dec 20, 2024

infiniteflower marked this pull request as ready for review December 20, 2024 22:23

infiniteflower requested a review from a team as a code owner December 20, 2024 22:23

ghgoodreau previously approved these changes Jan 7, 2025

View reviewed changes

micaelae reviewed Jan 7, 2025

View reviewed changes

infiniteflower dismissed ghgoodreau’s stale review via dd2b73a January 7, 2025 20:43

infiniteflower force-pushed the mb1833-xchain-tx-details-short-names branch from dd2b73a to b6f5de7 Compare January 7, 2025 20:45

ghgoodreau previously approved these changes Jan 7, 2025

View reviewed changes

infiniteflower added 5 commits January 7, 2025 17:23

chore: use short names for networks in tx details

61f246b

chore: use short names in activity list

b69f648

chore: use short names for bridge steps

c3b4c60

fix: overflowing rows for longer names

1240120

fix: extra long network names

f5c879f

infiniteflower dismissed ghgoodreau’s stale review via f5c879f January 7, 2025 22:25

infiniteflower force-pushed the mb1833-xchain-tx-details-short-names branch from b6f5de7 to f5c879f Compare January 7, 2025 22:25

ghgoodreau previously approved these changes Jan 8, 2025

View reviewed changes

micaelae previously approved these changes Jan 9, 2025

View reviewed changes

ui/pages/bridge/transaction-details/transaction-detail-row.tsx Outdated Show resolved Hide resolved

refactor: remove extra boxes

9488886

infiniteflower dismissed stale reviews from micaelae and ghgoodreau via 9488886 January 9, 2025 19:54

ghgoodreau approved these changes Jan 9, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: xchain tx details use short names #29413

chore: xchain tx details use short names #29413

infiniteflower commented Dec 20, 2024 •

edited

Loading

github-actions bot commented Dec 20, 2024

metamaskbot commented Dec 20, 2024

micaelae Jan 7, 2025

infiniteflower Jan 7, 2025

infiniteflower Jan 7, 2025

metamaskbot commented Jan 7, 2025

metamaskbot commented Jan 8, 2025

metamaskbot commented Jan 9, 2025

metamaskbot commented Jan 9, 2025

chore: xchain tx details use short names #29413

Are you sure you want to change the base?

chore: xchain tx details use short names #29413

Conversation

infiniteflower commented Dec 20, 2024 • edited Loading

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

github-actions bot commented Dec 20, 2024

metamaskbot commented Dec 20, 2024

micaelae Jan 7, 2025

Choose a reason for hiding this comment

infiniteflower Jan 7, 2025

Choose a reason for hiding this comment

infiniteflower Jan 7, 2025

Choose a reason for hiding this comment

metamaskbot commented Jan 7, 2025

metamaskbot commented Jan 8, 2025

metamaskbot commented Jan 9, 2025

metamaskbot commented Jan 9, 2025

infiniteflower commented Dec 20, 2024 •

edited

Loading