test: migrate queue personal sign spec to ts and POM #33451
+61
−89
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
|
❌ test-e2e-chrome-api-specs failed. View the html report here. |
Builds ready [dc6af92]
UI Startup Metrics (1236 ± 60 ms)
Benchmark value 1064 exceeds gate value 1061 for chrome browserify home mean domContentLoaded Benchmark value 2507 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 12 exceeds gate value 11 for firefox browserify home mean getState Benchmark value 26 exceeds gate value 24 for firefox browserify home p95 getState Benchmark value 41 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 1681 exceeds gate value 1660 for firefox webpack home p95 load Benchmark value 1681 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded Benchmark value 1667 exceeds gate value 1630 for firefox webpack home p95 loadScripts Sum of mean exceeds: 10ms | Sum of p95 exceeds: 134ms Sum of all benchmark exceeds: 144ms Bundle size diffs [🚀 Bundle size reduced!]
|
Builds ready [71fb820]
UI Startup Metrics (1280 ± 275 ms)
Benchmark value 1112 exceeds gate value 1070 for chrome browserify home mean load Benchmark value 1105 exceeds gate value 1061 for chrome browserify home mean domContentLoaded Benchmark value 25 exceeds gate value 23 for chrome browserify home mean firstReactRender Benchmark value 848 exceeds gate value 830 for chrome browserify home mean loadScripts Benchmark value 1454 exceeds gate value 1365 for chrome browserify home p95 uiStartup Benchmark value 1269 exceeds gate value 1190 for chrome browserify home p95 load Benchmark value 1263 exceeds gate value 1180 for chrome browserify home p95 domContentLoaded Benchmark value 1184 exceeds gate value 1180 for chrome browserify home p95 firstPaint Benchmark value 23 exceeds gate value 18 for chrome browserify home p95 backgroundConnect Benchmark value 1005 exceeds gate value 940 for chrome browserify home p95 loadScripts Benchmark value 19 exceeds gate value 17 for chrome browserify home p95 setupStore Benchmark value 11 exceeds gate value 9 for firefox browserify home mean setupStore Benchmark value 41 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 16 exceeds gate value 15 for firefox webpack home mean getState Benchmark value 1992 exceeds gate value 1935 for firefox webpack home p95 uiStartup Benchmark value 1634 exceeds gate value 1630 for firefox webpack home p95 loadScripts Sum of mean exceeds: 158ms | Sum of p95 exceeds: 388ms Sum of all benchmark exceeds: 546ms Bundle size diffs
|
OGPoyraz
approved these changes
Jun 5, 2025
Builds ready [c70b766]
UI Startup Metrics (1209 ± 64 ms)
Benchmark value 13 exceeds gate value 11 for firefox browserify home mean getState Benchmark value 1667 exceeds gate value 1615 for firefox webpack home mean uiStartup Benchmark value 1443 exceeds gate value 1380 for firefox webpack home mean load Benchmark value 1443 exceeds gate value 1380 for firefox webpack home mean domContentLoaded Benchmark value 28 exceeds gate value 26 for firefox webpack home mean backgroundConnect Benchmark value 45 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 1418 exceeds gate value 1360 for firefox webpack home mean loadScripts Benchmark value 1993 exceeds gate value 1935 for firefox webpack home p95 uiStartup Benchmark value 1753 exceeds gate value 1660 for firefox webpack home p95 load Benchmark value 1753 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded Benchmark value 54 exceeds gate value 50 for firefox webpack home p95 firstReactRender Benchmark value 1693 exceeds gate value 1630 for firefox webpack home p95 loadScripts Sum of mean exceeds: 247ms | Sum of p95 exceeds: 328ms Sum of all benchmark exceeds: 575ms Bundle size diffs
|
seaona
reviewed
Jun 10, 2025
Comment on lines
+118
to
+119
| const addresses = await localNodes[0].getAccounts(); | ||
| const publicAddress = addresses[0].toLowerCase(); |
There was a problem hiding this comment.
nit: maybe we could use DEFAULT_FIXTURE_ACCOUNT_LOWERCASE from constants.ts so we avoid making a call and it's slightly faster?
seaona
reviewed
Jun 10, 2025
Comment on lines
+138
to
+141
| await driver.switchToWindowWithTitle( | ||
| WINDOW_TITLES.Dialog, | ||
| windowHandles, | ||
| ); |
There was a problem hiding this comment.
could we use this instead:
Suggested change
| await driver.switchToWindowWithTitle( | |
| WINDOW_TITLES.Dialog, | |
| windowHandles, | |
| ); | |
| await driver.switchToWindowWithTitle(WINDOW_TITLES.Dialog); |
seaona
reviewed
Jun 10, 2025
Comment on lines
+149
to
+150
| await confirmation.clickFooterConfirmButton(); | ||
| await driver.delay(regularDelayMs); |
There was a problem hiding this comment.
nit: instead of having this delay, could wait for a deterministic condition? ie I think here we could wait for the pending number of signatures to decrease by 1
seaona
reviewed
Jun 10, 2025
seaona
reviewed
Jun 10, 2025
Comment on lines
+128
to
+132
| await driver.waitUntilXWindowHandles(3); | ||
| const windowHandles = await driver.getAllWindowHandles(); | ||
|
|
||
| // Switch to Dapp | ||
| await driver.switchToWindowWithTitle('E2E Test Dapp', windowHandles); |
There was a problem hiding this comment.
I think we shouldn't need this, as we already have some robust logic in the switchToWindowWithTitle for handling a window switch. Could we use this instead:
Suggested change
| await driver.waitUntilXWindowHandles(3); | |
| const windowHandles = await driver.getAllWindowHandles(); | |
| // Switch to Dapp | |
| await driver.switchToWindowWithTitle('E2E Test Dapp', windowHandles); | |
| await driver.switchToWindowWithTitle(WINDOW_TITLES.TestDApp); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Moves the personal sign queueing test to the confirmations/signatures already existing personal sign spec. Migrates the test to POM and ts.
Related issues
Fixes: MMQA-637
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist