chore: bump @metamask/bridge-controller to fix rate-limited L1 fee calculations #33465

micaelae · 2025-06-03T23:10:43Z

Description

Bumps the bridge-controller to 32.0.1 to gracefully handle rate-limited RPC requests

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/MMS-2568
Fixes: #33465

Manual testing steps

Change base RPC URL to mainnet.base.org
Fetch quotes from base:ETH to ethereum:ETH
Verify that quotes are visible on the frontend

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

fix: undo priceData workarounds

…x SOL amount

…ePropertiesEnumerated

socket-security · 2025-06-03T23:37:31Z

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff	Package	Supply Chain Security	Vulnerability	Quality	Maintenance	License
	@metamask/bridge-controller@32.0.0 ⏵ 32.0.1	⁺³		⁺¹	⁺¹

View full report

micaelae · 2025-06-03T23:55:37Z

@metamaskbot update-policies

metamaskbot · 2025-06-04T00:09:37Z

Builds ready [a53341d]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

UI Startup Metrics (1208 ± 65 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1208	1096	1404	65	1248	1322
			load	1047	936	1236	60	1090	1138
			domContentLoaded	1040	928	1225	60	1085	1132
			domInteractive	16	13	34	4	15	29
			firstPaint	761	77	1232	401	1064	1132
			backgroundConnect	8	4	30	5	8	23
			firstReactRender	20	16	54	5	21	29
			getState	13	6	29	7	19	26
			initialActions	0	0	1	0	0	1
			loadScripts	797	693	911	58	844	888
			setupStore	8	5	21	2	8	11
	Webpack	Home	uiStartup	2041	1524	2654	224	2174	2481
			load	1594	1191	1967	174	1706	1879
			domContentLoaded	1588	1187	1952	173	1701	1870
			domInteractive	15	11	57	9	13	40
			firstPaint	168	70	347	60	193	300
			backgroundConnect	21	9	87	10	22	41
			firstReactRender	122	42	410	101	131	344
			getState	13	4	303	30	12	20
			initialActions	5	1	297	29	3	4
			loadScripts	1586	1186	1941	171	1700	1859
			setupStore	49	6	319	95	18	309
Firefox	Browserify	Home	uiStartup	1343	1146	1801	131	1378	1692
			load	1184	1017	1602	110	1231	1441
			domContentLoaded	1183	1017	1601	110	1231	1441
			domInteractive	96	36	372	38	101	150
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	27	12	182	30	22	109
			firstReactRender	23	20	51	5	23	30
			getState	16	4	188	37	8	160
			initialActions	0	0	1	0	0	1
			loadScripts	1159	1007	1579	105	1214	1404
			setupStore	11	4	180	21	8	49
	Webpack	Home	uiStartup	1595	1358	2243	173	1665	2054
			load	1387	1185	2009	164	1449	1795
			domContentLoaded	1387	1185	2009	164	1448	1795
			domInteractive	77	45	136	16	81	118
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	24	15	231	22	23	33
			firstReactRender	41	30	59	4	44	48
			getState	11	4	260	26	9	27
			initialActions	0	0	1	0	1	1
			loadScripts	1366	1172	1986	165	1430	1777
			setupStore	10	5	233	23	8	19

cc: @HowardBraham
Benchmark value 23 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 49 exceeds gate value 32 for chrome webpack home mean setupStore
Benchmark value 2481 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 309 exceeds gate value 65 for chrome webpack home p95 setupStore
Benchmark value 27 exceeds gate value 25 for firefox browserify home mean backgroundConnect
Benchmark value 17 exceeds gate value 11 for firefox browserify home mean getState
Benchmark value 11 exceeds gate value 9 for firefox browserify home mean setupStore
Benchmark value 1692 exceeds gate value 1660 for firefox browserify home p95 uiStartup
Benchmark value 109 exceeds gate value 70 for firefox browserify home p95 backgroundConnect
Benchmark value 160 exceeds gate value 24 for firefox browserify home p95 getState
Benchmark value 49 exceeds gate value 27 for firefox browserify home p95 setupStore
Benchmark value 1388 exceeds gate value 1380 for firefox webpack home mean load
Benchmark value 1388 exceeds gate value 1380 for firefox webpack home mean domContentLoaded
Benchmark value 42 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 1366 exceeds gate value 1360 for firefox webpack home mean loadScripts
Benchmark value 2054 exceeds gate value 1935 for firefox webpack home p95 uiStartup
Benchmark value 1795 exceeds gate value 1660 for firefox webpack home p95 load
Benchmark value 1795 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded
Benchmark value 1777 exceeds gate value 1630 for firefox webpack home p95 loadScripts
Sum of mean exceeds: 53ms | Sum of p95 exceeds: 1041ms
Sum of all benchmark exceeds: 1094ms

metamaskbot · 2025-06-04T00:09:55Z

No policy changes

metamaskbot · 2025-06-05T01:22:34Z

Builds ready [8f42824]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

UI Startup Metrics (1243 ± 76 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1243	1084	1546	76	1295	1362
			load	1076	944	1333	72	1128	1188
			domContentLoaded	1069	940	1324	72	1118	1179
			domInteractive	17	13	98	9	16	29
			firstPaint	803	70	1273	413	1113	1187
			backgroundConnect	9	4	45	6	8	24
			firstReactRender	20	15	35	3	20	26
			getState	14	5	31	7	20	27
			initialActions	0	0	1	0	0	0
			loadScripts	822	693	1068	71	870	932
			setupStore	8	5	18	2	8	13
	Webpack	Home	uiStartup	2088	1627	2569	232	2269	2455
			load	1606	1294	1965	170	1732	1900
			domContentLoaded	1600	1290	1956	169	1724	1887
			domInteractive	15	11	57	9	13	42
			firstPaint	164	66	640	76	182	290
			backgroundConnect	22	13	63	7	25	33
			firstReactRender	152	43	365	117	312	356
			getState	17	4	349	45	13	21
			initialActions	3	1	4	1	3	4
			loadScripts	1597	1288	1945	167	1721	1876
			setupStore	42	6	320	85	18	308
Firefox	Browserify	Home	uiStartup	1337	1178	1911	124	1397	1588
			load	1184	1034	1536	103	1258	1383
			domContentLoaded	1184	1034	1536	103	1258	1383
			domInteractive	89	37	155	22	101	123
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	21	12	118	12	21	48
			firstReactRender	23	20	52	4	24	28
			getState	10	5	181	19	8	10
			initialActions	0	0	1	0	0	1
			loadScripts	1166	1016	1505	102	1243	1362
			setupStore	10	4	273	28	6	13
	Webpack	Home	uiStartup	1607	1376	2116	170	1719	1957
			load	1398	1181	1861	158	1513	1709
			domContentLoaded	1398	1181	1860	158	1513	1709
			domInteractive	76	32	163	18	82	102
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	21	16	55	6	23	32
			firstReactRender	42	32	58	4	45	50
			getState	9	5	30	4	9	17
			initialActions	0	0	2	1	1	1
			loadScripts	1379	1165	1841	159	1497	1689
			setupStore	9	5	66	9	8	25

Benchmark value 1243 exceeds gate value 1234 for chrome browserify home mean uiStartup
Benchmark value 1077 exceeds gate value 1070 for chrome browserify home mean load
Benchmark value 1069 exceeds gate value 1061 for chrome browserify home mean domContentLoaded
Benchmark value 803 exceeds gate value 800 for chrome browserify home mean firstPaint
Benchmark value 1187 exceeds gate value 1180 for chrome browserify home p95 firstPaint
Benchmark value 25 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 42 exceeds gate value 32 for chrome webpack home mean setupStore
Benchmark value 2456 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 308 exceeds gate value 65 for chrome webpack home p95 setupStore
Benchmark value 10 exceeds gate value 9 for firefox browserify home mean setupStore
Benchmark value 1398 exceeds gate value 1380 for firefox webpack home mean load
Benchmark value 1398 exceeds gate value 1380 for firefox webpack home mean domContentLoaded
Benchmark value 43 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 1379 exceeds gate value 1360 for firefox webpack home mean loadScripts
Benchmark value 1957 exceeds gate value 1935 for firefox webpack home p95 uiStartup
Benchmark value 1709 exceeds gate value 1660 for firefox webpack home p95 load
Benchmark value 1709 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded
Benchmark value 1689 exceeds gate value 1630 for firefox webpack home p95 loadScripts
Sum of mean exceeds: 98ms | Sum of p95 exceeds: 438ms
Sum of all benchmark exceeds: 536ms

micaelae and others added 30 commits May 8, 2025 14:51

chore: capture bridge tx submission exceptions

b045d82

chore: trace BridgeViewLoaded

5f013a2

chore: SendCompleted trace

3844755

chore: SwapQuotesFetched trace

c83e598

chore: BridgeBalancesUpdated trace

d3c1e45

chore: pass traceFn to bridge controllers

64ae610

refactor: quotesRefreshCount duplicate

26b38a0

refactor: pass balances to BridgeCTAButton and BridgeInputGroup

0107114

refactor: simplify debouncedUpdateQuoteRequestInController

7ba75b8

fix: show isNoQuotesAvailable if quote fetch has been attempted

ca50d59

Merge branch 'main' into mms2203-bridge-perf-instrumentation

2f0205e

chore: rename trace chainIds

13d9fce

fix: rename chainId

54ce593

chore: use preview builds

32c66a1

Update LavaMoat policies

55a6643

fix: lint issue

9ad45d2

Merge branch 'main' into mms2203-bridge-perf-instrumentation

9c0e73e

chore: bump bridge controllers

a60f9d6

chore: update yarn.lock

5691695

Merge branch 'main' into mms2203-bridge-perf-instrumentation

3b415a1

Merge branch 'main' into mms2203-bridge-perf-instrumentation

c31773b

Merge branch 'main' into mms2203-bridge-perf-instrumentation

ed7ba6f

fix: undo priceData

c5d9738

fix: undo priceData workarounds

Merge branch 'main' into mms2203-bridge-perf-instrumentation

5fcfff1

fix: call getMinimumBalanceForRentExemptionInLamports to determine ma…

b150ad1

…x SOL amount

fix: duplicate variable

b96c85d

chore: use OnProtocolRequest

89a1e66

chore: update validation error selector

9b5cd56

chore: refresh min balance on quote and chain change

a331681

test: show balance info for testing

9641292

micaelae and others added 10 commits June 2, 2025 16:48

fix: selector unit tests

ebd8e6f

Update LavaMoat policies

f91abe6

chore: add minimumBalanceForRentExemptionInLamports to ControllerStat…

c38ad09

…ePropertiesEnumerated

test: add unit tests for isInsufficientGasBalance

1cfe381

fix: pass metamask to selectMinimumBalanceForRentExemptionInSOL

00357e9

fix: sentry e2e tests

779a465

Merge branch 'main' into mms2419-rent-exemption-v2

2761b2e

Update LavaMoat policies

f7fae54

chore: undo SwapQuotesFetched srcChainId change

95878cb

chore: bump @metamask/bridge-controller

a0acfd9

metamaskbot added the team-swaps-and-bridge For issues with Swaps or Bridging label Jun 3, 2025

micaelae added the DO-NOT-MERGE Pull requests that should not be merged label Jun 3, 2025

micaelae added 2 commits June 3, 2025 16:30

fix: yarn.lock

90b2323

fix: yarn.lock

cbb7cf0

fix: yarn.lock

a53341d

SteP-n-s mentioned this pull request Jun 4, 2025

[Bug]: Bridge from / to Base fails #33395

Closed

micaelae closed this Jun 4, 2025

github-actions bot locked and limited conversation to collaborators Jun 4, 2025

Merge branch 'main' into mms2419-rent-exemption-v2

bb396b2

micaelae reopened this Jun 5, 2025

Merge branch 'mms2419-rent-exemption-v2' into mms2568-rate-limited-fees

8f42824

Base automatically changed from mms2419-rent-exemption-v2 to main June 5, 2025 17:40

MetaMask unlocked this conversation Jun 7, 2025

micaelae closed this Jun 7, 2025

github-actions bot locked and limited conversation to collaborators Jun 7, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

chore: bump @metamask/bridge-controller to fix rate-limited L1 fee calculations #33465

chore: bump @metamask/bridge-controller to fix rate-limited L1 fee calculations #33465

micaelae commented Jun 3, 2025 •

edited by SteP-n-s

Loading

Uh oh!

socket-security bot commented Jun 3, 2025 •

edited

Loading

Uh oh!

micaelae commented Jun 3, 2025

Uh oh!

metamaskbot commented Jun 4, 2025

Uh oh!

metamaskbot commented Jun 4, 2025

Uh oh!

metamaskbot commented Jun 5, 2025

Uh oh!

Uh oh!

chore: bump @metamask/bridge-controller to fix rate-limited L1 fee calculations #33465

chore: bump @metamask/bridge-controller to fix rate-limited L1 fee calculations #33465

Conversation

micaelae commented Jun 3, 2025 • edited by SteP-n-s Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

socket-security bot commented Jun 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

micaelae commented Jun 3, 2025

Uh oh!

metamaskbot commented Jun 4, 2025

Uh oh!

metamaskbot commented Jun 4, 2025

Uh oh!

metamaskbot commented Jun 5, 2025

Uh oh!

Uh oh!

micaelae commented Jun 3, 2025 •

edited by SteP-n-s

Loading

socket-security bot commented Jun 3, 2025 •

edited

Loading