Skip to content

Comments

feat: native segwit tag for bitcoin, fix tochain selection from bitcoin#36927

Merged
micaelae merged 19 commits intomainfrom
fix-bitcoin-tochain-and-native-segwit-tag
Oct 28, 2025
Merged

feat: native segwit tag for bitcoin, fix tochain selection from bitcoin#36927
micaelae merged 19 commits intomainfrom
fix-bitcoin-tochain-and-native-segwit-tag

Conversation

@ghgoodreau
Copy link
Contributor

@ghgoodreau ghgoodreau commented Oct 16, 2025

Description

This PR does these things:

  1. adds the account type tag for bitcoin
  2. fixes a bug where Bitcoin was being selected as fromChain and toChain automatically, which is not intended.
  3. updates the mUSD tag to also use the new tag component
  4. fixes a bug in which token balances don't appear for the selected token

Open in GitHub Codespaces

Changelog

CHANGELOG entry: added account type tags for bitcoin

Related issues

Fixes: #37331

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Displays Bitcoin account type tags in token lists/cells and prevents BTC→BTC destination defaults by selecting a BIP44 default EVM chain; also tightens non‑EVM handling across asset picker and gas/bundle support.

  • UI/UX:
    • Account type tags: Surface Bitcoin account type via Tag in TokenCellTitle and TokenListItem; export accountTypeLabel.
    • Asset Picker: Propagate accountType through AssetWithDisplayData, Asset, and into list items; treat non‑EVM chains using isEvmChainId.
    • Network Picker: Disable selecting Bitcoin as destination when not cross‑chain; ensure BTC cannot be both source and destination.
    • Transaction Details: Resolve destination chain name via CAIP (formatChainIdToCaip) for step descriptions.
  • Bridge State/Selectors:
    • Reducer: When fromToken is BTC and toChainId is BTC, clear toChainId and toToken.
    • getToChain: If source is Bitcoin and no explicit destination, default to BIP44 default dest chain (EVM), not Bitcoin.
    • Simplify getToChains; introduce BIP44 default parsing (parseCaipAssetType).
  • Hooks:
    • useTokensWithFiltering: Remove "selected token first" behavior; include accountType; handle BTC/SOL caching and images; normalize native addresses.
    • useMultichainBalances: Attach accountType for non‑EVM (Bitcoin) balances.
    • useGasIncluded7702 / useIsSendBundleSupported: Disable support checks on non‑EVM chains.
  • Constants:
    • Add MultichainNetworks.BITCOIN to ALLOWED_BRIDGE_CHAIN_IDS; ensure mapping for short network names.

Written by Cursor Bugbot for commit 5215bb7. This will update automatically on new commits. Configure here.

@ghgoodreau ghgoodreau changed the title feat: native segwit tag for bitcoin, fix tochain selection from bitco… feat: native segwit tag for bitcoin, fix tochain selection from bitcoin Oct 16, 2025
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-swaps-and-bridge Swaps and Bridge team label Oct 16, 2025
@metamaskbot
Copy link
Collaborator

metamaskbot commented Oct 16, 2025

✨ Files requiring CODEOWNER review ✨

👨‍🔧 @MetaMask/core-extension-ux (4 files, +15 -27)
  • 📁 ui/
    • 📁 components/
      • 📁 multichain/
        • 📁 asset-picker-amount/
          • 📁 asset-picker-modal/
            • 📄 asset-picker-modal.tsx +3 -1
            • 📄 Asset.tsx +2 -0
            • 📄 types.ts +2 -0
        • 📁 token-list-item/
          • 📄 token-list-item.tsx +8 -26

💎 @MetaMask/metamask-assets (1 files, +1 -1)
  • 📁 ui/
    • 📁 components/
      • 📁 app/
        • 📁 assets/
          • 📁 token-cell/
            • 📁 cells/
              • 📄 token-cell-title.tsx +1 -1

🔄 @MetaMask/swaps-engineers (9 files, +81 -83)
  • 📁 ui/
    • 📁 ducks/
      • 📁 bridge/
        • 📄 bridge.ts +11 -0
        • 📄 selectors.ts +44 -33
        • 📄 types.ts +2 -0
    • 📁 hooks/
      • 📁 bridge/
        • 📁 __snapshots__/
          • 📄 useTokensWithFiltering.test.ts.snap +6 -0
          • 📄 useTokensWithFiltering.ts +2 -29
    • 📁 pages/
      • 📁 bridge/
        • 📁 hooks/
          • 📄 useGasIncluded7702.ts +2 -2
          • 📄 useIsSendBundleSupported.ts +3 -5
        • 📁 prepare/
          • 📄 prepare-bridge-page.tsx +4 -1
        • 📁 transaction-details/
          • 📄 bridge-step-description.tsx +7 -13

@metamaskbot
Copy link
Collaborator

📊 Page Load Benchmark Results

Current Commit: 1a500eb | Date: 10/16/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.05s (±70ms) 🟡 | historical mean value: 1.05s ⬇️ (historical data)
  • domContentLoaded-> current mean value: 734ms (±67ms) 🟢 | historical mean value: 735ms ⬇️ (historical data)
  • firstContentfulPaint-> current mean value: 77ms (±12ms) 🟢 | historical mean value: 78ms ⬇️ (historical data)
📈 Detailed Results
Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.05s 70ms 1.01s 1.32s 1.27s 1.32s
domContentLoaded 734ms 67ms 695ms 996ms 936ms 996ms
firstPaint 77ms 12ms 60ms 176ms 88ms 176ms
firstContentfulPaint 77ms 12ms 60ms 176ms 88ms 176ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms

Results generated automatically by MetaMask CI

@metamaskbot
Copy link
Collaborator

Builds ready [1a500eb]
UI Startup Metrics (1257 ± 72 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1257112716027213041368
load107694212536311121181
domContentLoaded106893112446411031174
domInteractive18144561737
firstPaint70688128043310971180
backgroundConnect25724036114259281
firstReactRender2918157172947
getState1554071930
initialActions60699625
loadScripts81968899362854919
setupStore1063541120
WebpackHomeuiStartup8527201104788741036
load65658493380670873
domContentLoaded64857992379648865
domInteractive16114881435
firstPaint18358910165195601
backgroundConnect21104072834
firstReactRender261670103135
getState832331113
initialActions3011248
loadScripts64557791277646854
setupStore952231114
FirefoxBrowserifyHomeuiStartup14591285177010815171687
load1235107615528213011372
domContentLoaded1234107615528213001372
domInteractive1053335156107252
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect3422137133850
firstReactRender31265753241
getState1059611818
initialActions52778416
loadScripts1213105815288112731352
setupStore12761101133
WebpackHomeuiStartup15521382195611316111804
load1338119716969314021493
domContentLoaded1338119716959314021492
domInteractive1113338575106355
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect361696144067
firstReactRender282281102838
getState94718815
initialActions4173735
loadScripts1315117816709213791473
setupStore135139191046
Bundle size diffs [🚀 Bundle size reduced!]
  • background: -71.86 KiB (-1.58%)
  • ui: 1.6 KiB (0.02%)
  • common: 57.49 KiB (0.69%)

@metamaskbot
Copy link
Collaborator

📊 Page Load Benchmark Results

Current Commit: 3f75b5e | Date: 10/16/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.06s (±78ms) 🟡 | historical mean value: 1.05s ⬆️ (historical data)
  • domContentLoaded-> current mean value: 743ms (±75ms) 🟢 | historical mean value: 735ms ⬆️ (historical data)
  • firstContentfulPaint-> current mean value: 78ms (±14ms) 🟢 | historical mean value: 78ms ⬆️ (historical data)
📈 Detailed Results
Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.06s 78ms 1.02s 1.44s 1.30s 1.44s
domContentLoaded 743ms 75ms 704ms 1.09s 954ms 1.09s
firstPaint 78ms 14ms 60ms 208ms 88ms 208ms
firstContentfulPaint 78ms 14ms 60ms 208ms 88ms 208ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms

Results generated automatically by MetaMask CI

@metamaskbot
Copy link
Collaborator

Builds ready [3f75b5e]
UI Startup Metrics (1271 ± 73 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1271114514637313241411
load109198012816911401235
domContentLoaded108497512756911291228
domInteractive18135171738
firstPaint678140128144411071237
backgroundConnect2562432919259282
firstReactRender27175072846
getState1556481929
initialActions60819817
loadScripts835725102968876982
setupStore1062231218
WebpackHomeuiStartup8397211068708501041
load63358290469643854
domContentLoaded62557789569634849
domInteractive16116291435
firstPaint18154898167191602
backgroundConnect21114062532
firstReactRender27176983235
getState941931114
initialActions3010247
loadScripts62357488466632838
setupStore1053541115
FirefoxBrowserifyHomeuiStartup14271253209714014731703
load1197107214318412521363
domContentLoaded1196107214318412521362
domInteractive98342925697253
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect32227993548
firstReactRender30254643141
getState12520121833
initialActions52285421
loadScripts1175105713888112271342
setupStore146139181156
WebpackHomeuiStartup15611405208111315941790
load1339118816598013731498
domContentLoaded1339118816588013731497
domInteractive953034149101183
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect352071104165
firstReactRender352781113570
getState94486917
initialActions51748314
loadScripts1315116616337913481474
setupStore13674131050
Bundle size diffs [🚀 Bundle size reduced!]
  • background: -71.86 KiB (-1.58%)
  • ui: 1.6 KiB (0.02%)
  • common: 57.49 KiB (0.69%)

@metamaskbot
Copy link
Collaborator

📊 Page Load Benchmark Results

Current Commit: 20ddd26 | Date: 10/16/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.07s (±72ms) 🟡 | historical mean value: 1.05s ⬆️ (historical data)
  • domContentLoaded-> current mean value: 754ms (±70ms) 🟢 | historical mean value: 738ms ⬆️ (historical data)
  • firstContentfulPaint-> current mean value: 82ms (±14ms) 🟢 | historical mean value: 78ms ⬆️ (historical data)
📈 Detailed Results
Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.07s 72ms 1.03s 1.38s 1.28s 1.38s
domContentLoaded 754ms 70ms 713ms 1.05s 955ms 1.05s
firstPaint 82ms 14ms 64ms 196ms 92ms 196ms
firstContentfulPaint 82ms 14ms 64ms 196ms 92ms 196ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms

Results generated automatically by MetaMask CI

@metamaskbot
Copy link
Collaborator

Builds ready [20ddd26]
UI Startup Metrics (1261 ± 69 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1261113514546913031396
load108396912846411141204
domContentLoaded107896412786411081198
domInteractive18145581742
firstPaint62185128244510951204
backgroundConnect2532392827257264
firstReactRender25195052637
getState165103111929
initialActions61678616
loadScripts830725102862856952
setupStore1062831016
WebpackHomeuiStartup841730110258866963
load63258788156640776
domContentLoaded62458186255634769
domInteractive16125181440
firstPaint18257894188174607
backgroundConnect2311158152533
firstReactRender2817101113236
getState941631115
initialActions307246
loadScripts62057982348632727
setupStore1051631214
FirefoxBrowserifyHomeuiStartup14751263192011815331683
load1238107214538713121379
domContentLoaded1238107114528713111378
domInteractive1013530252104256
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect362286114062
firstReactRender31276863242
getState96768917
initialActions4256549
loadScripts1215105414318612871354
setupStore156153251152
WebpackHomeuiStartup15951428197410816421896
load1366121117058714051513
domContentLoaded1365121117048714051513
domInteractive983134550100188
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect3620120164169
firstReactRender3326152133441
getState10313216923
initialActions6117918414
loadScripts1342119416548413771495
setupStore13659111134
Bundle size diffs [🚀 Bundle size reduced!]
  • background: -71.86 KiB (-1.58%)
  • ui: 1.57 KiB (0.02%)
  • common: 57.49 KiB (0.69%)

@metamaskbot
Copy link
Collaborator

📊 Page Load Benchmark Results

Current Commit: 0c8ed0b | Date: 10/16/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.05s (±72ms) 🟡 | historical mean value: 1.05s ⬆️ (historical data)
  • domContentLoaded-> current mean value: 737ms (±69ms) 🟢 | historical mean value: 738ms ⬇️ (historical data)
  • firstContentfulPaint-> current mean value: 78ms (±15ms) 🟢 | historical mean value: 78ms ⬆️ (historical data)
📈 Detailed Results
Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.05s 72ms 1.01s 1.33s 1.27s 1.33s
domContentLoaded 737ms 69ms 697ms 1.00s 947ms 1.00s
firstPaint 78ms 15ms 60ms 208ms 92ms 208ms
firstContentfulPaint 78ms 15ms 60ms 208ms 92ms 208ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms

Results generated automatically by MetaMask CI

@metamaskbot
Copy link
Collaborator

Builds ready [0c8ed0b]
UI Startup Metrics (1238 ± 75 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1238110714987512851379
load106592413077011111186
domContentLoaded105991713037011051179
domInteractive17136161724
firstPaint688144118742910861166
backgroundConnect2512392848256265
firstReactRender25194752637
getState1464971727
initialActions40213511
loadScripts813680104868862934
setupStore962331014
WebpackHomeuiStartup8427111121838601046
load64357994687638886
domContentLoaded63557493986631876
domInteractive15115181437
firstPaint20258922194198593
backgroundConnect22114782637
firstReactRender26176383133
getState942831114
initialActions3011246
loadScripts63357293784630865
setupStore952731113
FirefoxBrowserifyHomeuiStartup1433126517489914681644
load1217106613917112641344
domContentLoaded1217106613917112641343
domInteractive1023429750102245
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect3221108123643
firstReactRender29254432938
getState85868814
initialActions4217338
loadScripts1196104813696912421313
setupStore126105131033
WebpackHomeuiStartup16171421211512616601851
load13851243174410014411625
domContentLoaded13851243174310014411624
domInteractive1173340576116363
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect352273104160
firstReactRender302381113250
getState10415115913
initialActions7216219416
loadScripts1363122717019914201598
setupStore146248251037
Bundle size diffs [🚀 Bundle size reduced!]
  • background: -71.71 KiB (-1.58%)
  • ui: 1.79 KiB (0.03%)
  • common: 58.31 KiB (0.7%)

@ghgoodreau ghgoodreau marked this pull request as ready for review October 22, 2025 15:20
@ghgoodreau ghgoodreau requested review from a team as code owners October 22, 2025 15:20
cursor[bot]

This comment was marked as outdated.

@metamaskbot
Copy link
Collaborator

📊 Page Load Benchmark Results

Current Commit: 57ec918 | Date: 10/22/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.05s (±70ms) 🟡 | historical mean value: 1.05s ⬇️ (historical data)
  • domContentLoaded-> current mean value: 732ms (±68ms) 🟢 | historical mean value: 738ms ⬇️ (historical data)
  • firstContentfulPaint-> current mean value: 76ms (±10ms) 🟢 | historical mean value: 79ms ⬇️ (historical data)
📈 Detailed Results
Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.05s 70ms 1.01s 1.31s 1.27s 1.31s
domContentLoaded 732ms 68ms 698ms 999ms 936ms 999ms
firstPaint 76ms 10ms 60ms 152ms 88ms 152ms
firstContentfulPaint 76ms 10ms 60ms 152ms 88ms 152ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms

Results generated automatically by MetaMask CI

@metamaskbot
Copy link
Collaborator

Builds ready [57ec918]
UI Startup Metrics (1308 ± 108 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyStandard HomeuiStartup13081097184010813701505
load1132938157110011851327
domContentLoaded1125903156610111791319
domInteractive201471101947
firstPaint68288137045911291264
backgroundConnect24822135517253264
firstReactRender27196382846
getState15495111729
initialActions50295616
loadScripts8846791326999371069
setupStore1043231014
BrowserifyPower User HomeuiStartup21301755392057323403920
load1033878156922612781569
domContentLoaded1022869155422212681554
domInteractive271583225183
firstPaint770166156347813001563
backgroundConnect21719131329226313
firstReactRender23202922329
getState20217625120212251
initialActions14296231196
loadScripts816683132520410551325
setupStore1372772227
WebpackStandard HomeuiStartup8387241086668561010
load63358589864634823
domContentLoaded62557888964626814
domInteractive15114071436
firstPaint18757891177194599
backgroundConnect23114762734
firstReactRender27176383233
getState932441114
initialActions3011246
loadScripts62257687862623800
setupStore1052331214
WebpackPower User HomeuiStartup17431231238538221622385
load73362810251268561025
domContentLoaded713610987116806987
domInteractive241361174361
firstPaint48265994339810994
backgroundConnect23620834251331834
firstReactRender22202822228
getState1653418835180188
initialActions715212552
loadScripts708608975112795975
setupStore1272751527
FirefoxBrowserifyStandard HomeuiStartup14481246188710715021674
load1234107514717512901362
domContentLoaded1234107514717512901362
domInteractive1182930446126220
firstPaint------
backgroundConnect3922124194187
firstReactRender25216462639
getState95799815
initialActions8117323423
loadScripts1207105913727212671343
setupStore1264981133
BrowserifyPower User HomeuiStartup26252381309622328553096
load14301188166215916221662
domContentLoaded14301187166216016221662
domInteractive1767744590242445
firstPaint------
backgroundConnect16728618217392618
firstReactRender38274764447
getState1618423443206234
initialActions13264151564
loadScripts13881166162113815421621
setupStore26796272896
WebpackStandard HomeuiStartup15781381216112716171813
load1349118816829714061539
domContentLoaded1349118716819714061539
domInteractive1043038367103357
firstPaint------
backgroundConnect402394174380
firstReactRender302178103358
getState114125141148
initialActions41294313
loadScripts1323116916389413811512
setupStore15698181069
WebpackPower User HomeuiStartup29582462365137633273651
load17131423219022719262190
domContentLoaded17121422218922719262189
domInteractive1664437789262377
firstPaint------
backgroundConnect15535581167222581
firstReactRender43306494964
getState16610027649222276
initialActions16271201871
loadScripts16551396198619118901986
setupStore3262034734203
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 79.02 KiB (1.74%)
  • ui: 58.48 KiB (0.9%)
  • common: 348.88 KiB (4.18%)

@a-breslin
Copy link

Fixes #37126

@metamaskbot
Copy link
Collaborator

📊 Page Load Benchmark Results

Current Commit: 50fb096 | Date: 10/27/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.04s (±62ms) 🟡 | historical mean value: 1.04s ⬆️ (historical data)
  • domContentLoaded-> current mean value: 730ms (±59ms) 🟢 | historical mean value: 728ms ⬆️ (historical data)
  • firstContentfulPaint-> current mean value: 76ms (±13ms) 🟢 | historical mean value: 80ms ⬇️ (historical data)
📈 Detailed Results
Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.04s 62ms 1.01s 1.32s 1.25s 1.32s
domContentLoaded 730ms 59ms 698ms 997ms 934ms 997ms
firstPaint 76ms 13ms 56ms 184ms 88ms 184ms
firstContentfulPaint 76ms 13ms 56ms 184ms 88ms 184ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms

Results generated automatically by MetaMask CI

@metamaskbot
Copy link
Collaborator

Builds ready [50fb096]
UI Startup Metrics (1273 ± 76 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyStandard HomeuiStartup1273112914677613141416
load109495512707711361233
domContentLoaded108895312637611311226
domInteractive201478101843
firstPaint64285127445111121217
backgroundConnect2322202536236241
firstReactRender26164862839
getState2099092231
initialActions50647611
loadScripts8627291034769071001
setupStore962121015
BrowserifyPower User HomeuiStartup22441818406360222444063
load1170944175528615071755
domContentLoaded1160936174528314971745
domInteractive311670195670
firstPaint771194175555410341755
backgroundConnect28223062394318623
firstReactRender26233742737
getState18214833643185336
initialActions1921253614125
loadScripts908714139024612061390
setupStore1082031020
WebpackStandard HomeuiStartup8727391174788941042
load64859396168650845
domContentLoaded64058895468642836
domInteractive16114371440
firstPaint19360900198196753
backgroundConnect24135382837
firstReactRender281786103439
getState1252941416
initialActions3122347
loadScripts63758694466640825
setupStore1052941216
WebpackPower User HomeuiStartup16931258235733321572357
load73062312011587581201
domContentLoaded69761011131327261113
domInteractive211340103540
firstPaint47579813250651813
backgroundConnect10522400116235400
firstReactRender25233322633
getState16114222426181224
initialActions1318125781
loadScripts69260811021297161102
setupStore2961033049103
FirefoxBrowserifyStandard HomeuiStartup1470127417809415251634
load1256109914457313081401
domContentLoaded1256109914447313071401
domInteractive1153628743130198
firstPaint------
backgroundConnect4624196264998
firstReactRender24215032528
getState84364915
initialActions3141436
loadScripts1227108114096912791343
setupStore1375471326
BrowserifyPower User HomeuiStartup26602276359432329653594
load14431210177716315741777
domContentLoaded14431210177716315741777
domInteractive2129737597298375
firstPaint------
backgroundConnect17833440139333440
firstReactRender41296294762
getState1387921030151210
initialActions10140111240
loadScripts13951190171415315481714
setupStore26659154659
WebpackStandard HomeuiStartup15751409210512916061871
load1348117616429813921552
domContentLoaded1348117616419813911552
domInteractive1103439669107292
firstPaint------
backgroundConnect4425142184979
firstReactRender292279122867
getState114178221115
initialActions6118621316
loadScripts1322115916109513611531
setupStore1365371333
WebpackPower User HomeuiStartup26832231336838431253368
load15361291203422417282034
domContentLoaded15361291203422417272034
domInteractive1356725659211256
firstPaint------
backgroundConnect20148556174460556
firstReactRender402993154093
getState1287025845152258
initialActions712051220
loadScripts14711263186819016681868
setupStore28970204970
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: -304 Bytes (-0.01%)
  • ui: 265 Bytes (0%)
  • common: 2.88 KiB (0.03%)

cursor[bot]

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

@metamaskbot
Copy link
Collaborator

📊 Page Load Benchmark Results

Current Commit: 0012f4e | Date: 10/28/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.04s (±39ms) 🟡 | historical mean value: 1.04s ⬇️ (historical data)
  • domContentLoaded-> current mean value: 723ms (±37ms) 🟢 | historical mean value: 728ms ⬇️ (historical data)
  • firstContentfulPaint-> current mean value: 78ms (±12ms) 🟢 | historical mean value: 80ms ⬇️ (historical data)
📈 Detailed Results
Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.04s 39ms 1.01s 1.32s 1.07s 1.32s
domContentLoaded 723ms 37ms 699ms 986ms 748ms 986ms
firstPaint 78ms 12ms 56ms 184ms 88ms 184ms
firstContentfulPaint 78ms 12ms 56ms 184ms 88ms 184ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms

Results generated automatically by MetaMask CI

@metamaskbot
Copy link
Collaborator

Builds ready [0012f4e]
UI Startup Metrics (1276 ± 78 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyStandard HomeuiStartup1276113914477813331425
load109296512747311371222
domContentLoaded108696312657211301215
domInteractive2114127142146
firstPaint61676127245311041226
backgroundConnect2332222587237247
firstReactRender28175683346
getState2095072433
initialActions61467725
loadScripts859740104473904996
setupStore1062331114
BrowserifyPower User HomeuiStartup21801815338749722193387
load1150939170427913651704
domContentLoaded1140933168027313581680
domInteractive311583204383
firstPaint733188169248910441692
backgroundConnect24822333030265330
firstReactRender25232922629
getState1879725429199254
initialActions1235015850
loadScripts902715142825311011428
setupStore1482772227
WebpackStandard HomeuiStartup8517241236918531119
load64058699584639886
domContentLoaded63258197283634873
domInteractive15114481340
firstPaint20258998199198607
backgroundConnect23114782841
firstReactRender27176583135
getState1152431416
initialActions31203410
loadScripts62958096180632862
setupStore1051931114
WebpackPower User HomeuiStartup16851257232834120332328
load714608987114812987
domContentLoaded67960188085784880
domInteractive20133793337
firstPaint48064885296789885
backgroundConnect12415457156153457
firstReactRender24222922529
getState1658119523173195
initialActions1411603812160
loadScripts67459986982771869
setupStore14651121951
FirefoxBrowserifyStandard HomeuiStartup1446126318109415021590
load1235109513946912851369
domContentLoaded1235109513936912851369
domInteractive1153624241119212
firstPaint------
backgroundConnect3923111154566
firstReactRender24205542528
getState9423623811
initialActions3011135
loadScripts1211107813656612601331
setupStore1243861226
BrowserifyPower User HomeuiStartup27332389350133029953501
load14131193170614715331706
domContentLoaded14121192170514715331705
domInteractive1839742696250426
firstPaint------
backgroundConnect15243470141161470
firstReactRender39294974849
getState1729424042211240
initialActions61144814
loadScripts13711150167814514901678
setupStore22668193068
WebpackStandard HomeuiStartup16081398220712916471841
load1372120316229014111540
domContentLoaded1371120216229014101539
domInteractive1063138861108257
firstPaint------
backgroundConnect50251372459105
firstReactRender28227582839
getState949812815
initialActions4173737
loadScripts1340118315848613791515
setupStore157210211331
WebpackPower User HomeuiStartup30772638445550934064455
load17401468232823119302328
domContentLoaded17391468232823119302328
domInteractive18665496112262496
firstPaint------
backgroundConnect2153211182931551118
firstReactRender44325685156
getState16810024436186244
initialActions1521012417101
loadScripts16671428200518018932005
setupStore3261553853155
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: -304 Bytes (-0.01%)
  • ui: 238 Bytes (0%)
  • common: 2.88 KiB (0.03%)

cursor[bot]

This comment was marked as outdated.

@metamaskbot
Copy link
Collaborator

📊 Page Load Benchmark Results

Current Commit: 555af64 | Date: 10/28/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.03s (±43ms) 🟡 | historical mean value: 1.04s ⬇️ (historical data)
  • domContentLoaded-> current mean value: 717ms (±41ms) 🟢 | historical mean value: 728ms ⬇️ (historical data)
  • firstContentfulPaint-> current mean value: 76ms (±13ms) 🟢 | historical mean value: 80ms ⬇️ (historical data)
📈 Detailed Results
Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.03s 43ms 1.01s 1.36s 1.06s 1.36s
domContentLoaded 717ms 41ms 698ms 1.04s 741ms 1.04s
firstPaint 76ms 13ms 56ms 188ms 88ms 188ms
firstContentfulPaint 76ms 13ms 56ms 188ms 88ms 188ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms

Results generated automatically by MetaMask CI

@metamaskbot
Copy link
Collaborator

Builds ready [555af64]
UI Startup Metrics (1213 ± 92 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyStandard HomeuiStartup1213102314219212741357
load103787012529111021188
domContentLoaded103186712449010961182
domInteractive201399111945
firstPaint63385118842410711146
backgroundConnect1871742127191200
firstReactRender28185373143
getState1673561928
initialActions60498623
loadScripts8496891072919181002
setupStore1053641017
BrowserifyPower User HomeuiStartup23761872434178734254341
load1170941187934916901879
domContentLoaded1160935186534216811865
domInteractive281670184970
firstPaint6477817885549821788
backgroundConnect280224759127295759
firstReactRender26243532635
getState23719146371230463
initialActions1039422794
loadScripts912712146230113941462
setupStore1292451224
WebpackStandard HomeuiStartup844719113871859984
load63257796462642765
domContentLoaded62557295360635758
domInteractive15114771432
firstPaint19358936199161696
backgroundConnect23115382739
firstReactRender27165583239
getState1252441420
initialActions3012246
loadScripts62157094258632747
setupStore1042431214
WebpackPower User HomeuiStartup18531510259938124472599
load74663310921468631092
domContentLoaded716612997128833997
domInteractive221349113349
firstPaint51012110023036741002
backgroundConnect11236323110222323
firstReactRender25233322633
getState19412825426197254
initialActions141186454186
loadScripts712609986125822986
setupStore18797241197
FirefoxBrowserifyStandard HomeuiStartup14551247191412415031764
load1243108216349713021452
domContentLoaded1243108116349713011451
domInteractive1213437258133252
firstPaint------
backgroundConnect4223206244679
firstReactRender25215352536
getState10424224818
initialActions3138436
loadScripts1217106616139212771383
setupStore1263441220
BrowserifyPower User HomeuiStartup26602140386248328853862
load14251199180919015461809
domContentLoaded14241198180819015461808
domInteractive1368125052182250
firstPaint------
backgroundConnect2594911343402611134
firstReactRender37285894458
getState1355022350191223
initialActions61287628
loadScripts13341145153411114451534
setupStore27681213681
WebpackStandard HomeuiStartup16711470223613116881974
load14341227173710914721709
domContentLoaded14341227173610914721708
domInteractive1113346367109229
firstPaint------
backgroundConnect4923144225681
firstReactRender302288112967
getState84527818
initialActions41566310
loadScripts14021208169610314371643
setupStore14780101430
WebpackPower User HomeuiStartup30252398437054733064370
load16561357240425218092404
domContentLoaded16551356240325218092403
domInteractive1485137380194373
firstPaint------
backgroundConnect22135829245353829
firstReactRender40315385053
getState1859033363240333
initialActions1022681426
loadScripts15991327218020917472180
setupStore4062365665236
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 58 Bytes (0%)
  • ui: 255 Bytes (0%)
  • common: 39 Bytes (0%)

@metamaskbot
Copy link
Collaborator

📊 Page Load Benchmark Results

Current Commit: 5215bb7 | Date: 10/28/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.05s (±73ms) 🟡 | historical mean value: 1.04s ⬆️ (historical data)
  • domContentLoaded-> current mean value: 737ms (±70ms) 🟢 | historical mean value: 727ms ⬆️ (historical data)
  • firstContentfulPaint-> current mean value: 78ms (±12ms) 🟢 | historical mean value: 80ms ⬇️ (historical data)
📈 Detailed Results
Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.05s 73ms 1.01s 1.34s 1.28s 1.34s
domContentLoaded 737ms 70ms 699ms 1.02s 943ms 1.02s
firstPaint 78ms 12ms 60ms 184ms 88ms 184ms
firstContentfulPaint 78ms 12ms 60ms 184ms 88ms 184ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms

Results generated automatically by MetaMask CI

@metamaskbot
Copy link
Collaborator

Builds ready [5215bb7]
UI Startup Metrics (1272 ± 86 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyStandard HomeuiStartup1272113514958613341427
load109495413208611541251
domContentLoaded108791913148711491242
domInteractive19145381843
firstPaint64974128444510961222
backgroundConnect23322031712236254
firstReactRender27174673143
getState1984672234
initialActions50245621
loadScripts8626921088879311017
setupStore1052231016
BrowserifyPower User HomeuiStartup23641910425072332474250
load1185949206236716672062
domContentLoaded1173944203835916582038
domInteractive33161142550114
firstPaint900208179844110081798
backgroundConnect277221663104287663
firstReactRender25233222632
getState21115835239209352
initialActions62205820
loadScripts928719161932113951619
setupStore1773282632
WebpackStandard HomeuiStartup8407201115718521037
load63158493270638848
domContentLoaded62357992770633840
domInteractive15114671435
firstPaint21558903210191710
backgroundConnect23105072636
firstReactRender271788103134
getState1262441419
initialActions3015257
loadScripts62057791667630828
setupStore941631213
WebpackPower User HomeuiStartup17941334278340719922783
load76463212921848891292
domContentLoaded72562111481508041148
domInteractive20134692646
firstPaint51811611533388081153
backgroundConnect10915431132172431
firstReactRender27233832738
getState18511524029193240
initialActions818120381
loadScripts72061811341467941134
setupStore16799221299
FirefoxBrowserifyStandard HomeuiStartup1600141320079516681752
load1361117817368414171503
domContentLoaded1361117817368414171502
domInteractive1283839357137268
firstPaint------
backgroundConnect4829149195380
firstReactRender28225872850
getState73162912
initialActions4294947
loadScripts1331115217058613861479
setupStore1576991534
BrowserifyPower User HomeuiStartup27242234360937529343609
load1403126915839114851583
domContentLoaded1402126915839114841583
domInteractive1539731464197314
firstPaint------
backgroundConnect24460645172359645
firstReactRender392862104862
getState1559022339197223
initialActions13175231075
loadScripts13411204154610614481546
setupStore31767185167
WebpackStandard HomeuiStartup16991497234312617281997
load1441128018309214881609
domContentLoaded1440128018309214881609
domInteractive1143244369113324
firstPaint------
backgroundConnect5028113195789
firstReactRender31238693142
getState9411311815
initialActions7221923410
loadScripts1409125618079114531579
setupStore15880101429
WebpackPower User HomeuiStartup30692560453961035904539
load16961437212726420312127
domContentLoaded16951437212626420312126
domInteractive1648137575221375
firstPaint------
backgroundConnect2476211373083301137
firstReactRender493296155496
getState18310930549216305
initialActions62184818
loadScripts16381397209124319032091
setupStore32772205172
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 58 Bytes (0%)
  • ui: 255 Bytes (0%)
  • common: 39 Bytes (0%)

@ghgoodreau ghgoodreau added this pull request to the merge queue Oct 28, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 28, 2025
@micaelae micaelae added this pull request to the merge queue Oct 28, 2025
Merged via the queue into main with commit 1b9b762 Oct 28, 2025
176 checks passed
@micaelae micaelae deleted the fix-bitcoin-tochain-and-native-segwit-tag branch October 28, 2025 17:06
@github-actions github-actions bot locked and limited conversation to collaborators Oct 28, 2025
@metamaskbot metamaskbot added the release-13.8.0 Issue or pull request that will be included in release 13.8.0 label Oct 28, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-13.8.0 Issue or pull request that will be included in release 13.8.0 size-M team-swaps-and-bridge Swaps and Bridge team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Destination asset is shown twice and has no visible balance

7 participants