feat: native segwit tag for bitcoin, fix tochain selection from bitcoin #36927

ghgoodreau · 2025-10-16T18:56:42Z

Description

This PR does three things:

adds the account type tag for bitcoin
fixes a bug where Bitcoin was being selected as fromChain and toChain automatically, which is not intended.
updates the mUSD tag to also use the new tag component

Changelog

CHANGELOG entry: added account type tags for bitcoin

Related issues

Fixes:

Manual testing steps

Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

…in in selector

github-actions · 2025-10-16T18:56:55Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

metamaskbot · 2025-10-16T18:59:21Z

✨ Files requiring CODEOWNER review ✨

👨‍🔧 @MetaMask/core-extension-ux (3 files, +12 -26)

📁 ui/
- 📁 components/
  - 📁 multichain/
    - 📁 asset-picker-amount/
      - 📁 asset-picker-modal/
        
        📄 Asset.tsx +2 -0
        
        📄 types.ts +2 -0
    - 📁 token-list-item/
      - 📄 token-list-item.tsx +8 -26

💎 @MetaMask/metamask-assets (1 files, +1 -1)

📁 ui/
- 📁 components/
  - 📁 app/
    - 📁 assets/
      - 📁 token-cell/
        
        📁 cells/
        
        📄 token-cell-title.tsx +1 -1

🔄 @MetaMask/swaps-engineers (3 files, +40 -7)

📁 ui/
- 📁 ducks/
  - 📁 bridge/
    - 📄 selectors.ts +18 -7
    - 📄 types.ts +2 -0
- 📁 hooks/
  - 📁 bridge/
    - 📄 useTokensWithFiltering.ts +20 -0

metamaskbot · 2025-10-16T19:28:17Z

📊 Page Load Benchmark Results

Current Commit: 1a500eb | Date: 10/16/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.05s (±70ms) 🟡 | historical mean value: 1.05s ⬇️ (historical data)
domContentLoaded-> current mean value: 734ms (±67ms) 🟢 | historical mean value: 735ms ⬇️ (historical data)
firstContentfulPaint-> current mean value: 77ms (±12ms) 🟢 | historical mean value: 78ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.05s	70ms	1.01s	1.32s	1.27s	1.32s
domContentLoaded	734ms	67ms	695ms	996ms	936ms	996ms
firstPaint	77ms	12ms	60ms	176ms	88ms	176ms
firstContentfulPaint	77ms	12ms	60ms	176ms	88ms	176ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Results generated automatically by MetaMask CI

metamaskbot · 2025-10-16T19:28:31Z

Builds ready [1a500eb]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- content-script: 0
- offscreen: 0

UI Startup Metrics (1257 ± 72 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1257	1127	1602	72	1304	1368
			load	1076	942	1253	63	1112	1181
			domContentLoaded	1068	931	1244	64	1103	1174
			domInteractive	18	14	45	6	17	37
			firstPaint	706	88	1280	433	1097	1180
			backgroundConnect	257	240	361	14	259	281
			firstReactRender	29	18	157	17	29	47
			getState	15	5	40	7	19	30
			initialActions	6	0	69	9	6	25
			loadScripts	819	688	993	62	854	919
			setupStore	10	6	35	4	11	20
	Webpack	Home	uiStartup	852	720	1104	78	874	1036
			load	656	584	933	80	670	873
			domContentLoaded	648	579	923	79	648	865
			domInteractive	16	11	48	8	14	35
			firstPaint	183	58	910	165	195	601
			backgroundConnect	21	10	40	7	28	34
			firstReactRender	26	16	70	10	31	35
			getState	8	3	23	3	11	13
			initialActions	3	0	11	2	4	8
			loadScripts	645	577	912	77	646	854
			setupStore	9	5	22	3	11	14
Firefox	Browserify	Home	uiStartup	1459	1285	1770	108	1517	1687
			load	1235	1076	1552	82	1301	1372
			domContentLoaded	1234	1076	1552	82	1300	1372
			domInteractive	105	33	351	56	107	252
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	34	22	137	13	38	50
			firstReactRender	31	26	57	5	32	41
			getState	10	5	96	11	8	18
			initialActions	5	2	77	8	4	16
			loadScripts	1213	1058	1528	81	1273	1352
			setupStore	12	7	61	10	11	33
	Webpack	Home	uiStartup	1552	1382	1956	113	1611	1804
			load	1338	1197	1696	93	1402	1493
			domContentLoaded	1338	1197	1695	93	1402	1492
			domInteractive	111	33	385	75	106	355
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	36	16	96	14	40	67
			firstReactRender	28	22	81	10	28	38
			getState	9	4	71	8	8	15
			initialActions	4	1	73	7	3	5
			loadScripts	1315	1178	1670	92	1379	1473
			setupStore	13	5	139	19	10	46

Bundle size diffs [🚀 Bundle size reduced!]

background: -71.86 KiB (-1.58%)
ui: 1.6 KiB (0.02%)
common: 57.49 KiB (0.69%)

metamaskbot · 2025-10-16T20:00:51Z

📊 Page Load Benchmark Results

Current Commit: 3f75b5e | Date: 10/16/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.06s (±78ms) 🟡 | historical mean value: 1.05s ⬆️ (historical data)
domContentLoaded-> current mean value: 743ms (±75ms) 🟢 | historical mean value: 735ms ⬆️ (historical data)
firstContentfulPaint-> current mean value: 78ms (±14ms) 🟢 | historical mean value: 78ms ⬆️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.06s	78ms	1.02s	1.44s	1.30s	1.44s
domContentLoaded	743ms	75ms	704ms	1.09s	954ms	1.09s
firstPaint	78ms	14ms	60ms	208ms	88ms	208ms
firstContentfulPaint	78ms	14ms	60ms	208ms	88ms	208ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Results generated automatically by MetaMask CI

metamaskbot · 2025-10-16T20:00:56Z

Builds ready [3f75b5e]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- content-script: 0
- offscreen: 0

UI Startup Metrics (1271 ± 73 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1271	1145	1463	73	1324	1411
			load	1091	980	1281	69	1140	1235
			domContentLoaded	1084	975	1275	69	1129	1228
			domInteractive	18	13	51	7	17	38
			firstPaint	678	140	1281	444	1107	1237
			backgroundConnect	256	243	291	9	259	282
			firstReactRender	27	17	50	7	28	46
			getState	15	5	64	8	19	29
			initialActions	6	0	81	9	8	17
			loadScripts	835	725	1029	68	876	982
			setupStore	10	6	22	3	12	18
	Webpack	Home	uiStartup	839	721	1068	70	850	1041
			load	633	582	904	69	643	854
			domContentLoaded	625	577	895	69	634	849
			domInteractive	16	11	62	9	14	35
			firstPaint	181	54	898	167	191	602
			backgroundConnect	21	11	40	6	25	32
			firstReactRender	27	17	69	8	32	35
			getState	9	4	19	3	11	14
			initialActions	3	0	10	2	4	7
			loadScripts	623	574	884	66	632	838
			setupStore	10	5	35	4	11	15
Firefox	Browserify	Home	uiStartup	1427	1253	2097	140	1473	1703
			load	1197	1072	1431	84	1252	1363
			domContentLoaded	1196	1072	1431	84	1252	1362
			domInteractive	98	34	292	56	97	253
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	32	22	79	9	35	48
			firstReactRender	30	25	46	4	31	41
			getState	12	5	201	21	8	33
			initialActions	5	2	28	5	4	21
			loadScripts	1175	1057	1388	81	1227	1342
			setupStore	14	6	139	18	11	56
	Webpack	Home	uiStartup	1561	1405	2081	113	1594	1790
			load	1339	1188	1659	80	1373	1498
			domContentLoaded	1339	1188	1658	80	1373	1497
			domInteractive	95	30	341	49	101	183
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	35	20	71	10	41	65
			firstReactRender	35	27	81	11	35	70
			getState	9	4	48	6	9	17
			initialActions	5	1	74	8	3	14
			loadScripts	1315	1166	1633	79	1348	1474
			setupStore	13	6	74	13	10	50

Bundle size diffs [🚀 Bundle size reduced!]

background: -71.86 KiB (-1.58%)
ui: 1.6 KiB (0.02%)
common: 57.49 KiB (0.69%)

metamaskbot · 2025-10-16T21:08:02Z

📊 Page Load Benchmark Results

Current Commit: 20ddd26 | Date: 10/16/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.07s (±72ms) 🟡 | historical mean value: 1.05s ⬆️ (historical data)
domContentLoaded-> current mean value: 754ms (±70ms) 🟢 | historical mean value: 738ms ⬆️ (historical data)
firstContentfulPaint-> current mean value: 82ms (±14ms) 🟢 | historical mean value: 78ms ⬆️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.07s	72ms	1.03s	1.38s	1.28s	1.38s
domContentLoaded	754ms	70ms	713ms	1.05s	955ms	1.05s
firstPaint	82ms	14ms	64ms	196ms	92ms	196ms
firstContentfulPaint	82ms	14ms	64ms	196ms	92ms	196ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Results generated automatically by MetaMask CI

metamaskbot · 2025-10-16T21:08:10Z

Builds ready [20ddd26]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- content-script: 0
- offscreen: 0

UI Startup Metrics (1261 ± 69 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1261	1135	1454	69	1303	1396
			load	1083	969	1284	64	1114	1204
			domContentLoaded	1078	964	1278	64	1108	1198
			domInteractive	18	14	55	8	17	42
			firstPaint	621	85	1282	445	1095	1204
			backgroundConnect	253	239	282	7	257	264
			firstReactRender	25	19	50	5	26	37
			getState	16	5	103	11	19	29
			initialActions	6	1	67	8	6	16
			loadScripts	830	725	1028	62	856	952
			setupStore	10	6	28	3	10	16
	Webpack	Home	uiStartup	841	730	1102	58	866	963
			load	632	587	881	56	640	776
			domContentLoaded	624	581	862	55	634	769
			domInteractive	16	12	51	8	14	40
			firstPaint	182	57	894	188	174	607
			backgroundConnect	23	11	158	15	25	33
			firstReactRender	28	17	101	11	32	36
			getState	9	4	16	3	11	15
			initialActions	3	0	7	2	4	6
			loadScripts	620	579	823	48	632	727
			setupStore	10	5	16	3	12	14
Firefox	Browserify	Home	uiStartup	1475	1263	1920	118	1533	1683
			load	1238	1072	1453	87	1312	1379
			domContentLoaded	1238	1071	1452	87	1311	1378
			domInteractive	101	35	302	52	104	256
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	36	22	86	11	40	62
			firstReactRender	31	27	68	6	32	42
			getState	9	6	76	8	9	17
			initialActions	4	2	56	5	4	9
			loadScripts	1215	1054	1431	86	1287	1354
			setupStore	15	6	153	25	11	52
	Webpack	Home	uiStartup	1595	1428	1974	108	1642	1896
			load	1366	1211	1705	87	1405	1513
			domContentLoaded	1365	1211	1704	87	1405	1513
			domInteractive	98	31	345	50	100	188
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	36	20	120	16	41	69
			firstReactRender	33	26	152	13	34	41
			getState	10	3	132	16	9	23
			initialActions	6	1	179	18	4	14
			loadScripts	1342	1194	1654	84	1377	1495
			setupStore	13	6	59	11	11	34

Bundle size diffs [🚀 Bundle size reduced!]

background: -71.86 KiB (-1.58%)
ui: 1.57 KiB (0.02%)
common: 57.49 KiB (0.69%)

metamaskbot · 2025-10-16T23:10:28Z

📊 Page Load Benchmark Results

Current Commit: 0c8ed0b | Date: 10/16/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.05s (±72ms) 🟡 | historical mean value: 1.05s ⬆️ (historical data)
domContentLoaded-> current mean value: 737ms (±69ms) 🟢 | historical mean value: 738ms ⬇️ (historical data)
firstContentfulPaint-> current mean value: 78ms (±15ms) 🟢 | historical mean value: 78ms ⬆️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.05s	72ms	1.01s	1.33s	1.27s	1.33s
domContentLoaded	737ms	69ms	697ms	1.00s	947ms	1.00s
firstPaint	78ms	15ms	60ms	208ms	92ms	208ms
firstContentfulPaint	78ms	15ms	60ms	208ms	92ms	208ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Results generated automatically by MetaMask CI

metamaskbot · 2025-10-16T23:10:35Z

Builds ready [0c8ed0b]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- content-script: 0
- offscreen: 0

UI Startup Metrics (1238 ± 75 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1238	1107	1498	75	1285	1379
			load	1065	924	1307	70	1111	1186
			domContentLoaded	1059	917	1303	70	1105	1179
			domInteractive	17	13	61	6	17	24
			firstPaint	688	144	1187	429	1086	1166
			backgroundConnect	251	239	284	8	256	265
			firstReactRender	25	19	47	5	26	37
			getState	14	6	49	7	17	27
			initialActions	4	0	21	3	5	11
			loadScripts	813	680	1048	68	862	934
			setupStore	9	6	23	3	10	14
	Webpack	Home	uiStartup	842	711	1121	83	860	1046
			load	643	579	946	87	638	886
			domContentLoaded	635	574	939	86	631	876
			domInteractive	15	11	51	8	14	37
			firstPaint	202	58	922	194	198	593
			backgroundConnect	22	11	47	8	26	37
			firstReactRender	26	17	63	8	31	33
			getState	9	4	28	3	11	14
			initialActions	3	0	11	2	4	6
			loadScripts	633	572	937	84	630	865
			setupStore	9	5	27	3	11	13
Firefox	Browserify	Home	uiStartup	1433	1265	1748	99	1468	1644
			load	1217	1066	1391	71	1264	1344
			domContentLoaded	1217	1066	1391	71	1264	1343
			domInteractive	102	34	297	50	102	245
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	32	21	108	12	36	43
			firstReactRender	29	25	44	3	29	38
			getState	8	5	86	8	8	14
			initialActions	4	2	17	3	3	8
			loadScripts	1196	1048	1369	69	1242	1313
			setupStore	12	6	105	13	10	33
	Webpack	Home	uiStartup	1617	1421	2115	126	1660	1851
			load	1385	1243	1744	100	1441	1625
			domContentLoaded	1385	1243	1743	100	1441	1624
			domInteractive	117	33	405	76	116	363
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	35	22	73	10	41	60
			firstReactRender	30	23	81	11	32	50
			getState	10	4	151	15	9	13
			initialActions	7	2	162	19	4	16
			loadScripts	1363	1227	1701	99	1420	1598
			setupStore	14	6	248	25	10	37

Bundle size diffs [🚀 Bundle size reduced!]

background: -71.71 KiB (-1.58%)
ui: 1.79 KiB (0.03%)
common: 58.31 KiB (0.7%)

feat: native segwit tag for bitcoin, fix tochain selection from bitco…

1a500eb

…in in selector

ghgoodreau changed the title ~~feat: native segwit tag for bitcoin, fix tochain selection from bitco…~~ feat: native segwit tag for bitcoin, fix tochain selection from bitcoin Oct 16, 2025

metamaskbot added the team-swaps-and-bridge Swaps and Bridge team label Oct 16, 2025

github-actions bot added the size-S label Oct 16, 2025

fix: update snapshots

3f75b5e

ghgoodreau added 2 commits October 16, 2025 15:21

fix getToChain fn

10cdc5a

fix: unit tests

20ddd26

feat: account type labels

0c8ed0b

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: native segwit tag for bitcoin, fix tochain selection from bitcoin #36927

feat: native segwit tag for bitcoin, fix tochain selection from bitcoin #36927

ghgoodreau commented Oct 16, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Oct 16, 2025

Uh oh!

metamaskbot commented Oct 16, 2025 •

edited

Loading

Uh oh!

metamaskbot commented Oct 16, 2025

Uh oh!

metamaskbot commented Oct 16, 2025

Uh oh!

metamaskbot commented Oct 16, 2025

Uh oh!

metamaskbot commented Oct 16, 2025

Uh oh!

metamaskbot commented Oct 16, 2025

Uh oh!

metamaskbot commented Oct 16, 2025

Uh oh!

metamaskbot commented Oct 16, 2025

Uh oh!

metamaskbot commented Oct 16, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

feat: native segwit tag for bitcoin, fix tochain selection from bitcoin #36927

Are you sure you want to change the base?

feat: native segwit tag for bitcoin, fix tochain selection from bitcoin #36927

Conversation

ghgoodreau commented Oct 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Changelog

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

github-actions bot commented Oct 16, 2025

Uh oh!

metamaskbot commented Oct 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✨ Files requiring CODEOWNER review ✨

Uh oh!

metamaskbot commented Oct 16, 2025

📊 Page Load Benchmark Results

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

metamaskbot commented Oct 16, 2025

Uh oh!

metamaskbot commented Oct 16, 2025

📊 Page Load Benchmark Results

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

metamaskbot commented Oct 16, 2025

Uh oh!

metamaskbot commented Oct 16, 2025

📊 Page Load Benchmark Results

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

metamaskbot commented Oct 16, 2025

Uh oh!

metamaskbot commented Oct 16, 2025

📊 Page Load Benchmark Results

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

metamaskbot commented Oct 16, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

ghgoodreau commented Oct 16, 2025 •

edited

Loading

metamaskbot commented Oct 16, 2025 •

edited

Loading