feat: native segwit tag for bitcoin, fix tochain selection from bitcoin#36927
feat: native segwit tag for bitcoin, fix tochain selection from bitcoin#36927
Conversation
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
✨ Files requiring CODEOWNER review ✨👨🔧 @MetaMask/core-extension-ux (4 files, +15 -27)
💎 @MetaMask/metamask-assets (1 files, +1 -1)
🔄 @MetaMask/swaps-engineers (9 files, +81 -83)
|
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Builds ready [1a500eb]
UI Startup Metrics (1257 ± 72 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Builds ready [3f75b5e]
UI Startup Metrics (1271 ± 73 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Builds ready [20ddd26]
UI Startup Metrics (1261 ± 69 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Builds ready [0c8ed0b]
UI Startup Metrics (1238 ± 75 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Builds ready [57ec918]
UI Startup Metrics (1308 ± 108 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
|
Fixes #37126 |
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Builds ready [50fb096]
UI Startup Metrics (1273 ± 76 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Builds ready [0012f4e]
UI Startup Metrics (1276 ± 78 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Builds ready [555af64]
UI Startup Metrics (1213 ± 92 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Builds ready [5215bb7]
UI Startup Metrics (1272 ± 86 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Description
This PR does these things:
Changelog
CHANGELOG entry: added account type tags for bitcoin
Related issues
Fixes: #37331
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Displays Bitcoin account type tags in token lists/cells and prevents BTC→BTC destination defaults by selecting a BIP44 default EVM chain; also tightens non‑EVM handling across asset picker and gas/bundle support.
TaginTokenCellTitleandTokenListItem; exportaccountTypeLabel.accountTypethroughAssetWithDisplayData,Asset, and into list items; treat non‑EVM chains usingisEvmChainId.formatChainIdToCaip) for step descriptions.fromTokenis BTC andtoChainIdis BTC, cleartoChainIdandtoToken.getToChain: If source is Bitcoin and no explicit destination, default to BIP44 default dest chain (EVM), not Bitcoin.getToChains; introduce BIP44 default parsing (parseCaipAssetType).useTokensWithFiltering: Remove "selected token first" behavior; includeaccountType; handle BTC/SOL caching and images; normalize native addresses.useMultichainBalances: AttachaccountTypefor non‑EVM (Bitcoin) balances.useGasIncluded7702/useIsSendBundleSupported: Disable support checks on non‑EVM chains.MultichainNetworks.BITCOINtoALLOWED_BRIDGE_CHAIN_IDS; ensure mapping for short network names.Written by Cursor Bugbot for commit 5215bb7. This will update automatically on new commits. Configure here.