fix: allow popperjs to access `window.devicePixelRatio` under lavamoat #36933

davidmurdoch · 2025-10-16T21:16:59Z

Description

Changelog

CHANGELOG entry:

Related issues

Fixes:

Manual testing steps

Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2025-10-16T21:17:17Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

metamaskbot · 2025-10-16T21:32:57Z

❌ test-e2e-chrome-api-specs failed. View the html report here.

metamaskbot · 2025-10-16T21:43:44Z

📊 Page Load Benchmark Results

Current Commit: a506c47 | Date: 10/16/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.04s (±81ms) 🟡 | historical mean value: 1.05s ⬇️ (historical data)
domContentLoaded-> current mean value: 735ms (±85ms) 🟢 | historical mean value: 738ms ⬇️ (historical data)
firstContentfulPaint-> current mean value: 88ms (±126ms) 🟢 | historical mean value: 78ms ⬆️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.04s	81ms	1.00s	1.50s	1.27s	1.50s
domContentLoaded	735ms	85ms	697ms	1.27s	950ms	1.27s
firstPaint	88ms	126ms	60ms	1.34s	84ms	1.34s
firstContentfulPaint	88ms	126ms	60ms	1.34s	84ms	1.34s
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Results generated automatically by MetaMask CI

metamaskbot · 2025-10-16T21:43:53Z

Builds ready [a506c47]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- content-script: 0
- offscreen: 0

UI Startup Metrics (1285 ± 68 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1285	1164	1494	68	1329	1404
			load	1101	972	1305	66	1145	1219
			domContentLoaded	1094	966	1300	66	1133	1213
			domInteractive	18	14	48	6	18	34
			firstPaint	698	84	1233	453	1127	1196
			backgroundConnect	257	233	291	9	261	277
			firstReactRender	28	19	121	15	29	43
			getState	16	5	83	9	19	27
			initialActions	5	0	28	4	6	9
			loadScripts	843	719	1052	65	877	965
			setupStore	11	7	36	4	11	22
	Webpack	Home	uiStartup	849	725	1152	75	869	1003
			load	638	587	951	70	643	790
			domContentLoaded	630	581	938	69	630	782
			domInteractive	16	11	58	10	14	40
			firstPaint	199	54	791	195	201	622
			backgroundConnect	22	11	38	7	26	35
			firstReactRender	28	17	63	9	32	45
			getState	9	3	23	4	12	15
			initialActions	3	0	11	2	4	8
			loadScripts	627	579	927	67	628	771
			setupStore	10	5	15	3	12	14
Firefox	Browserify	Home	uiStartup	1432	1241	1903	115	1476	1669
			load	1212	1064	1394	77	1264	1333
			domContentLoaded	1212	1062	1393	77	1264	1333
			domInteractive	103	34	274	51	106	241
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	33	21	106	11	38	49
			firstReactRender	29	25	53	5	31	42
			getState	9	5	114	11	8	16
			initialActions	7	0	199	22	3	19
			loadScripts	1191	1044	1370	76	1246	1307
			setupStore	10	5	54	7	10	29
	Webpack	Home	uiStartup	1536	1348	1958	115	1564	1774
			load	1309	1183	1585	83	1346	1462
			domContentLoaded	1309	1183	1585	83	1345	1461
			domInteractive	93	30	387	61	92	267
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	35	20	126	17	39	64
			firstReactRender	32	26	78	8	34	39
			getState	10	3	122	16	8	15
			initialActions	6	1	172	18	3	26
			loadScripts	1286	1167	1549	79	1323	1434
			setupStore	13	6	124	15	11	44

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 208 Bytes (0%)
ui: -6 Bytes (0%)
common: 843 Bytes (0.01%)

davidmurdoch · 2025-10-16T21:54:05Z

@metamaskbot update-policies

metamaskbot · 2025-10-16T22:10:34Z

Policies updated.
👀 Please review the diff for suspicious new powers.

🧠 Learn how: https://lavamoat.github.io/guides/policy-diff/#what-to-look-for-when-reviewing-a-policy-diff

metamaskbot · 2025-10-16T22:38:32Z

📊 Page Load Benchmark Results

Current Commit: ae19b8b | Date: 10/16/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.00s (±75ms) 🟡 | historical mean value: 1.05s ⬇️ (historical data)
domContentLoaded-> current mean value: 701ms (±83ms) 🟢 | historical mean value: 738ms ⬇️ (historical data)
firstContentfulPaint-> current mean value: 88ms (±122ms) 🟢 | historical mean value: 78ms ⬆️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.00s	75ms	950ms	1.34s	1.22s	1.34s
domContentLoaded	701ms	83ms	660ms	1.23s	904ms	1.23s
firstPaint	88ms	122ms	64ms	1.30s	88ms	1.30s
firstContentfulPaint	88ms	122ms	64ms	1.30s	88ms	1.30s
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Results generated automatically by MetaMask CI

metamaskbot · 2025-10-16T22:38:36Z

Builds ready [ae19b8b]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- content-script: 0
- offscreen: 0

UI Startup Metrics (1248 ± 73 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1248	1124	1581	73	1294	1355
			load	1076	968	1396	68	1121	1182
			domContentLoaded	1069	965	1390	67	1109	1175
			domInteractive	17	13	52	6	17	32
			firstPaint	720	87	1396	439	1094	1181
			backgroundConnect	255	241	286	8	257	271
			firstReactRender	27	20	54	6	29	41
			getState	15	5	40	7	19	28
			initialActions	5	0	29	4	5	10
			loadScripts	821	723	1141	67	859	924
			setupStore	9	5	16	2	10	14
	Webpack	Home	uiStartup	835	714	1051	67	852	1001
			load	629	579	894	64	633	832
			domContentLoaded	622	575	883	63	627	824
			domInteractive	16	11	51	8	14	37
			firstPaint	209	56	887	223	172	724
			backgroundConnect	22	10	45	7	26	33
			firstReactRender	27	17	60	8	32	36
			getState	10	4	22	4	12	16
			initialActions	3	0	9	2	4	7
			loadScripts	619	573	873	61	625	813
			setupStore	9	5	19	3	11	13
Firefox	Browserify	Home	uiStartup	1597	1271	2332	293	1782	2202
			load	1336	1069	1957	229	1460	1830
			domContentLoaded	1335	1069	1956	228	1460	1829
			domInteractive	110	33	423	68	114	272
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	42	22	257	28	47	76
			firstReactRender	33	25	55	7	38	49
			getState	10	4	34	5	13	21
			initialActions	7	1	182	19	6	19
			loadScripts	1307	1053	1925	220	1414	1799
			setupStore	14	6	102	12	14	35
	Webpack	Home	uiStartup	1582	1370	1959	129	1659	1881
			load	1349	1189	1711	97	1386	1538
			domContentLoaded	1349	1188	1711	97	1386	1538
			domInteractive	104	31	377	72	99	336
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	36	22	138	16	41	61
			firstReactRender	33	27	83	8	34	43
			getState	13	5	167	23	8	26
			initialActions	7	1	133	16	4	16
			loadScripts	1324	1169	1691	93	1364	1494
			setupStore	13	6	85	12	11	39

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 208 Bytes (0%)
ui: -6 Bytes (0%)
common: 843 Bytes (0.01%)

davidmurdoch · 2025-10-16T22:41:00Z

@metamaskbot update-policies

metamaskbot · 2025-10-16T22:55:12Z

No policy changes

metamaskbot · 2025-10-16T22:57:12Z

No policy changes

metamaskbot · 2025-10-16T22:59:05Z

No policy changes

metamaskbot · 2025-10-16T23:08:20Z

📊 Page Load Benchmark Results

Current Commit: 75da2e1 | Date: 10/16/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.04s (±72ms) 🟡 | historical mean value: 1.05s ⬇️ (historical data)
domContentLoaded-> current mean value: 735ms (±70ms) 🟢 | historical mean value: 738ms ⬇️ (historical data)
firstContentfulPaint-> current mean value: 78ms (±12ms) 🟢 | historical mean value: 78ms ⬆️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.04s	72ms	1.00s	1.34s	1.25s	1.34s
domContentLoaded	735ms	70ms	697ms	1.03s	936ms	1.03s
firstPaint	78ms	12ms	64ms	188ms	88ms	188ms
firstContentfulPaint	78ms	12ms	64ms	188ms	88ms	188ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Results generated automatically by MetaMask CI

metamaskbot · 2025-10-16T23:08:25Z

Builds ready [75da2e1]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- content-script: 0
- offscreen: 0

UI Startup Metrics (1233 ± 64 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1233	1115	1448	64	1274	1334
			load	1061	956	1246	59	1091	1163
			domContentLoaded	1055	951	1227	58	1085	1156
			domInteractive	17	14	39	4	17	26
			firstPaint	667	73	1242	438	1084	1157
			backgroundConnect	252	240	280	7	255	267
			firstReactRender	25	18	49	6	26	38
			getState	16	5	83	11	19	38
			initialActions	5	0	44	6	6	13
			loadScripts	808	708	989	57	836	903
			setupStore	10	6	27	4	11	18
	Webpack	Home	uiStartup	831	712	1114	71	853	1021
			load	629	574	952	72	632	869
			domContentLoaded	621	570	931	70	624	863
			domInteractive	15	11	48	8	14	34
			firstPaint	207	55	957	208	196	611
			backgroundConnect	21	11	49	7	25	36
			firstReactRender	27	17	59	8	32	36
			getState	9	3	19	3	11	14
			initialActions	3	0	8	2	4	6
			loadScripts	618	568	920	68	622	852
			setupStore	10	5	18	3	12	14
Firefox	Browserify	Home	uiStartup	1462	1257	2150	145	1523	1750
			load	1227	1073	1486	90	1294	1377
			domContentLoaded	1226	1073	1485	89	1294	1375
			domInteractive	105	32	371	58	101	252
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	34	23	75	10	38	56
			firstReactRender	30	25	81	7	31	37
			getState	13	6	226	24	9	43
			initialActions	6	1	136	14	4	16
			loadScripts	1205	1057	1457	89	1276	1347
			setupStore	14	6	150	20	11	51
	Webpack	Home	uiStartup	1615	1419	2199	132	1653	1889
			load	1375	1202	1699	88	1435	1538
			domContentLoaded	1375	1202	1699	88	1434	1538
			domInteractive	95	30	351	47	99	188
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	38	22	107	15	43	66
			firstReactRender	34	26	83	10	34	63
			getState	11	3	117	13	12	27
			initialActions	4	1	35	5	4	12
			loadScripts	1351	1186	1672	84	1408	1514
			setupStore	13	6	183	22	10	51

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 208 Bytes (0%)
ui: -6 Bytes (0%)
common: 843 Bytes (0.01%)

metamaskbot added the team-extension-platform Extension Platform team label Oct 16, 2025

github-actions bot added the size-XS label Oct 16, 2025

davidmurdoch changed the title ~~fix: permit popperjs access window.devicePixelRatio under lavamoat~~ fix: permit popperjs to access window.devicePixelRatio under lavamoat Oct 16, 2025

davidmurdoch changed the title ~~fix: permit popperjs to access window.devicePixelRatio under lavamoat~~ fix: allow popperjs to access window.devicePixelRatio under lavamoat Oct 16, 2025

davidmurdoch closed this Oct 16, 2025

davidmurdoch force-pushed the fix-popup-position branch from ae19b8b to eca2a3c Compare October 16, 2025 22:38

github-actions bot locked and limited conversation to collaborators Oct 16, 2025

fix

75da2e1

davidmurdoch reopened this Oct 16, 2025

fix: allow popperjs to access window.devicePixelRatio under lavamoat #36933

Are you sure you want to change the base?

fix: allow popperjs to access window.devicePixelRatio under lavamoat #36933

Uh oh!

Conversation

davidmurdoch commented Oct 16, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Changelog

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

github-actions bot commented Oct 16, 2025

Uh oh!

metamaskbot commented Oct 16, 2025

Uh oh!

metamaskbot commented Oct 16, 2025

📊 Page Load Benchmark Results

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

metamaskbot commented Oct 16, 2025

Uh oh!

davidmurdoch commented Oct 16, 2025

Uh oh!

metamaskbot commented Oct 16, 2025

Uh oh!

metamaskbot commented Oct 16, 2025

📊 Page Load Benchmark Results

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

metamaskbot commented Oct 16, 2025

Uh oh!

davidmurdoch commented Oct 16, 2025

Uh oh!

metamaskbot commented Oct 16, 2025

Uh oh!

metamaskbot commented Oct 16, 2025

Uh oh!

metamaskbot commented Oct 16, 2025

Uh oh!

metamaskbot commented Oct 16, 2025

📊 Page Load Benchmark Results

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

metamaskbot commented Oct 16, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

fix: allow popperjs to access `window.devicePixelRatio` under lavamoat #36933

fix: allow popperjs to access `window.devicePixelRatio` under lavamoat #36933

davidmurdoch commented Oct 16, 2025 •

edited by github-actions bot

Loading