Skip to content

Conversation

orestiseth
Copy link
Contributor

@orestiseth orestiseth commented Oct 17, 2025

Description

Open in GitHub Codespaces

Changelog

CHANGELOG entry: add bitcoin ff to main build

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Adds bitcoin to buildTypes.main.features in builds.yml, enabling the Bitcoin feature in the main build.

Written by Cursor Bugbot for commit c89363a. This will update automatically on new commits. Configure here.

@metamaskbot metamaskbot added the team-new-networks PRs from the New Networks team label Oct 17, 2025
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Collaborator

❌ test-e2e-chrome-api-specs failed. View the html report here.

@metamaskbot
Copy link
Collaborator

📊 Page Load Benchmark Results

Current Commit: 55a0428 | Date: 10/17/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.04s (±70ms) 🟡 | historical mean value: 1.05s ⬇️ (historical data)
  • domContentLoaded-> current mean value: 732ms (±68ms) 🟢 | historical mean value: 741ms ⬇️ (historical data)
  • firstContentfulPaint-> current mean value: 76ms (±11ms) 🟢 | historical mean value: 79ms ⬇️ (historical data)
📈 Detailed Results
Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.04s 70ms 1.01s 1.31s 1.27s 1.31s
domContentLoaded 732ms 68ms 700ms 999ms 930ms 999ms
firstPaint 76ms 11ms 56ms 164ms 84ms 164ms
firstContentfulPaint 76ms 11ms 56ms 164ms 84ms 164ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms

Results generated automatically by MetaMask CI

@metamaskbot
Copy link
Collaborator

Builds ready [55a0428]
UI Startup Metrics (1254 ± 65 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1254113515186512841377
load107092912645711021161
domContentLoaded106292112515710951156
domInteractive1814104101730
firstPaint64472126343610821173
backgroundConnect25523941518257269
firstReactRender281897103051
getState1988392229
initialActions708112620
loadScripts81568199156847917
setupStore1072331117
WebpackHomeuiStartup837715116778854985
load62357798766631794
domContentLoaded61557397864623778
domInteractive15115071436
firstPaint18354910180186632
backgroundConnect22106182537
firstReactRender271790103235
getState1151931416
initialActions3011248
loadScripts61357196762621767
setupStore1052631215
FirefoxBrowserifyHomeuiStartup14241237181612114751705
load1195105015078312511339
domContentLoaded1194105015078312501338
domInteractive1003133853101231
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect3820192194262
firstReactRender29255553039
getState73959714
initialActions5119119311
loadScripts1172102714848112241310
setupStore168184201347
WebpackHomeuiStartup15161377215112115601762
load13061184188810613511525
domContentLoaded13061184188710613511525
domInteractive943240246101193
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect361870124366
firstReactRender30237093148
getState8411611813
initialActions3113238
loadScripts12841167186710413231489
setupStore146174181237
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 1.49 KiB (0.03%)
  • ui: 2.4 KiB (0.04%)
  • common: 270 Bytes (0%)

@metamaskbot
Copy link
Collaborator

📊 Page Load Benchmark Results

Current Commit: c89363a | Date: 10/17/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.05s (±75ms) 🟡 | historical mean value: 1.05s ⬇️ (historical data)
  • domContentLoaded-> current mean value: 735ms (±73ms) 🟢 | historical mean value: 740ms ⬇️ (historical data)
  • firstContentfulPaint-> current mean value: 77ms (±13ms) 🟢 | historical mean value: 79ms ⬇️ (historical data)
📈 Detailed Results
Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.05s 75ms 1.01s 1.38s 1.30s 1.38s
domContentLoaded 735ms 73ms 694ms 1.04s 981ms 1.04s
firstPaint 77ms 13ms 56ms 188ms 88ms 188ms
firstContentfulPaint 77ms 13ms 56ms 188ms 88ms 188ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms

Results generated automatically by MetaMask CI

@metamaskbot
Copy link
Collaborator

Builds ready [c89363a]
UI Startup Metrics (1230 ± 75 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1230110315637512651345
load105395413166510821140
domContentLoaded104694913056410771135
domInteractive17134561731
firstPaint63875129743110661137
backgroundConnect2512372768254270
firstReactRender25194162838
getState208109142339
initialActions61406721
loadScripts802712105262830887
setupStore1062831115
WebpackHomeuiStartup8567291121778721072
load63958592971645847
domContentLoaded63158091669635824
domInteractive15114371435
firstPaint18458937184168638
backgroundConnect23115072639
firstReactRender27175183236
getState1151831416
initialActions40778410
loadScripts62857890266633813
setupStore1051931215
FirefoxBrowserifyHomeuiStartup14311247200413314971711
load1192103415129012551346
domContentLoaded1192103415119012551346
domInteractive1003432460102259
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect3624154163954
firstReactRender29254843135
getState9313514626
initialActions8115622330
loadScripts1170101914928812271328
setupStore177146211465
WebpackHomeuiStartup15661358207012816051860
load1325116816078913651534
domContentLoaded1324116816078913651534
domInteractive96304076397259
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect4220101174876
firstReactRender33267873440
getState114136191015
initialActions3113246
loadScripts1301114215668513421463
setupStore14792121337
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 1.49 KiB (0.03%)
  • ui: 2.4 KiB (0.04%)
  • common: 270 Bytes (0%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size-XS team-new-networks PRs from the New Networks team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants