Skip to content

fix: Missing env var declarations in builds.yml #36944

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
+16 −0
Draft

fix: Missing env var declarations in builds.yml #36944

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions builds.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -312,8 +312,16 @@ env:
- PHISHING_WARNING_PAGE_URL: null
# Modified in <root>/development/build/scripts.js:@getInfuraProjectId
- INFURA_PROJECT_ID
- INFURA_PROD_PROJECT_ID
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are these required? They were not required before.

- INFURA_BETA_PROJECT_ID
- INFURA_FLASK_PROJECT_ID
- INFURA_EXPERIMENTAL_PROJECT_ID
# Modified in <root>/development/build/scripts.js:@getSegmentWriteKey
- SEGMENT_WRITE_KEY: ''
- SEGMENT_PROD_WRITE_KEY: ''
- SEGMENT_BETA_WRITE_KEY: ''
- SEGMENT_FLASK_WRITE_KEY: ''
- SEGMENT_EXPERIMENTAL_WRITE_KEY: ''
# Modified in <root>/development/build/scripts.js:@getAnalyticsDataDeletionSourceId
- ANALYTICS_DATA_DELETION_SOURCE_ID: null
# Modified in <root>/development/build/scripts.js:@getAnalyticsDataDeletionEndpoint
Expand Down Expand Up @@ -424,7 +432,15 @@ env:
- APPLE_CLIENT_ID_REF
- SEEDLESS_ONBOARDING_ENABLED: 'true'
- GOOGLE_CLIENT_ID: ''
- GOOGLE_PROD_CLIENT_ID: ''
- GOOGLE_BETA_CLIENT_ID: ''
- GOOGLE_FLASK_CLIENT_ID: ''
- GOOGLE_EXPERIMENTAL_CLIENT_ID: ''
- APPLE_CLIENT_ID: ''
- APPLE_PROD_CLIENT_ID: ''
- APPLE_BETA_CLIENT_ID: ''
- APPLE_FLASK_CLIENT_ID: ''
- APPLE_EXPERIMENTAL_CLIENT_ID: ''
# OAuth (Social login) for UAT(QA) builds
- GOOGLE_CLIENT_ID_FLASK_UAT: ''
- APPLE_CLIENT_ID_FLASK_UAT: ''
Expand Down
Loading