chore: Update JSON-RPC related packages #36954
Draft
+77
−259
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
All alerts resolved. Learn more about Socket for GitHub. This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. Ignoring alerts on:
|
Gudahtt
force-pushed
the
update-json-rpc-packages
branch
from
3dc67a8 to
616116e
Compare
|
@metamaskbot update-policies |
|
@SocketSecurity ignore npm/@metamask/[email protected] Trusted author |
|
Policies updated. 🧠 Learn how: https://lavamoat.github.io/guides/policy-diff/#what-to-look-for-when-reviewing-a-policy-diff |
✨ Files requiring CODEOWNER review ✨🧩 @MetaMask/extension-devs (5 files, +15 -85)
📜 @MetaMask/policy-reviewers (5 files, +15 -85)
Tip Follow the policy review process outlined in the LavaMoat Policy Review Process doc before expecting an approval from Policy Reviewers. 🔗 @MetaMask/supply-chain (5 files, +15 -85)
|
Update JSON-RPC related packages. This includes two major updates: * `eth-json-rpc-provider` is updated from v4 to v5 * The breaking change is the removal of the `data` event, which we don't use. * Changelog: https://github.com/MetaMask/core/blob/main/packages/eth-json-rpc-provider/CHANGELOG.md#500 * `eth-json-rpc-middlware` is updated from v18 to v21 * Breaking changes include: * Remove `ethersProviderAsMiddleware` (which we don't use). * Add `exports` field, which breaks sub-path exports (which we don't use). * Update minimum Node.js version from v18.16 to v18.18 * Changelogs: * Old repo: https://github.com/MetaMask/eth-json-rpc-middleware/blob/main/CHANGELOG.md * Core: https://github.com/MetaMask/core/blob/main/packages/eth-json-rpc-middleware/CHANGELOG.md#2100 The `@metamask/network-controller` has also been updated to a later version that uses these updated JSON-RPC packages. This version includes a new `lookupNetwork` parameter for the `initializeProvider` method, which lets us finally eliminate the `network-controller` patch we have to prevent the `lookupNetwork` call during initialization.
Gudahtt
force-pushed
the
update-json-rpc-packages
branch
from
581a270 to
c127664
Compare
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Builds ready [581a270]
UI Startup Metrics (1231 ± 64 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
|
❌ test-e2e-chrome-api-specs failed. View the html report here. |
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Builds ready [c127664]
UI Startup Metrics (1243 ± 66 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
|
Blocked by #36061 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update JSON-RPC related packages. This includes two major updates:
eth-json-rpc-provideris updated from v4 to v5dataevent, which we don't use.eth-json-rpc-middlwareis updated from v18 to v21ethersProviderAsMiddleware(which we don't use).exportsfield, which breaks sub-path exports (which we don't use).The
@metamask/network-controllerhas also been updated to a later version that uses these updated JSON-RPC packages. This version includes a newlookupNetworkparameter for theinitializeProvidermethod, which lets us finally eliminate thenetwork-controllerpatch we have to prevent thelookupNetworkcall during initialization.Changelog
CHANGELOG entry: null
Related issues
N/A
Manual testing steps
N/A
Screenshots/Recordings
N/A
Pre-merge author checklist
Pre-merge reviewer checklist