-
Notifications
You must be signed in to change notification settings - Fork 5.4k
fix: unncessary dependencies #36974
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
fix: unncessary dependencies #36974
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
[], | ||
); | ||
|
||
const toggleNetworkFilterPopover = useCallback(() => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was unnecessary as a callback.
More importantly the dependencies imported here aren't used in this component
<Box className="transaction-list" {...boxProps}> | ||
{renderFilterButton()} | ||
{!hideNetworkFilter && ( | ||
<AssetListControlBar |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Simply inline here
✨ Files requiring CODEOWNER review ✨👨🔧 @MetaMask/core-extension-ux (1 files, +7 -54)
|
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Builds ready [28ba7c8]
UI Startup Metrics (1291 ± 71 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Description
Remove unnecessary callback and dependencies
Changelog
CHANGELOG entry: chore: remove unneccesary callback and dependencies
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Simplifies
UnifiedTransactionList
by inliningAssetListControlBar
rendering and removing unused imports, state, and memoized callbacks.ui/components/app/transaction-list/unified-transaction-list.component.js
)AssetListControlBar
rendering behind!hideNetworkFilter
; removerenderFilterButton
and related popover state/callbacks.TEST_CHAINS
,getEnvironmentType
,ENVIRONMENT_TYPE_*
,getCurrentNetwork
,getIsEvmMultichainNetworkSelected
.isTestNetwork
,isFullScreen
,isNetworkFilterPopoverOpen
and handlers.Written by Cursor Bugbot for commit 28ba7c8. This will update automatically on new commits. Configure here.