Skip to content

Conversation

n3ps
Copy link
Contributor

@n3ps n3ps commented Oct 18, 2025

Description

Remove unnecessary callback and dependencies

Open in GitHub Codespaces

Changelog

CHANGELOG entry: chore: remove unneccesary callback and dependencies

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Simplifies UnifiedTransactionList by inlining AssetListControlBar rendering and removing unused imports, state, and memoized callbacks.

  • UI: UnifiedTransactionList (ui/components/app/transaction-list/unified-transaction-list.component.js)
    • Inline AssetListControlBar rendering behind !hideNetworkFilter; remove renderFilterButton and related popover state/callbacks.
    • Remove unused imports and checks: TEST_CHAINS, getEnvironmentType, ENVIRONMENT_TYPE_*, getCurrentNetwork, getIsEvmMultichainNetworkSelected.
    • Drop associated memos/state: isTestNetwork, isFullScreen, isNetworkFilterPopoverOpen and handlers.
    • Keep transaction polling and activity rendering logic unchanged.

Written by Cursor Bugbot for commit 28ba7c8. This will update automatically on new commits. Configure here.

@n3ps n3ps added the team-core-extension-ux Core Extension UX team label Oct 18, 2025
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[],
);

const toggleNetworkFilterPopover = useCallback(() => {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was unnecessary as a callback.

More importantly the dependencies imported here aren't used in this component

<Box className="transaction-list" {...boxProps}>
{renderFilterButton()}
{!hideNetworkFilter && (
<AssetListControlBar
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simply inline here

@n3ps n3ps marked this pull request as ready for review October 18, 2025 02:44
@n3ps n3ps requested a review from a team as a code owner October 18, 2025 02:44
@metamaskbot
Copy link
Collaborator

✨ Files requiring CODEOWNER review ✨

👨‍🔧 @MetaMask/core-extension-ux (1 files, +7 -54)
  • 📁 ui/
    • 📁 components/
      • 📁 app/
        • 📁 transaction-list/
          • 📄 unified-transaction-list.component.js +7 -54

@metamaskbot
Copy link
Collaborator

📊 Page Load Benchmark Results

Current Commit: 28ba7c8 | Date: 10/18/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.04s (±70ms) 🟡 | historical mean value: 1.04s ⬇️ (historical data)
  • domContentLoaded-> current mean value: 732ms (±68ms) 🟢 | historical mean value: 733ms ⬇️ (historical data)
  • firstContentfulPaint-> current mean value: 77ms (±12ms) 🟢 | historical mean value: 77ms ⬆️ (historical data)
📈 Detailed Results
Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.04s 70ms 1.00s 1.30s 1.26s 1.30s
domContentLoaded 732ms 68ms 695ms 997ms 938ms 997ms
firstPaint 77ms 12ms 64ms 176ms 88ms 176ms
firstContentfulPaint 77ms 12ms 64ms 176ms 88ms 176ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms

Results generated automatically by MetaMask CI

@metamaskbot
Copy link
Collaborator

Builds ready [28ba7c8]
UI Startup Metrics (1291 ± 71 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1291116514887113441424
load110999613156711521229
domContentLoaded110299113126611411224
domInteractive19146281844
firstPaint61290123645210971207
backgroundConnect26324538314266277
firstReactRender27199192942
getState1657192031
initialActions51244614
loadScripts846745104565878965
setupStore1062531116
WebpackHomeuiStartup8397171160798521046
load63258295176639861
domContentLoaded62457794276631853
domInteractive15115881437
firstPaint21353947215204595
backgroundConnect21104162532
firstReactRender3017226253235
getState941831113
initialActions308246
loadScripts62157593273629843
setupStore1051831214
FirefoxBrowserifyHomeuiStartup13881178183311814361599
load1183102414097812421313
domContentLoaded1183102314087812421313
domInteractive1103230253112261
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect322288103651
firstReactRender25207062436
getState937610815
initialActions3125338
loadScripts1161100813617412091290
setupStore1256312949
WebpackHomeuiStartup15481383182810015941749
load1333118515508213771499
domContentLoaded1333118515498213771499
domInteractive1083140569107326
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect3520109143967
firstReactRender292183113063
getState947210834
initialActions41435313
loadScripts1310116915258013571464
setupStore136139171047
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 58 Bytes (0%)
  • ui: -695 Bytes (-0.01%)
  • common: 10 Bytes (0%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size-S team-core-extension-ux Core Extension UX team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants