feat: Gator Permissions Revocation#37209
Merged
jeffsmale90 merged 26 commits intomainfrom Nov 5, 2025
Merged
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Contributor
Author
|
I have read the CLA Document and I hereby sign the CLA |
hanzel98
changed the title
Contributor
Author
|
Right now the actions is failing because the gator-permissions-controller needs to be updated There are 2 dependencies |
MoMannn
requested changes
Oct 27, 2025
app/scripts/controller-init/gator-permissions/gator-permissions-controller-init.ts
Show resolved
Hide resolved
Base automatically changed from
feat/add-review-gator-permissions-page
to
main
October 28, 2025 17:49
jeffsmale90
force-pushed
the
feat/add-revocation-flow
branch
from
caae5e5 to
d86abc2
Compare
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
jeffsmale90
changed the title
- @metamask/gator-permissios-controller - @metamask/signature-controller - @metamask/permissions-kernel-controller - @metamask/shielf-controller
jeffsmale90
force-pushed
the
feat/add-revocation-flow
branch
from
d86abc2 to
cda6628
Compare
Collaborator
Builds ready [cda6628]
UI Startup Metrics (1234 ± 98 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Collaborator
Builds ready [edb9b9c]
UI Startup Metrics (1207 ± 93 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Member
|
@metamaskbot update-policies |
Collaborator
|
Policies updated. 🧠 Learn how: https://lavamoat.github.io/guides/policy-diff/#what-to-look-for-when-reviewing-a-policy-diff |
Collaborator
Builds ready [74114e7]
UI Startup Metrics (1202 ± 99 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
…rPermissions When revoking an already-disabled permission, the hook returns null and setTransactionId(null?.id) sets transactionId to undefined. The useEffect hook now checks that transactionId is defined before attempting navigation to avoid calling navigateToId(undefined).
…k/metamask-extension into feat/add-revocation-flow
MoMannn
approved these changes
Nov 5, 2025
MoMannn
moved this from Needs dev review
to Has approvals, needs CODEOWNER
in PR review queue
7 tasks
Collaborator
Builds ready [5baf41d]
UI Startup Metrics (1175 ± 97 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
davidmurdoch
approved these changes
Nov 5, 2025
Contributor
davidmurdoch
left a comment
davidmurdoch
left a comment
There was a problem hiding this comment.
Policy file changes look good.
As does the metamask-controller.js integration.
I didn't review beyond those domains.
Collaborator
Builds ready [233483c]
UI Startup Metrics (1242 ± 92 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
github-project-automation
bot
moved this from Has approvals, needs CODEOWNER
to Review finalised - Ready to be merged
in PR review queue
github-project-automation
bot
moved this from Review finalised - Ready to be merged
to Merged, Closed or Archived
in PR review queue
metamaskbot
added
the
release-13.9.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR adds a complete revocation flow for gator permissions, including delegation status checking and transaction handling.
Key Changes
1. Enhanced Gator Permissions Controller
isDelegationDisabledfunction to check if a delegation is already disabled on-chainfetchAndUpdateGatorPermissionsto accept optional parameters for filtering2. Background API Integration
callmethod: New API method inmetamask-controller.jsto handleeth_callrequestsTransactionController:transactionConfirmedevent to allowed events3. Delegation Utilities
encodeDisabledDelegationsCheckanddecodeDisabledDelegationsResultfor on-chain delegation status checking4. Revocation Flow Improvements
Changelog
CHANGELOG entry: Enabled revocation flow of advance permissions
Technical Details
Files Modified:
app/scripts/metamask-controller.js: Addedcallmethod for RPC requestsapp/scripts/controller-init/messengers/gator-permissions/gator-permissions-controller-messenger.ts: Added transaction confirmed eventui/store/controller-actions/gator-permissions-controller.ts: Enhanced with delegation checking and improved APIui/hooks/gator-permissions/useRevokeGatorPermissions.ts: Added delegation status checkingshared/lib/delegation/delegation.ts: New delegation utility functionsKey Features:
Testing
Note
Adds full Gator permissions revocation flow with on-chain disabled checks, background/controller APIs, UI hooks, and config/policy updates.
apimethods:addPendingRevocation,submitRevocation, and parameterizedfetchAndUpdateGatorPermissions.checkDelegationDisabledviametamask-controller.js(performseth_call), and wire to NetworkController.transactionConfirmed,transactionFailed,transactionDropped.useRevokeGatorPermissions: resolve network client per permission, pre-check on-chain disabled state, calladdPendingRevocation/submitRevocation, handle batch revocations (filter already-disabled), and navigate on pending confirmation.useGatorPermissions: callfetchAndUpdateGatorPermissions({ isRevoked: false }).addPendingRevocation,submitRevocation,checkDelegationDisabled; updatefetchAndUpdateGatorPermissionsto accept params.encodeDisabledDelegationsCheckanddecodeDisabledDelegationsResultfordisabledDelegations(bytes32)calls.GATOR_PERMISSIONS_REVOCATION_ENABLEDfor Flask build.setTimeout/clearTimeoutfor@metamask/gator-permissions-controller.@metamask/gator-permissions-controllerto^0.4.0(lockfile updated); update@metamask/shield-controller.pendingRevocationsto state shape; e2e navigation adjusted.Written by Cursor Bugbot for commit 233483c. This will update automatically on new commits. Configure here.