feat: Adding token value field typed sign data tree. #13223
+392
−32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
jpuri
commented
Jan 28, 2025
app/components/Views/confirmations/components/BlockaidBanner/BlockaidBanner.types.ts
Outdated
Show resolved
Hide resolved
jpuri
force-pushed
the
token_unit_field
branch
from
9f1721c to
c80de47
Compare
7 tasks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 29, 2025
## **Description** PR is adding text with tooltip component as displayed in image below. This is used in next PR: #13223 ## **Related issues** Ref: MetaMask/MetaMask-planning#4034 ## **Manual testing steps** 1. Run storybook 2. Check the component added ## **Screenshots/Recordings** https://github.com/user-attachments/assets/9e455e3c-724f-4453-adac-41fa5cf41487 ## **Pre-merge author checklist** - [X] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [X] I've completed the PR template to the best of my ability - [X] I’ve included tests if applicable - [X] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [X] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
georgewrmarshall
previously approved these changes
Jan 29, 2025
There was a problem hiding this comment.
Hey @jpuri, I'm not sure why the @MetaMask/design-system-engineers were tagged as codeowners for this PR, but I'm approving to unblock. Please still seek reviews from the relevant folks. 🙏
|
|
nickewansmith
pushed a commit
that referenced
this pull request
Jan 30, 2025
## **Description** PR is adding text with tooltip component as displayed in image below. This is used in next PR: #13223 ## **Related issues** Ref: MetaMask/MetaMask-planning#4034 ## **Manual testing steps** 1. Run storybook 2. Check the component added ## **Screenshots/Recordings** https://github.com/user-attachments/assets/9e455e3c-724f-4453-adac-41fa5cf41487 ## **Pre-merge author checklist** - [X] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [X] I've completed the PR template to the best of my ability - [X] I’ve included tests if applicable - [X] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [X] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Created token value component for typed sign data tree.
Related issues
Fixes: https://github.com/MetaMask/MetaMask-planning/issues/4034
Manual testing steps
Screenshots/Recordings
Screen.Recording.2025-01-28.at.5.52.26.PM.mov
Pre-merge author checklist
Pre-merge reviewer checklist