fix: metrics call during onboarding

[NicolasMassart]

Description

• refactor track trackOnboarding calls to pass an event built with MetricsEventBuilder
• pass the properties with MetricsEventBuilder.addProperties

Related issues

Fixes https://github.com/MetaMask/mobile-planning/issues/2122

Manual testing steps

Feature: track metrics during onboarding

  Scenario: user creates new wallet
    Given a freshly installed app
    And user opted in for metrics
    When user creates a new wallet
    And user enters a new password
    Then no 'TRACK event saved {"event": undefined, "properties": {}, "type": "track"}' log is visible
    And the "Wallet Setup Started", "Wallet Created" and "Wallet Setup Completed" log is visible

  Scenario: user imports wallet
    Given a freshly installed app
    And user opted in for metrics
    When user imports a wallet
    And user enters a new password
    Then no 'TRACK event saved {"event": undefined, "properties": {}, "type": "track"}' log is visible
    And the "Wallet Import Started", "Wallet Imported" and "Wallet Setup Completed" log is visible

  Scenario: user manually backs the wallet up
    Given a freshly installed app
    And user opted in for metrics
    And user created a new wallet
    When user saves SRP
    Then no 'TRACK event saved {"event": undefined, "properties": {}, "type": "track"}' log is visible
    And the "Wallet Security Started", "Manual Backup Initiated", "Phrase Revealed", "Phrase Confirmed" and "Wallet Security Completed" log is visible

  Scenario: user skips wallet backup
    Given a freshly installed app
    And user opted in for metrics
    And user created a new wallet
    When user skips SRP backup by touching "remind me later"
    Then no 'TRACK event saved {"event": undefined, "properties": {}, "type": "track"}' log is visible
    And the "Wallet Security Skip Initiated", "Wallet Security Skip Confirmed" and "Automatic Security Checks Prompt Viewed" log is visible

Screenshots/Recordings

Before

INFO  TRACK event saved {"event": undefined, "properties": {}, "type": "track"}

After

examples of fixed event tracking

INFO  TRACK event saved {"event": "Wallet Setup Started", "properties": {}, "type": "track"}
INFO  TRACK event saved {"event": "Wallet Created", "properties": {"biometrics_enabled": false}, "type": "track"}
INFO  TRACK event saved {"event": "Wallet Setup Completed", "properties": {"new_wallet": true, "wallet_setup_type": "new"}, "type": "track"}

INFO  TRACK event saved {"event": "Wallet Import Started", "properties": {}, "type": "track"}
INFO  TRACK event saved {"event": "Wallet Imported", "properties": {"biometrics_enabled": false}, "type": "track"}
INFO  TRACK event saved {"event": "Wallet Setup Completed", "properties": {"new_wallet": false, "wallet_setup_type": "import"}, "type": "track"}

INFO  TRACK event saved {"event": "Wallet Security Skip Initiated", "properties": {}, "type": "track"}
INFO  TRACK event saved {"event": "Wallet Security Skip Confirmed", "properties": {}, "type": "track"}
INFO  TRACK event saved {"event": "Automatic Security Checks Prompt Viewed", "properties": {"applicationVersion": "7.37.1", "currentBuildNumber": "1520", "deviceBrand": "Apple", "operatingSystemVersion": "18.2", "platform": "ios"}, "type": "track"}
INFO  TRACK event saved {"event": "Wallet Security Reminder Dismissed", "properties": {"source": "Backup Alert", "wallet_protection_required": false}, "type": "track"}

Pre-merge author checklist

• I’ve followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[github-actions]

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 1a7780a
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/40c42fd7-33b5-4e19-b4ec-12c09db40f03

Note

• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[Cal-L]

LGTM

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud