-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
refactor: Replace redesign confirmation BottomModal with BottomSheet #13268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
no need because BottomSheetDialog provides background color
- affects only old confirmations - fix marginBottom on TransactionReview
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
|
app/components/Views/confirmations/Approval/__snapshots__/index.test.tsx.snap
Show resolved
Hide resolved
app/components/Views/confirmations/components/TransactionReview/index.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good, I added some feedback that need to be addressed.
removing this option seems to allow background to fade in naturally if this doesn't work try animation: 'fade'
app/components/Views/confirmations/components/Confirm/Footer/Footer.styles.ts
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #13268 +/- ##
==========================================
+ Coverage 62.91% 63.46% +0.55%
==========================================
Files 2035 2095 +60
Lines 44539 45301 +762
Branches 6050 6236 +186
==========================================
+ Hits 28020 28750 +730
+ Misses 14685 14670 -15
- Partials 1834 1881 +47 ☔ View full report in Codecov by Sentry. |
|
Created 1/3 cherry-pick PRs to support BottomSheet in 7.42.0: #13914 |
…mModal with BottomSheet (#13914) <!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** Cherry-picks 1/3 BottomSheet fix: #13268 into 7.42.0 Todo cherry-picks: 2/3: #13783 3/3: #13913 ## **Related issues** Fixes: #13870 ## **Manual testing steps** Open any redesign signature in Android to test related bug fix ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. Co-authored-by: Brian Nguyen <[email protected]>
Description
Updates:
Fixes:
Related issues
Fixes: #13267
Follow-up Related: #13783 (Fix testID)
Follow-up Related: #13913 (Scroll and close by backdrop click or drag down)
Follow-up - Related Issue: #12656
Cherry-pick PRs:
1/3: #13914 (BottomModal → BottomSheet)
2/3: #13926 (bitrise failure testID)
3/3: #13927 (scroll and close on swipe down & backdrop click)
Manual testing steps
Test BottomSheets and BlockaidBanner alerts work as expected. Test redesign confirmation page works as expected
Screenshots/Recordings
Before using BottomModal and no scroll behavior
CleanShot.2025-01-30.at.01.11.16.mp4
After using BottomSheet with scroll behavior
CleanShot.2025-01-30.at.02.18.53.mp4
Before 70% min height
After remove 70% min height
Before Transaction Review BlockaidBanner negative padding
**After Transaction Review BlockaidBanner positive padding **
Before Confirm.test console errors
After Confirm.test no console.errors
Pre-merge author checklist
Pre-merge reviewer checklist