Skip to content

fix: added more app icon sizes #13541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

Conversation

vinnyhoward
Copy link
Contributor

@vinnyhoward vinnyhoward commented Feb 14, 2025

Description

Added more icons sizes as well as replaced the current 120x120 app icons. They are the same but couldn't hurt to re-add them to see if it fixes the release build error here:

2025-02-[REDACTED]4 2[REDACTED]:02:45.694 *** Error: Validation failed Missing required icon file. The bundle does not contain an app icon for iPhone / iPod Touch of exactly '[REDACTED]20x[REDACTED]20' pixels, in .png format for iOS versions >= [REDACTED]0.0. To support older versions of iOS, the icon may be required in the bundle outside of an asset catalog. Make sure the Info.plist file includes appropriate entries referencing the file. See https://developer.apple.com/documentation/bundleresources/information_property_list/user_interface (ID: 38d37e49-a0a5-4355-adae-f[REDACTED]57e8df7573) (409)
 {
    NSLocalizedDescription = "Validation failed";
    NSLocalizedFailureReason = "Missing required icon file. The bundle does not contain an app icon for iPhone / iPod Touch of exactly '[REDACTED]20x[REDACTED]20' pixels, in .png format for iOS versions >= [REDACTED]0.0. To support older versions of iOS, the icon may be required in the bundle outside of an asset catalog. Make sure the Info.plist file includes appropriate entries referencing the file. See https://developer.apple.com/documentation/bundleresources/information_property_list/user_interface (ID: 38d37e49-a0a5-4355-adae-f[REDACTED]57e8df7573)";
    NSUnderlyingError = "Error Domain=IrisAPI Code=-[REDACTED]924[REDACTED] \"Validation failed\" UserInfo={status=409, detail=Missing required icon file. The bundle does not contain an app icon for iPhone / iPod Touch of exactly '[REDACTED]20x[REDACTED]20' pixels, in .png format for iOS versions >= [REDACTED]0.0. To support older versions of iOS, the icon may be required in the bundle outside of an asset catalog. Make sure the Info.plist file includes appropriate entries referencing the file. See https://developer.apple.com/documentation/bundleresources/information_property_list/user_interface, id=38d37e49-a0a5-4355-adae-f[REDACTED]57e8df7573, code=STATE_ERROR.VALIDATION_ERROR, title=Validation failed, NSLocalizedFailureReason=Missing required icon file. The bundle does not contain an app icon for iPhone / iPod Touch of exactly '[REDACTED]20x[REDACTED]20' pixels, in .png format for iOS versions >= [REDACTED]0.0. To support older versions of iOS, the icon may be required in the bundle outside of an asset catalog. Make sure the Info.plist file includes appropriate entries referencing the file. See https://developer.apple.com/documentation/bundleresources/information_property_list/user_interface, NSLocalizedDescription=Validation failed}";
    "iris-code" = "STATE_ERROR.VALIDATION_ERROR";
}

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Sorry, something went wrong.

@vinnyhoward vinnyhoward requested a review from a team as a code owner February 14, 2025 21:47
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot requested a review from a team as a code owner February 14, 2025 22:14
Copy link

@vinnyhoward vinnyhoward deleted the fix-additional-app-icons branch February 15, 2025 00:05
@github-actions github-actions bot locked and limited conversation to collaborators Feb 15, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants