Skip to content

feat: add GeneralAlertBanner component #13627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 45 commits into from
Feb 28, 2025
Merged

Conversation

vinistevam
Copy link
Contributor

@vinistevam vinistevam commented Feb 20, 2025

Description

PR adding GeneralAlertBanner component which is part of the Alert System.
Until we add an alert there is no functional change in the app.

Related issues

Fixes: https://github.com/MetaMask/mobile-planning/issues/2140

Manual testing steps

  1. E2E

Screenshots/Recordings

content-message.mp4
info-warning.mp4

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@vinistevam vinistevam added the team-confirmations Push issues to confirmations team label Feb 20, 2025
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (feat/add-alert-confirm@c85efd0). Learn more about missing BASE report.

Additional details and impacted files
@@                    Coverage Diff                    @@
##             feat/add-alert-confirm   #13627   +/-   ##
=========================================================
  Coverage                          ?   62.07%           
=========================================================
  Files                             ?     1995           
  Lines                             ?    44140           
  Branches                          ?     5977           
=========================================================
  Hits                              ?    27401           
  Misses                            ?    14926           
  Partials                          ?     1813           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vinistevam vinistevam marked this pull request as ready for review February 20, 2025 13:50
@vinistevam vinistevam requested a review from a team as a code owner February 20, 2025 13:50
@vinistevam vinistevam force-pushed the feat/add-general-alert-banner branch from 4bc10cb to c3a2e9e Compare February 26, 2025 06:45
Base automatically changed from feat/add-alert-confirm to main February 26, 2025 13:29
@vinistevam vinistevam dismissed jpuri’s stale review February 26, 2025 13:29

The base branch was changed.

@vinistevam vinistevam added the Run Smoke E2E Requires smoke E2E testing label Feb 27, 2025
Copy link
Contributor

github-actions bot commented Feb 27, 2025

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: ca9ef5c
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/29863ddd-ff72-4ae1-b9d8-3e4a1ba101f2

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@vinistevam vinistevam added Run Smoke E2E Requires smoke E2E testing and removed Run Smoke E2E Requires smoke E2E testing labels Feb 28, 2025
Copy link
Contributor

github-actions bot commented Feb 28, 2025

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: d94d72a
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/e914407e-f7ae-4cf4-a31e-86c671e3d65c

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

Copy link

@vinistevam vinistevam added this pull request to the merge queue Feb 28, 2025
Merged via the queue into main with commit b9085bc Feb 28, 2025
42 of 43 checks passed
@vinistevam vinistevam deleted the feat/add-general-alert-banner branch February 28, 2025 14:21
@github-actions github-actions bot locked and limited conversation to collaborators Feb 28, 2025
@metamaskbot metamaskbot added the release-7.43.0 Issue or pull request that will be included in release 7.43.0 label Feb 28, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.43.0 Issue or pull request that will be included in release 7.43.0 Run Smoke E2E Requires smoke E2E testing team-confirmations Push issues to confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants