Skip to content

feat(ramp): enable non-evm support for Ramp, buy only #13718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Feb 28, 2025

Conversation

wachunei
Copy link
Member

Description

This PR allows multichain chainId to be used within Ramps. This is possible if the selected networks is non-evm and is supported by Ramp API

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@metamaskbot metamaskbot added the team-ramp issues related to Ramp features label Feb 25, 2025
@wachunei wachunei added the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Feb 26, 2025
@wachunei wachunei added the Run Smoke E2E Requires smoke E2E testing label Feb 26, 2025
Copy link
Contributor

github-actions bot commented Feb 26, 2025

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 2adf5dd
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/43c59818-7739-4874-80e8-5f1966824dd7

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@wachunei wachunei added Run Smoke E2E Requires smoke E2E testing and removed Run Smoke E2E Requires smoke E2E testing labels Feb 26, 2025
@wachunei wachunei changed the title feat(ramp): enable buy action in walletactions, no signing required feat(ramp): enable non-evm support for Ramp, buy only Feb 26, 2025
@wachunei wachunei added Run Smoke E2E Requires smoke E2E testing and removed Run Smoke E2E Requires smoke E2E testing labels Feb 26, 2025
Copy link
Contributor

github-actions bot commented Feb 26, 2025

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 9096c02
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/3d59af81-9288-421d-a60d-b485415331ce

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@wachunei wachunei added Run Smoke E2E Requires smoke E2E testing and removed Run Smoke E2E Requires smoke E2E testing labels Feb 27, 2025
Copy link
Contributor

github-actions bot commented Feb 27, 2025

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 4f194ba
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/ca39b812-c2f5-41aa-90e6-94bceb673fde

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@wachunei wachunei marked this pull request as ready for review February 27, 2025 14:05
@wachunei wachunei requested review from a team as code owners February 27, 2025 14:05
tommasini
tommasini previously approved these changes Feb 27, 2025
@github-project-automation github-project-automation bot moved this from Needs dev review to Review finalised - Ready to be merged in PR review queue Feb 27, 2025
@wachunei wachunei dismissed stale reviews from AxelGes and tommasini via efadcd1 February 27, 2025 18:42
@wachunei wachunei added Run Smoke E2E Requires smoke E2E testing and removed Run Smoke E2E Requires smoke E2E testing labels Feb 27, 2025
Copy link
Contributor

github-actions bot commented Feb 27, 2025

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: efadcd1
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/3b6f0217-25a2-469d-97ec-a766034c0703

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@wachunei wachunei removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Feb 27, 2025
@wachunei wachunei enabled auto-merge February 27, 2025 19:09
@wachunei wachunei removed the Run Smoke E2E Requires smoke E2E testing label Feb 27, 2025
@wachunei wachunei added the Run Smoke E2E Requires smoke E2E testing label Feb 27, 2025
Copy link
Contributor

github-actions bot commented Feb 27, 2025

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 7330383
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/551e9566-01f3-4cd4-8f4d-10c6af205ba3

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 84.61538% with 2 lines in your changes missing coverage. Please review.

Project coverage is 63.40%. Comparing base (256bc97) to head (7330383).
Report is 39 commits behind head on main.

Files with missing lines Patch % Lines
.../components/UI/Ramp/components/AccountSelector.tsx 81.81% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #13718      +/-   ##
==========================================
+ Coverage   62.91%   63.40%   +0.49%     
==========================================
  Files        2035     2093      +58     
  Lines       44539    45254     +715     
  Branches     6050     6230     +180     
==========================================
+ Hits        28020    28694     +674     
+ Misses      14685    14676       -9     
- Partials     1834     1884      +50     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@wachunei wachunei added Run Smoke E2E Requires smoke E2E testing and removed Run Smoke E2E Requires smoke E2E testing labels Feb 28, 2025
Copy link
Contributor

github-actions bot commented Feb 28, 2025

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 90a91e9
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/e4aa2e47-a3ad-490f-9085-623119163fa5

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@wachunei wachunei added Run Smoke E2E Requires smoke E2E testing and removed Run Smoke E2E Requires smoke E2E testing labels Feb 28, 2025
@wachunei wachunei added this pull request to the merge queue Feb 28, 2025
Merged via the queue into main with commit d1d22d7 Feb 28, 2025
45 of 47 checks passed
@wachunei wachunei deleted the feat/ramp-non-evm-chainid branch February 28, 2025 14:15
@github-project-automation github-project-automation bot moved this from Review finalised - Ready to be merged to Merged, Closed or Archived in PR review queue Feb 28, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Feb 28, 2025
@metamaskbot metamaskbot added the release-7.43.0 Issue or pull request that will be included in release 7.43.0 label Feb 28, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.43.0 Issue or pull request that will be included in release 7.43.0 Run Smoke E2E Requires smoke E2E testing team-ramp issues related to Ramp features
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants