Skip to content

chore: update network info component for non evm networks #13734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Feb 28, 2025

Conversation

tommasini
Copy link
Contributor

@tommasini tommasini commented Feb 26, 2025

Description

This PR adds new copy and support for the NetworkInfo modal supports non-evm networks.
This PR also adds a few proposed design changes
image
image

Also it creates a selectEvmTicker for get the ticker of evm current selected network, and a selectTicker for the current overall selected network.

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-mobile-platform Mobile Platform team label Feb 26, 2025
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 40.54054% with 22 lines in your changes missing coverage. Please review.

Project coverage is 63.19%. Comparing base (256bc97) to head (845e0f1).
Report is 26 commits behind head on main.

Files with missing lines Patch % Lines
app/components/UI/NetworkInfo/index.tsx 0.00% 14 Missing ⚠️
app/components/UI/Swaps/QuotesView.js 0.00% 5 Missing ⚠️
...p/components/Views/WalletActions/WalletActions.tsx 50.00% 0 Missing and 1 partial ⚠️
app/core/NotificationManager.js 0.00% 1 Missing ⚠️
app/selectors/networkController.ts 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #13734      +/-   ##
==========================================
+ Coverage   62.91%   63.19%   +0.28%     
==========================================
  Files        2035     2075      +40     
  Lines       44539    45093     +554     
  Branches     6050     6202     +152     
==========================================
+ Hits        28020    28497     +477     
- Misses      14685    14717      +32     
- Partials     1834     1879      +45     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tommasini tommasini added the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Feb 26, 2025
@github-project-automation github-project-automation bot moved this to Needs dev review in PR review queue Feb 26, 2025
@tommasini tommasini added the Run Smoke E2E Requires smoke E2E testing label Feb 26, 2025
@tommasini tommasini marked this pull request as ready for review February 26, 2025 15:06
@tommasini tommasini requested review from a team as code owners February 26, 2025 15:06
Copy link
Contributor

github-actions bot commented Feb 26, 2025

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 5e84e5c
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/b0027054-e1b8-420b-beff-9bfcb80b3dcd

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@tommasini tommasini changed the title Implement network info for non evm also create a general selected tic… chore: update network info component for non evm networks Feb 26, 2025
@tommasini tommasini added Run Smoke E2E Requires smoke E2E testing and removed Run Smoke E2E Requires smoke E2E testing labels Feb 26, 2025
Copy link
Contributor

github-actions bot commented Feb 26, 2025

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 5faa8d8
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/57fe985b-2d31-4c72-b345-594730f7a95b

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@tommasini tommasini added Run Smoke E2E Requires smoke E2E testing and removed Run Smoke E2E Requires smoke E2E testing labels Feb 26, 2025
Copy link
Contributor

github-actions bot commented Feb 26, 2025

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: d4955db
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/7da77b86-bdd5-4e28-ad69-ea9c2314a015

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

Copy link
Contributor

github-actions bot commented Feb 27, 2025

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: e372953
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/d04bbd3d-9fec-4512-8484-90db527bdefa

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@tommasini tommasini added Run Smoke E2E Requires smoke E2E testing and removed Run Smoke E2E Requires smoke E2E testing labels Feb 28, 2025
Copy link
Contributor

github-actions bot commented Feb 28, 2025

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: cca4d49
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/4795f3cd-da55-49fd-9c06-6afed126e981

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@tommasini tommasini added Run Smoke E2E Requires smoke E2E testing and removed Run Smoke E2E Requires smoke E2E testing labels Feb 28, 2025
Copy link
Contributor

github-actions bot commented Feb 28, 2025

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: f494e1f
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/0266784b-6bbc-42da-97b2-89095c52593e

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@tommasini tommasini added Run Smoke E2E Requires smoke E2E testing and removed Run Smoke E2E Requires smoke E2E testing labels Feb 28, 2025
Copy link
Contributor

github-actions bot commented Feb 28, 2025

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: ce2a8c1
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/0e0b1b86-0cf4-4c1c-95b8-c420f969b59f

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@tommasini tommasini added Run Smoke E2E Requires smoke E2E testing and removed Run Smoke E2E Requires smoke E2E testing labels Feb 28, 2025
Copy link
Contributor

github-actions bot commented Feb 28, 2025

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 876e804
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/560278e1-a1ad-4dc6-bf15-11c5eed7302b

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Copy link

@tommasini tommasini added Run Smoke E2E Requires smoke E2E testing and removed Run Smoke E2E Requires smoke E2E testing labels Feb 28, 2025
@tommasini tommasini added this pull request to the merge queue Feb 28, 2025
Merged via the queue into main with commit dcf67aa Feb 28, 2025
51 checks passed
@tommasini tommasini deleted the feat/network-info-non-evm branch February 28, 2025 18:28
@github-project-automation github-project-automation bot moved this from Review finalised - Ready to be merged to Merged, Closed or Archived in PR review queue Feb 28, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Feb 28, 2025
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Feb 28, 2025
@metamaskbot metamaskbot added the release-7.43.0 Issue or pull request that will be included in release 7.43.0 label Feb 28, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.43.0 Issue or pull request that will be included in release 7.43.0 Run Smoke E2E Requires smoke E2E testing team-mobile-platform Mobile Platform team
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

6 participants