fix: Improve redesigned staking deposit confirmation navigation

[OGPoyraz]

Description

This PR aims to improve staking deposit confirmation navigation.

• Fixes to not prevent GasImpactModal flow if redesign enabled.
• Fixes to navigate redesigned staking deposit confirmation in GasImpactModal
• Fixes to navigate Transactions view on confirm of redesigned staking deposit confirmation.
• Adds tooltip to GasFeeDetails
• Fixes to remove approval when going back from redesigned staking deposit confirmation in navigation bar.

Also adds detailed test given cases above.

Related issues

Fixes:

• https://github.com/MetaMask/MetaMask-planning/issues/4285
• https://github.com/MetaMask/mobile-planning/issues/2137

Manual testing steps

Redesigned staking deposit flow works as expected.

Screenshots/Recordings

Before

After

Smart transactions enabled: (Note that styling might be broken in STX modal - it's not related with this PR)

StakingDeposit.with.STX.mp4

Without smart transactions:

Staking.Deposit.without.STX.mp4

Pre-merge author checklist

• I’ve followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 1e086ac
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/75431533-c5bc-44c1-99d6-2b60357c6dbe

Note

• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[jpuri]

Changes look good, I left some small feedbacks.

[Matt561]

Reviewing earn-related changed. Overall this looks good! I just have a minor change request before approving.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[github-actions]

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: ed0c8e9
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/9e93d717-d4c5-4047-877d-79886ff71df4

Note

• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

• Check the documentation if you have any doubts on how to understand the failure on bitrise