Skip to content

fix: fixes ramp quote selection test #13756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 27, 2025
Merged

fix: fixes ramp quote selection test #13756

merged 2 commits into from
Feb 27, 2025

Conversation

georgeweiler
Copy link
Contributor

Description

The e2e test is searching for “Select a Quote” and now the UI says “Recommended quote”. This PR updates the test to reflect the new copy.

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@georgeweiler georgeweiler added the Run Smoke E2E Requires smoke E2E testing label Feb 27, 2025
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-ramp issues related to Ramp features label Feb 27, 2025
Copy link
Contributor

github-actions bot commented Feb 27, 2025

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 0315d95
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/a6fefc7a-f06f-4113-ba4f-e5e3e38bd0c8

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@georgeweiler georgeweiler marked this pull request as ready for review February 27, 2025 20:33
@georgeweiler georgeweiler requested a review from a team as a code owner February 27, 2025 20:33
Copy link

@georgeweiler georgeweiler moved this to Needs dev review in PR review queue Feb 27, 2025
@georgeweiler georgeweiler added this pull request to the merge queue Feb 27, 2025
@github-project-automation github-project-automation bot moved this from Needs dev review to Review finalised - Ready to be merged in PR review queue Feb 27, 2025
Merged via the queue into main with commit 3b06f0a Feb 27, 2025
38 of 39 checks passed
@georgeweiler georgeweiler deleted the fix/ramp-e2e-test-fix branch February 27, 2025 22:05
@github-project-automation github-project-automation bot moved this from Review finalised - Ready to be merged to Merged, Closed or Archived in PR review queue Feb 27, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Feb 27, 2025
@metamaskbot metamaskbot added the release-7.43.0 Issue or pull request that will be included in release 7.43.0 label Feb 27, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.43.0 Issue or pull request that will be included in release 7.43.0 Run Smoke E2E Requires smoke E2E testing team-ramp issues related to Ramp features
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants