Skip to content

fix: permit simulation overflow #13769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 28, 2025
Merged

Conversation

digiwand
Copy link
Contributor

Description

Related issues

Fixes: #13728

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@digiwand digiwand requested a review from a team as a code owner February 28, 2025 06:37
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-confirmations Push issues to confirmations team label Feb 28, 2025
Copy link

@digiwand digiwand added this pull request to the merge queue Feb 28, 2025
Merged via the queue into main with commit 38d58a6 Feb 28, 2025
42 of 45 checks passed
@digiwand digiwand deleted the fix-permit-simulation-overflow branch February 28, 2025 16:56
@github-actions github-actions bot locked and limited conversation to collaborators Feb 28, 2025
@metamaskbot metamaskbot added the release-7.43.0 Issue or pull request that will be included in release 7.43.0 label Feb 28, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.43.0 Issue or pull request that will be included in release 7.43.0 team-confirmations Push issues to confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: The Spending cap on the Signatures screen is misaligned for tokens with longer names
3 participants