Skip to content

chore: Upgrade to yarn v3 #14477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from

Conversation

tommasini
Copy link
Contributor

@tommasini tommasini commented Apr 7, 2025

Ignoring ppom build at yarn setup right now since it may be removed soon

Description

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

…gnoring ppom build at yarn setup right now since it may be removed soon
Copy link
Contributor

github-actions bot commented Apr 7, 2025

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-mobile-platform Mobile Platform team label Apr 7, 2025
Copy link

socket-security bot commented Apr 7, 2025

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@babel/[email protected] None 0 674 kB nicolo-ribaudo
npm/@isaacs/[email protected] filesystem 0 101 kB isaacs
npm/@npmcli/[email protected] environment, network 0 17.7 kB npm-cli-ops
npm/@npmcli/[email protected] filesystem 0 26.6 kB npm-cli-ops
npm/@types/[email protected] None 0 13.9 kB types
npm/[email protected] None 0 4.9 kB npm-cli-ops
npm/[email protected] filesystem 0 63.8 kB npm-cli-ops
npm/[email protected] None 0 22 kB isaacs
npm/[email protected] filesystem 0 45.2 kB thecodrr
npm/[email protected] environment, network 0 53.2 kB npm-cli-ops
npm/[email protected] environment, network 0 46.8 kB npm-cli-ops
npm/[email protected] None 0 111 kB isaacs
npm/[email protected] None 0 28.7 kB wesleytodd
npm/[email protected] None 0 28.1 kB npm-cli-ops
npm/[email protected] None 0 21.2 kB sindresorhus
npm/[email protected] None 0 85.2 kB jonschlinkert
npm/[email protected] None 0 12.3 kB npm-cli-ops
npm/[email protected] None 0 38.8 kB npm-cli-ops
npm/[email protected] environment, filesystem 0 1.24 MB isaacs
npm/[email protected] None 0 0 B
npm/[email protected] None 0 3.48 kB npm-cli-ops
npm/[email protected] None 0 2.65 kB npm-cli-ops
npm/[email protected] None 0 80.3 kB isaacs

🚮 Removed packages: npm/@babel/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected]

View full report↗︎

Copy link

socket-security bot commented Apr 7, 2025

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert Package NoteSourceCI
New author npm/[email protected] 🚫
New author npm/[email protected] 🚫
New author npm/[email protected] 🚫
New author npm/@npmcli/[email protected] 🚫
New author npm/[email protected] 🚫

View full report↗︎

Next steps

What is new author?

A new npm collaborator published a version of the package for the first time. New collaborators are usually benign additions to a project, but do indicate a change to the security surface area of a package.

Scrutinize new collaborator additions to packages because they now have the ability to publish code into your dependency tree. Packages should avoid frequent or unnecessary additions or changes to publishing rights.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/[email protected] or ignore all packages with @SocketSecurity ignore-all

@@ -342,7 +342,7 @@ const prepareDependenciesTask = {
const concurrentTasks = {
title: 'Concurrent tasks',
task: (_, task) =>
task.newListr([setupIosTask, buildPpomTask, generateTermsOfUseTask], {
task.newListr([setupIosTask, /* buildPpomTask, */ generateTermsOfUseTask], {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussing going on to remove PPOM completely

@tommasini tommasini marked this pull request as ready for review April 7, 2025 16:36
@tommasini tommasini requested review from a team as code owners April 7, 2025 16:36
@tommasini tommasini marked this pull request as draft April 7, 2025 16:37
@tommasini
Copy link
Contributor Author

Closing this one in order to open this PR: http://github.com/MetaMask/metamask-mobile/pull/14800

@tommasini tommasini closed this Apr 23, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Apr 23, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
team-mobile-platform Mobile Platform team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants