Skip to content

fix: make mandatory not interactable ( dismissed ) #16111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 9, 2025
Merged

Conversation

ieow
Copy link
Contributor

@ieow ieow commented Jun 5, 2025

Description

Mandatory modal are dismisaable after using the BottomSheet Modal.
Mandatory modal for terms of use are not suppose to be able to be dismissed

This PR fix the mandatory modal to be not dismissable

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

github-actions bot commented Jun 5, 2025

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@ieow ieow added the Run Smoke E2E Requires smoke E2E testing label Jun 5, 2025
Copy link
Contributor

github-actions bot commented Jun 5, 2025

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 6242ecf
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/c823edbf-39c5-4c8a-8ca1-fb04b1e5b24e

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@ieow ieow added Run Smoke E2E Requires smoke E2E testing and removed Run Smoke E2E Requires smoke E2E testing labels Jun 5, 2025
Copy link
Contributor

github-actions bot commented Jun 5, 2025

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 67b44bd
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/439c487f-dde9-4077-874c-9c606ae3e3df

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Copy link

sonarqubecloud bot commented Jun 5, 2025

@ieow ieow marked this pull request as ready for review June 5, 2025 09:58
@ieow ieow requested a review from a team as a code owner June 5, 2025 09:58
@chaitanyapotti chaitanyapotti added area-onboarding No QA Needed Apply this label when your PR does not need any QA effort. labels Jun 5, 2025
@ieow ieow self-assigned this Jun 6, 2025
@github-project-automation github-project-automation bot moved this to Needs dev review in PR review queue Jun 6, 2025
Copy link
Member

@chaitanyapotti chaitanyapotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@github-project-automation github-project-automation bot moved this from Needs dev review to Review finalised - Ready to be merged in PR review queue Jun 6, 2025
@tommasini tommasini added this pull request to the merge queue Jun 9, 2025
Merged via the queue into main with commit 0102176 Jun 9, 2025
65 of 71 checks passed
@tommasini tommasini deleted the fix/mandatory-modal branch June 9, 2025 13:13
@github-project-automation github-project-automation bot moved this from Review finalised - Ready to be merged to Merged, Closed or Archived in PR review queue Jun 9, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Jun 9, 2025
@metamaskbot metamaskbot added the release-7.50.0 Issue or pull request that will be included in release 7.50.0 label Jun 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-onboarding No QA Needed Apply this label when your PR does not need any QA effort. release-7.50.0 Issue or pull request that will be included in release 7.50.0 Run Smoke E2E Requires smoke E2E testing team-web3auth
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants