Skip to content

feat(deposit): adds resend otp feature #16112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 103 commits into
base: main
Choose a base branch
from
Open

Conversation

georgeweiler
Copy link
Contributor

Description

Adds the ability for a user to resend the provider authentication code if they did not receive one.

  • 30 cooldown timer
  • support link displayed if user attempts to resend more than 3 times (support link navigation coming in future PR)

Related issues

Fixes:

Manual testing steps

  1. navigate to otp page and click the resend button
  2. Confirm you receive another email

Screenshots/Recordings

Before

After

resend otp

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

georgeweiler and others added 28 commits June 2, 2025 12:57
….com:MetaMask/metamask-mobile into refactor/ramps-deposit-directory-restructure
….com:MetaMask/metamask-mobile into refactor/ramps-deposit-directory-restructure
….com:MetaMask/metamask-mobile into refactor/ramps-deposit-directory-restructure
Copy link
Contributor

github-actions bot commented Jun 5, 2025

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-ramp issues related to Ramp features label Jun 5, 2025
@georgeweiler georgeweiler changed the base branch from main to feat/deposit/process-kyc-forms June 8, 2025 18:04
@georgeweiler georgeweiler requested review from a team as code owners June 8, 2025 18:04
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 67.64706% with 11 lines in your changes missing coverage. Please review.

Please upload report for BASE (feat/deposit/process-kyc-forms@fa16a48). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...mponents/UI/Ramp/Deposit/Views/OtpCode/OtpCode.tsx 67.64% 8 Missing and 3 partials ⚠️
Additional details and impacted files
@@                        Coverage Diff                        @@
##             feat/deposit/process-kyc-forms   #16112   +/-   ##
=================================================================
  Coverage                                  ?   71.04%           
=================================================================
  Files                                     ?     2587           
  Lines                                     ?    55474           
  Branches                                  ?     8540           
=================================================================
  Hits                                      ?    39412           
  Misses                                    ?    13565           
  Partials                                  ?     2497           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

sonarqubecloud bot commented Jun 8, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
71.2% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

Base automatically changed from feat/deposit/process-kyc-forms to main June 9, 2025 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
No E2E Smoke Needed If the PR does not need E2E smoke test run No QA Needed Apply this label when your PR does not need any QA effort. team-ramp issues related to Ramp features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants