Skip to content

feat(deposit): pass email to OTP view #16113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 93 commits into from
Jun 10, 2025
Merged

feat(deposit): pass email to OTP view #16113

merged 93 commits into from
Jun 10, 2025

Conversation

georgeweiler
Copy link
Contributor

@georgeweiler georgeweiler commented Jun 5, 2025

Description

Small data refactor for the deposit flow. Email has been moved from the deposit context into local state and is passed now as a route param to the OTP view.

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

georgeweiler and others added 30 commits June 2, 2025 12:57
….com:MetaMask/metamask-mobile into refactor/ramps-deposit-directory-restructure
….com:MetaMask/metamask-mobile into refactor/ramps-deposit-directory-restructure
….com:MetaMask/metamask-mobile into refactor/ramps-deposit-directory-restructure
@georgeweiler georgeweiler changed the base branch from main to feat/deposit/process-kyc-forms June 8, 2025 18:11
Base automatically changed from feat/deposit/process-kyc-forms to main June 9, 2025 19:41
Copy link

@georgeweiler georgeweiler marked this pull request as ready for review June 10, 2025 18:11
@georgeweiler georgeweiler requested a review from a team as a code owner June 10, 2025 18:11
@georgeweiler georgeweiler added this pull request to the merge queue Jun 10, 2025
Merged via the queue into main with commit 283f6b5 Jun 10, 2025
41 checks passed
@georgeweiler georgeweiler deleted the email-as-param branch June 10, 2025 18:40
@github-actions github-actions bot locked and limited conversation to collaborators Jun 10, 2025
@metamaskbot metamaskbot added the release-7.50.0 Issue or pull request that will be included in release 7.50.0 label Jun 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
No E2E Smoke Needed If the PR does not need E2E smoke test run No QA Needed Apply this label when your PR does not need any QA effort. release-7.50.0 Issue or pull request that will be included in release 7.50.0 team-ramp issues related to Ramp features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants