Skip to content

chore: enforce lint in pre commit hook #16816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

weitingsun
Copy link
Contributor

@weitingsun weitingsun commented Jun 30, 2025

Description

To enforce prettier and Eslint in pre commit hook

Related issues

#16371

Manual testing steps

  1. Pull this PR
  2. In a tsx file, try to add a space or remove one in any lines
  3. Find an useEffect and remove one of the dependencies
  4. Commit the changes locally, you should see the pre commit checks which will enforce prettier and give error messages for ESLint

Screenshots/Recordings

Before

No pre commit checks

After

Screenshot 2025-06-30 at 5 21 27 PM

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link

socket-security bot commented Jun 30, 2025

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updatednpm/​husky@​1.3.1 ⏵ 9.1.7100 +1010059 -4182100

View full report

Copy link

socket-security bot commented Jun 30, 2025

All alerts resolved. Learn more about Socket for GitHub.

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring alerts on:

View full report

@weitingsun weitingsun force-pushed the enforce-lint-in-pre-commit-hook branch from c4b4e52 to b27e096 Compare June 30, 2025 23:52
test

upgrade to husky 8

test

test

revert ParseDeeplink.ts

upgrade to husky 9
@weitingsun weitingsun force-pushed the enforce-lint-in-pre-commit-hook branch from 5ff0a02 to 8639a87 Compare July 1, 2025 00:15
@weitingsun
Copy link
Contributor Author

@SocketSecurity ignore npm/[email protected]

@weitingsun weitingsun self-assigned this Jul 1, 2025
@weitingsun weitingsun added team-mobile-platform Mobile Platform team No QA Needed Apply this label when your PR does not need any QA effort. labels Jul 1, 2025
@weitingsun weitingsun changed the title Enforce lint in pre commit hook Chore: enforce lint in pre commit hook Jul 1, 2025
@weitingsun weitingsun added the Run Smoke E2E Requires smoke E2E testing label Jul 1, 2025
@weitingsun weitingsun changed the title Chore: enforce lint in pre commit hook chore: enforce lint in pre commit hook Jul 1, 2025
Copy link
Contributor

github-actions bot commented Jul 1, 2025

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 8639a87
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/b49bf435-2e59-4780-afc9-8d8573c861c2

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

Copy link

sonarqubecloud bot commented Jul 1, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
No QA Needed Apply this label when your PR does not need any QA effort. Run Smoke E2E Requires smoke E2E testing team-mobile-platform Mobile Platform team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant