chore(runway): cherry-pick fix: cp-7.58.0 metamask pay transaction failures #21349
+256
−47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![runway-github[bot]](https://avatars.githubusercontent.com/in/86225?s=80&v=4){kind=small}
…ilures (#21287) ## **Description** Explicitly wait for confirmation of all required transactions when bridging funds for MetaMask Pay. Fix display of bridge receive line in transaction details summary. ## **Changelog** CHANGELOG entry: null ## **Related issues** ## **Manual testing steps** ## **Screenshots/Recordings** ### **Before** ### **After** ## **Pre-merge author checklist** - [x] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > Waits for and validates required bridge-related transactions, fixes target chain resolution and loading titles in the transaction details summary, and updates messenger, i18n, and tests accordingly. > > - **MetaMask Pay / Bridge flow**: > - Waits for all required transactions to confirm via `TransactionController:stateChange`; rejects on dropped/failed with error context. > - Queries initial states using `TransactionController:getState` and `BridgeStatusController:getState` before subscribing. > - Logs collected required tx IDs and ensures bridge completion; error text adjusted to `Bridge failed`. > - **Messenger**: > - Adds `TransactionController:getState` action and `TransactionController:stateChange` event to `TransactionControllerInit`. > - Allows `BridgeStatusController:getState` action. > - **Transaction details summary (UI)**: > - Derives receive chain from `quote.destChainId` (not `status.destChain.chainId`). > - Splits loading titles: `bridge_send_loading` and `bridge_receive_loading`. > - **i18n**: > - Adds `transaction_details.summary_title.bridge_send_loading` and `...bridge_receive_loading` keys. > - **Tests**: > - Update PayHook tests to simulate transaction state changes and failures. > - Adjust transaction summary tests for new loading titles and receive chain handling. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit a7b9f7d. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY -->
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Explicitly wait for confirmation of all required transactions when
bridging funds for MetaMask Pay.
Fix display of bridge receive line in transaction details summary.
Changelog
CHANGELOG entry: null
Related issues
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Docs and MetaMask Mobile
Coding
Standards.
if applicable
guidelines).
Not required for external contributors.
Pre-merge reviewer checklist
app, test code being changed).
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
Note
Waits for required bridge-related transactions to confirm before proceeding and fixes bridge receive/send summary titles and chain resolution.
confirmedviaTransactionController:getStateand:stateChange; rejects ondropped/failedwith error context.BridgeStatusController:getStatefor immediate bridge status check; updates failure message to "Bridge failed".requiredTransactionIds.TransactionController:getStateaction andTransactionController:stateChangeevent to init messenger.quote.destChainId(notstatus.destChain.chainId).bridge_send_loadingandbridge_receive_loadingand applies in summary rendering.en.jsonkeys for send/receive loading titles.Written by Cursor Bugbot for commit c5dfa17. This will update automatically on new commits. Configure here.
cf4df14