Skip to content

Conversation

jvbriones
Copy link
Contributor

@jvbriones jvbriones commented Oct 17, 2025

Description

Changelog

CHANGELOG entry:

Related issues

Fixes:

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Timestamp JUnit report files, add a merge script to deduplicate retries, and update CI workflows to publish merged junit.xml with new artifact names; enable Detox runner detached mode.

  • E2E Reporting:
    • JUnit outputs: e2e/jest.e2e.config.js now writes timestamped files (junit-<timestamp>.xml).
    • Merge script: Add .github/scripts/e2e-merge-detox-junit-reports.mjs to deduplicate and merge multiple JUnit XMLs into e2e/reports/junit.xml.
    • Detox: Enable detached: true in .detoxrc.js testRunner.
  • CI Workflows:
    • Run E2E (.github/workflows/run-e2e-workflow.yml):
      • Run merge script post-tests; upload e2e/reports/ as ${{ inputs.test-suite-name }}-test-junit-results.
    • Smoke/Regression (Android/iOS):
      • Download artifacts matching *-test-junit-results and read all-test-results/**/junit.xml.
      • Upload merged reports as **/junit.xml.
      • Rename steps and switch JSON report generator to e2e-create-json-test-report.mjs where applicable.

Written by Cursor Bugbot for commit 5c2566e. This will update automatically on new commits. Configure here.

@jvbriones jvbriones added the no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed label Oct 17, 2025
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-qa QA team label Oct 17, 2025
cursor[bot]

This comment was marked as outdated.

@github-actions github-actions bot added size-M and removed size-XS labels Oct 17, 2025
cursor[bot]

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

@github-actions github-actions bot added size-L and removed size-M labels Oct 19, 2025
GITHUB_TOKEN=${{ secrets.GITHUB_TOKEN }} \
node .github/scripts/e2e-create-test-report.mjs
node .github/scripts/e2e-create-json-test-report.mjs
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Missing Script in Workflow Causes Error

The run-e2e-smoke-tests-ios.yml and run-e2e-smoke-tests-android.yml workflows now reference e2e-create-json-test-report.mjs. This script, which appears to be a renamed version of e2e-create-test-report.mjs, is not included in the diff, which will cause a "file not found" error when the workflow runs.

Additional Locations (1)

Fix in Cursor Fix in Web

list-suites: "failed"
list-tests: "failed"
list-suites: 'all'
list-tests: 'all'
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Android Smoke Test Reports All Tests

The Android smoke test workflow now reports all test suites and tests, rather than just failed ones. This creates an inconsistency with iOS smoke tests and all regression test workflows, which still focus on failures, potentially making it harder to quickly spot actual test failures.

Fix in Cursor Fix in Web

Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed size-L team-qa QA team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants