chore(runway): cherry-pick feat: cp-7.58.0 max button in perps deposit #21362
+159
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![runway-github[bot]](https://avatars.githubusercontent.com/in/86225?s=80&v=4){kind=small}
#21257) ## **Description** Add a `Max` button to the Perps deposit confirmation, which automatically subtracts the appropriate buffers from the token amount based on the MetaMask Pay feature flags and if the token is native. ## **Changelog** CHANGELOG entry: Add max button to Perps deposit ## **Related issues** Fixes: [#5947](MetaMask/MetaMask-planning#5947) ## **Manual testing steps** ## **Screenshots/Recordings** ### **Before** ### **After** ## **Pre-merge author checklist** - [x] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > Adds a Max button for Perps deposit that sets amount to 100% minus dynamic buffers (feature flags, required tokens, native token), updates rounding, adds tests, and bumps transaction-controller. > > - **Perps Deposit UI**: > - Replace `90%` quick action with **`Max` (100%)** in `deposit-keyboard.tsx`. > - **Amount Logic** (`useTransactionCustomAmount`): > - Introduce `useMaxPercentage` to compute effective max based on `selectMetaMaskPayFlags`, `useTransactionRequiredTokens`, and native token detection. > - For `100%`, subtract buffers (initial/subsequent; extra if pay token is native); skip buffers if pay token matches required token or required tokens have sufficient balance with `skipIfBalance`. > - Change percentage rounding to `ROUND_DOWN` and use computed max percentage. > - **Tests**: > - Expand `useTransactionCustomAmount.test.ts` to cover buffered `100%` cases, native token, matching required token, and `skipIfBalance`; update mocks accordingly. > - **Dependencies**: > - Bump `@metamask/transaction-controller` to `^60.9.0`. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit ca20bbd. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY -->
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a
Maxbutton to the Perps deposit confirmation, whichautomatically subtracts the appropriate buffers from the token amount
based on the MetaMask Pay feature flags and if the token is native.
Changelog
CHANGELOG entry: Add max button to Perps deposit
Related issues
Fixes:
#5947
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Docs and MetaMask Mobile
Coding
Standards.
if applicable
guidelines).
Not required for external contributors.
Pre-merge reviewer checklist
app, test code being changed).
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
Note
Replaces the 90% button with a Max (100%) option and updates custom amount logic to apply buffer-based reductions (and native-token buffer) with round-down, adding tests and bumping transaction-controller.
90%button withMax(100%) inapp/components/Views/confirmations/components/deposit-keyboard/deposit-keyboard.tsx.useTransactionCustomAmount):useMaxPercentageto adjust100%by buffers from feature flags and required tokens; adds extra buffer if pay token is native.100%scenarios (required tokens, native token, skipIfBalance) and updated pay token mocks.@metamask/transaction-controllerto^60.9.0.Written by Cursor Bugbot for commit fc919ae. This will update automatically on new commits. Configure here.
0fad96b