feat: card onboarding (#21206) #21363
Open
+6,752
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->
## **Description**
Add card onboarding screens
<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->
## **Changelog**
<!--
If this PR is not End-User-Facing and should not show up in the
CHANGELOG, you can choose to either:
1. Write `CHANGELOG entry: null`
2. Label with `no-changelog`
If this PR is End-User-Facing, please write a short User-Facing
description in the past tense like:
`CHANGELOG entry: Added a new tab for users to see their NFTs`
`CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker`
(This helps the Release Engineer do their job more quickly and
accurately)
-->
CHANGELOG entry: Add card onboarding screens
## **Related issues**
Fixes:
## **Manual testing steps**
```gherkin
Feature: my feature name
Scenario: user [verb for user action]
Given [describe expected initial app state]
When user [verb for user action]
Then [describe expected outcome]
```
## **Screenshots/Recordings**
<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->
### **Before**
<!-- [screenshots/recordings] -->
### **After**
<!-- [screenshots/recordings] -->
https://github.com/user-attachments/assets/178aefea-7e25-42c6-825b-be918023d60c
## **Pre-merge author checklist**
- [x] I’ve followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.
## **Pre-merge reviewer checklist**
- [x] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [x] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
<!-- CURSOR_SUMMARY -->
---
> [!NOTE]
> Implements the complete Card onboarding flow with new screens, shared
UI, navigation stack, route constants, i18n strings, and comprehensive
tests.
>
> - **Card Onboarding UI**:
> - Add `OnboardingStep` layout and screens: `SignUp`, `ConfirmEmail`,
`SetPhoneNumber`, `ConfirmPhoneNumber` (OTP), `VerifyIdentity`,
`ValidatingKYC`, `KYCFailed`, `PersonalDetails`, `PhysicalAddress`,
`MailingAddress`, `Complete`.
> - **Navigation**:
> - Introduce `OnboardingNavigator` and integrate into card routes.
> - Extend `Routes.CARD.ONBOARDING` with all step routes.
> - **Localization**:
> - Add extensive `en.json` strings under `card.card_onboarding` and
related keys.
> - **Types**:
> - Add `CountriesOutput` type for country/config data.
> - **Tests**:
> - Add thorough test suites for all onboarding screens and shared
component.
>
> <sup>Written by [Cursor
Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit
bc594da. This will update automatically
on new commits. Configure
[here](https://cursor.com/dashboard?tab=bugbot).</sup>
<!-- /CURSOR_SUMMARY -->
---------
Co-authored-by: Bruno Nascimento <[email protected]>
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| 'card.card_onboarding.personal_details.invalid_date_of_birth_underage', | ||
| ), | ||
| ); | ||
| } |
There was a problem hiding this comment.
Bug: Date Validation Error Persistence
The date of birth validation logic doesn't clear the dateError state when a user enters a valid age (18+) after previously entering an invalid one. This causes the "Continue" button to remain disabled even when the date is correct.
|
Brunonascdev
approved these changes
Oct 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add card onboarding screens
Changelog
CHANGELOG entry: Add card onboarding screens
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
https://github.com/user-attachments/assets/178aefea-7e25-42c6-825b-be918023d60c ## Pre-merge author checklist
Standards.
Pre-merge reviewer checklist
Note
Introduces a complete Card onboarding UI flow with new screens, a nested navigator, route constants, extensive tests, and localization strings.
SignUp,ConfirmEmail,SetPhoneNumber,ConfirmPhoneNumber,VerifyIdentity,ValidatingKYC,PersonalDetails,PhysicalAddress,MailingAddress,Complete,KYCFailed.OnboardingStepcomponent.OnboardingNavigatorstack; registers underRoutes.CARD.ONBOARDING.*and wires intoCardroutes.CountriesOutputtoapp/components/UI/Card/types.ts.card.card_onboarding.*strings inlocales/languages/en.json.Written by Cursor Bugbot for commit 9590c87. This will update automatically on new commits. Configure here.
Description
Changelog
CHANGELOG entry:
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist