Skip to content

Conversation

Brunonascdev
Copy link
Contributor

@Brunonascdev Brunonascdev commented Oct 17, 2025

Description

Add new MetaMask Card Baanx variable mappings to the build.sh script

Changelog

CHANGELOG entry:

Related issues

Fixes:

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Adds MM_CARD_BAANX_API_CLIENT_KEY env remaps across build environments and updates Baanx URL mapping so rc uses PRD.

  • Build/CI:
    • Map MM_CARD_BAANX_API_CLIENT_KEY_* to MM_CARD_BAANX_API_CLIENT_KEY across environments in scripts/build.sh:
      • DEVMM_CARD_BAANX_API_CLIENT_KEY (dev)
      • UATMM_CARD_BAANX_API_CLIENT_KEY (qa, e2e, test, flask test/e2e, experimental)
      • PRODMM_CARD_BAANX_API_CLIENT_KEY (production, beta, rc, flask prod)
  • Config:
    • Rename example var in .js.env.example to MM_CARD_BAANX_API_CLIENT_KEY_DEV.
  • Card util:
    • In mapBaanxApiUrl.ts, map rc environment to AppConstants.BAANX_API_URL.PRD (was DEV).
  • Tests:
    • Update expectations in mapBaanxApiUrl.test.ts for rc to use PRD and adjust comprehensive mapping table.

Written by Cursor Bugbot for commit 50d4b9d. This will update automatically on new commits. Configure here.

@Brunonascdev Brunonascdev self-assigned this Oct 17, 2025
@Brunonascdev Brunonascdev requested a review from a team as a code owner October 17, 2025 16:24
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-card Card Team label Oct 17, 2025
Copy link

@Brunonascdev Brunonascdev added the no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed label Oct 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed size-S team-card Card Team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants