Skip to content

Conversation

Brunonascdev
Copy link
Contributor

@Brunonascdev Brunonascdev commented Oct 17, 2025

Description

This PR introduces new logic for displaying the Card button on the Wallet Home screen.

Key Changes

  • Added geolocation fetching and verification to determine if the user is in a supported region.
  • Added new feature flags to control progressive rollout of the Card button.
  • Introduced a new experimental setting within the Settings → Experimental section to always display the Card button (for internal testing).

Display Logic

The Card button is shown under the following conditions (in order of priority):

  1. Experimental flag enabled → Always show the Card button.
  2. Experimental flag disabled, but the user is a cardholder (on-chain data) → Show the Card button.
  3. Experimental flag disabled, but the user is logged in with Baanx → Show the Card button.
  4. Experimental flag disabled, user is in a supported region, and feature flag (progressive rollout) is enabled → Show the Card button.

Changelog

CHANGELOG entry: New Enable Card Button section on Experimental Options

Related issues

Fixes:

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Adds geolocation- and flag-gated display logic for the Card button, moves Card auth/display state into Redux, introduces an experimental “always show” toggle, and updates SDK geolocation and related tests.

  • Card feature (Redux/state):
    • Add geoLocation, isAuthenticated, and alwaysShowCardButton to card slice; introduce selectors selectDisplayCardButton, selectAlwaysShowCardButton, selectCardGeoLocation, selectIsAuthenticatedCard.
    • Change loadCardholderAccounts payload to { cardholderAddresses, geoLocation } and update consumers.
  • SDK and hooks:
    • Update CardSDK.getGeoLocation to environment-based endpoints; return UNKNOWN on failure and improve logging.
    • Move auth state handling to Redux actions; update CardSDKProvider and useCardProviderAuthentication to dispatch setIsAuthenticatedCard.
    • getCardholder now returns both cardholder addresses and geolocation.
  • UI:
    • Wallet navbar uses selectDisplayCardButton (replaces direct cardholder check).
    • Experimental Settings: add toggle to always show Card button (guarded by experimental flag).
    • CardHome reads Redux isAuthenticated and minor test utilities cleanup.
  • Feature flags/selectors:
    • Add card supported countries and version-gated flag for displaying Card button; provide default card feature flag.
  • Localization/Tests:
    • Update English strings for Experimental Settings Card section.
    • Extensive unit test updates to reflect new selectors, geolocation handling, and Redux-driven auth/display logic.

Written by Cursor Bugbot for commit 9107a0c. This will update automatically on new commits. Configure here.

…rds (#21306)

<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

This PR introduces new logic for displaying the Card button on the
Wallet Home screen.

Key Changes
- Added geolocation fetching and verification to determine if the user
is in a supported region.
- Added new feature flags to control progressive rollout of the Card
button.
- Introduced a new experimental setting within the Settings →
Experimental section to always display the Card button (for internal
testing).

Display Logic

The Card button is shown under the following conditions (in order of
priority):
1. Experimental flag enabled → Always show the Card button.
2. Experimental flag disabled, but the user is a cardholder (on-chain
data) → Show the Card button.
3. Experimental flag disabled, but the user is logged in with Baanx →
Show the Card button.
4. Experimental flag disabled, user is in a supported region, and
feature flag (progressive rollout) is enabled → Show the Card button.

## **Changelog**

<!--
If this PR is not End-User-Facing and should not show up in the
CHANGELOG, you can choose to either:
1. Write `CHANGELOG entry: null`
2. Label with `no-changelog`

If this PR is End-User-Facing, please write a short User-Facing
description in the past tense like:
`CHANGELOG entry: Added a new tab for users to see their NFTs`
`CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker`

(This helps the Release Engineer do their job more quickly and
accurately)
-->

CHANGELOG entry: New Enable Card Button section on Experimental Options

## **Related issues**

Fixes:

## **Manual testing steps**

```gherkin
Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]
```

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [x] I’ve followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> Display of the Card button is now controlled by geolocation and
feature flags with a new experimental override, Redux-backed auth state,
and updated SDK/geolocation handling.
> 
> - **Card button display logic**:
> - Add Redux state and selectors in `core/redux/slices/card` for
`geoLocation`, `isAuthenticated`, `alwaysShowCardButton`, and
`selectDisplayCardButton` (combines cardholder, auth, country support,
and FFs).
> - Replace wallet navbar guard with `selectDisplayCardButton` in
`Views/Wallet`.
> - Add experimental toggle in `Views/Settings/ExperimentalSettings` to
persist `alwaysShowCardButton` (strings added in `locales`).
> - **Feature flags/selectors**:
> - New selectors in `selectors/featureFlagController/card`:
`selectCardSupportedCountries`, `selectDisplayCardButtonFeatureFlag`,
`selectCardExperimentalSwitch`; `selectCardFeatureFlag` now returns a
default config when absent.
> - **SDK/auth integration**:
> - `CardSDK.getGeoLocation` now uses env-based endpoints and returns
`UNKNOWN` on failure.
> - `getCardholder` returns `{ cardholderAddresses, geoLocation }` and
callers/store updated accordingly.
> - `Card SDK` context and `useCardProviderAuthentication` now dispatch
`setIsAuthenticatedCard` to Redux; `CardHome` reads auth via
`selectIsAuthenticatedCard`.
> - **Tests**:
> - Comprehensive updates across card SDK, selectors, hooks, reducers,
wallet, and views to cover new logic and states (geolocation, flags,
auth).
> 
> <sup>Written by [Cursor
Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit
a442571. This will update automatically
on new commits. Configure
[here](https://cursor.com/dashboard?tab=bugbot).</sup>
<!-- /CURSOR_SUMMARY -->
@Brunonascdev Brunonascdev self-assigned this Oct 17, 2025
@Brunonascdev Brunonascdev requested review from a team as code owners October 17, 2025 18:49
@Brunonascdev Brunonascdev added the team-card Card Team label Oct 17, 2025
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@Brunonascdev Brunonascdev changed the title feat(card): display card button with geolocation and feature flag guards feat(card): cp-7.58 display card button with geolocation and feature flag guards Oct 17, 2025
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant