-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
feat(card): cp-7.58 display card button with geolocation and feature flag guards #21375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Brunonascdev
wants to merge
1
commit into
release/7.58.0
Choose a base branch
from
cherry-pick-card-geolocation-7.58.0
base: release/7.58.0
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,814
−888
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rds (#21306) <!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> This PR introduces new logic for displaying the Card button on the Wallet Home screen. Key Changes - Added geolocation fetching and verification to determine if the user is in a supported region. - Added new feature flags to control progressive rollout of the Card button. - Introduced a new experimental setting within the Settings → Experimental section to always display the Card button (for internal testing). Display Logic The Card button is shown under the following conditions (in order of priority): 1. Experimental flag enabled → Always show the Card button. 2. Experimental flag disabled, but the user is a cardholder (on-chain data) → Show the Card button. 3. Experimental flag disabled, but the user is logged in with Baanx → Show the Card button. 4. Experimental flag disabled, user is in a supported region, and feature flag (progressive rollout) is enabled → Show the Card button. ## **Changelog** <!-- If this PR is not End-User-Facing and should not show up in the CHANGELOG, you can choose to either: 1. Write `CHANGELOG entry: null` 2. Label with `no-changelog` If this PR is End-User-Facing, please write a short User-Facing description in the past tense like: `CHANGELOG entry: Added a new tab for users to see their NFTs` `CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker` (This helps the Release Engineer do their job more quickly and accurately) --> CHANGELOG entry: New Enable Card Button section on Experimental Options ## **Related issues** Fixes: ## **Manual testing steps** ```gherkin Feature: my feature name Scenario: user [verb for user action] Given [describe expected initial app state] When user [verb for user action] Then [describe expected outcome] ``` ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [x] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > Display of the Card button is now controlled by geolocation and feature flags with a new experimental override, Redux-backed auth state, and updated SDK/geolocation handling. > > - **Card button display logic**: > - Add Redux state and selectors in `core/redux/slices/card` for `geoLocation`, `isAuthenticated`, `alwaysShowCardButton`, and `selectDisplayCardButton` (combines cardholder, auth, country support, and FFs). > - Replace wallet navbar guard with `selectDisplayCardButton` in `Views/Wallet`. > - Add experimental toggle in `Views/Settings/ExperimentalSettings` to persist `alwaysShowCardButton` (strings added in `locales`). > - **Feature flags/selectors**: > - New selectors in `selectors/featureFlagController/card`: `selectCardSupportedCountries`, `selectDisplayCardButtonFeatureFlag`, `selectCardExperimentalSwitch`; `selectCardFeatureFlag` now returns a default config when absent. > - **SDK/auth integration**: > - `CardSDK.getGeoLocation` now uses env-based endpoints and returns `UNKNOWN` on failure. > - `getCardholder` returns `{ cardholderAddresses, geoLocation }` and callers/store updated accordingly. > - `Card SDK` context and `useCardProviderAuthentication` now dispatch `setIsAuthenticatedCard` to Redux; `CardHome` reads auth via `selectIsAuthenticatedCard`. > - **Tests**: > - Comprehensive updates across card SDK, selectors, hooks, reducers, wallet, and views to cover new logic and states (geolocation, flags, auth). > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit a442571. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY -->
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces new logic for displaying the Card button on the Wallet Home screen.
Key Changes
Display Logic
The Card button is shown under the following conditions (in order of priority):
Changelog
CHANGELOG entry: New Enable Card Button section on Experimental Options
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Standards.
Pre-merge reviewer checklist
Note
Adds geolocation- and flag-gated display logic for the Card button, moves Card auth/display state into Redux, introduces an experimental “always show” toggle, and updates SDK geolocation and related tests.
geoLocation
,isAuthenticated
, andalwaysShowCardButton
tocard
slice; introduce selectorsselectDisplayCardButton
,selectAlwaysShowCardButton
,selectCardGeoLocation
,selectIsAuthenticatedCard
.loadCardholderAccounts
payload to{ cardholderAddresses, geoLocation }
and update consumers.CardSDK.getGeoLocation
to environment-based endpoints; returnUNKNOWN
on failure and improve logging.CardSDKProvider
anduseCardProviderAuthentication
to dispatchsetIsAuthenticatedCard
.getCardholder
now returns both cardholder addresses and geolocation.selectDisplayCardButton
(replaces direct cardholder check).isAuthenticated
and minor test utilities cleanup.Written by Cursor Bugbot for commit 9107a0c. This will update automatically on new commits. Configure here.