Skip to content

Conversation

sethkfman
Copy link
Contributor

@sethkfman sethkfman commented Oct 17, 2025

Description

Changelog

CHANGELOG entry:

Related issues

Fixes:

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Adds automatic screenshot capture to E2E tests with new utilities and navigation helpers, example suite, docs, tags, and a dedicated CI workflow/script.

  • E2E Framework:
    • e2e/framework/Utilities.ts: add takeScreenshot() and executeWithScreenshot() with timestamped naming and failure capture.
    • e2e/framework/NavigationHelpers.ts: new helpers withNavigationScreenshots(), captureNavigationFlow(), captureScreenshot(), createScreenshotNavigationWrapper().
    • e2e/framework/index.ts: export navigation helpers.
  • Tests:
    • e2e/specs/screenshot-examples.spec.ts: new example suite demonstrating 8 screenshot patterns.
  • Tags:
    • e2e/tags.js: add ScreenshotExamples: tag and ScreenshotExamples() helper.
  • CI/Tooling:
    • .github/workflows/run-screenshot-examples.yml: workflow to run screenshot examples (iOS/Android).
    • e2e/scripts/run-screenshot-examples.sh: local runner script.
  • Docs:
    • Add guides and summaries in e2e/docs/ (quickstart, full docs, implementation summary, examples).

Written by Cursor Bugbot for commit d44a291. This will update automatically on new commits. Configure here.

@sethkfman sethkfman requested a review from a team as a code owner October 17, 2025 19:11
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-mobile-platform Mobile Platform team label Oct 17, 2025
},
);
});
});
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Test File Duplication Causes Redundancy

The screenshot-examples.spec.ts file is duplicated in both e2e/specs/ and e2e/docs/. The e2e/docs/ directory is intended for documentation, not executable test files, which creates unnecessary code redundancy, potential for tests to run twice, and maintenance overhead.

Fix in Cursor Fix in Web

prefix: screenshotPrefix,
});
throw error;
}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Screenshot Error Masks Original Exception

In executeWithScreenshot, if taking a failure screenshot throws an error, it masks the original error from the wrapped operation. This can make debugging difficult as the true cause of the operation's failure is lost.

Fix in Cursor Fix in Web

Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants