Skip to content

Conversation

kevinbluer
Copy link
Member

@kevinbluer kevinbluer commented Oct 17, 2025

Description

  • Adds logic to market details to handle a closed market
  • Not full parity with the designs / flow yet, but leaning towards more incremental PRs to mitigate merge conflicts, etc

Changelog

CHANGELOG entry: null

Related issues

Fixes: PRED-189

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

image image

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Cursor Bugbot is generating a summary for commit 8e1bb29. Configure here.

@metamaskbot metamaskbot added the team-predict Predict team label Oct 17, 2025
outcome={outcome}
outcome={market?.outcomes[0]}
outcomeToken={winningOutcomeToken}
isClosed
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Market Outcome Prop Mismatch Causes Display Inconsistency

For closed markets, the PredictMarketOutcome component incorrectly uses market?.outcomes[0] for its outcome prop, even though the outcomeToken prop correctly identifies the winning token. This mismatch can cause inconsistent details to display, like the title from the winning token but the image or volume from a different outcome.

Fix in Cursor Fix in Web

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
68.4% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@matallui matallui requested review from caieu and matallui October 17, 2025 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants