Skip to content

Conversation

vinnyhoward
Copy link
Contributor

@vinnyhoward vinnyhoward commented Oct 18, 2025

Description

Changelog

CHANGELOG entry:

Related issues

Fixes: #21305

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Prevents button cutoff by restructuring Add RPC/Block Explorer modals with sticky headers and keyboard-aware scrolling, and moves inline styles to a new styles file.

  • UI/Settings – NetworkSettings:
    • Restructures Add RPC modal: sticky header, keyboard-aware scroll (extraScrollHeight), and scrollable content so the action button isn’t cut off.
    • Updates Add Block Explorer modal list to use scrollable content with selectable/deletable entries and an add button section.
  • Styling:
    • Extracts inline StyleSheet into index.styles.js and imports createStyles.
    • Adjusts sheet sizing (e.g., sheetRpcForm height) and adds layout helpers (container, scrollViewContent, scrollableBox).
  • Cleanup:
    • Removes unused imports and consolidates style-related logic out of index.js.

Written by Cursor Bugbot for commit e39e367. This will update automatically on new commits. Configure here.

@vinnyhoward vinnyhoward requested a review from a team as a code owner October 18, 2025 00:22
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-mobile-ux Mobile UX team label Oct 18, 2025
},
scrollViewContent: {
height: '100%',
},
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: ScrollView Content Styling Regression

The scrollViewContent style changed from paddingBottom: 16 to height: '100%'. This removes essential bottom padding, which can cause content, like the "Add RPC" button, to be cut off and prevents proper scrolling. This change appears to regress the button cutoff issue the PR aimed to fix.

Fix in Cursor Fix in Web

</SafeAreaView>
</KeyboardAwareScrollView>
</KeyboardAwareScrollView>
</View>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: RPC Form Modal Content Padding Issue

The RPC form modal's KeyboardAwareScrollView content no longer uses the SafeAreaView wrapper with styles.rpcMenu. This removes essential horizontal padding, causing form inputs and labels to extend to the screen edges and potentially misaligning content on notched devices.

Fix in Cursor Fix in Web

Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Add RPC URL button for custom networks is cut off

2 participants