-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
feat(card): Card authenticated info #21390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Brunonascdev
wants to merge
42
commits into
main
Choose a base branch
from
feat/card-authenticated-info
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+7,482
−2,942
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/card-api-integration-foundation
…taMask/metamask-mobile into chore/card-api-integration-foundation
…/card-api-integration-foundation
…/card-api-integration-foundation
…card-authenticated-info
…and remaining allowance values
…card-authenticated-info
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces several updates to the Card feature to support displaying authenticated user data after logging in with Baanx. It improves both backend integration and UI components to align the mobile experience with card.metamask.io.
Key changes include:
Changelog
CHANGELOG entry: Added support for displaying Solana assets in the Card feature.
CHANGELOG entry: Integrated GET wallets and priority endpoints to retrieve user wallet data.
CHANGELOG entry: Updated Card data presentation to align with card.metamask.io logic.
CHANGELOG entry: Added a new CardImage component featuring the Metal Card design.
CHANGELOG entry: Added a new Progress Bar component showing Allowance versus Balance.
CHANGELOG entry: Added a new Card Warning component to display allowance warnings.
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Implements authenticated card data flow (priority token via API), adds Solana support, updates balance/allowance handling, and introduces CardImage, WarningBox, and SpendingLimitProgressBar with CardHome/UI/navigation integrations.
getCardDetails
andgetCardExternalWalletDetails
toCardSDK
; switch to chain-awaregetSupportedTokensByChainId
.useGetPriorityCardToken
: use API when authenticated; on-chain allowances otherwise; warning emission (NeedDelegation).useAssetBalance
: handleavailableBalance
, raw values, Solana chain, and display logic; derive fiat accordingly.CardImage
(virtual/physical/metal) with address truncation; newCardWarningBox
; newSpendingLimitProgressBar
.CardHome
: loading states, warnings, add/change asset buttons, spending limit, logout, card type/address props.Navbar
: simplify card button display prop handling.buildTokenIconUrl
supports Solana; addtruncateAddress
.Written by Cursor Bugbot for commit 36ea7fe. This will update automatically on new commits. Configure here.