-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
fix(predict): order toasts #21395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
fix(predict): order toasts #21395
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
94fad4e
to
c141634
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #21395 +/- ##
==========================================
- Coverage 77.12% 77.11% -0.01%
==========================================
Files 3615 3615
Lines 89144 89142 -2
Branches 16861 16861
==========================================
- Hits 68748 68746 -2
+ Misses 15719 15717 -2
- Partials 4677 4679 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Description
Fixes for toasts during order placement.
Changelog
CHANGELOG entry: null
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Screen.Recording.2025-10-17.at.9.17.48.PM.mov
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Adds loading/success toasts and new i18n keys for Predict orders, delays cash-out success, updates price formatting, and simplifies navigation by letting dispatch errors surface; tests updated.
usePredictPlaceOrder
):predict.order
.strings('predict.order.*')
andformatPrice(..., { maximumDecimals: 2 })
; failure toast usesorder_failed
key.PredictBuyPreview
: callplaceOrder
then immediatelydispatch(StackActions.pop())
; remove try/catch; onPlaceBet no longerasync
.PredictSellPreview
: same dispatch-after-placeOrder change; remove Alert usage; switch price formatting to{ maximumDecimals: 2 }
.locales/languages/en.json
):predict.order
namespace:placing_prediction
,prediction_placed
,cashing_out
,cashing_out_subtitle
,cashed_out
,cashed_out_subtitle
,order_failed
.placeOrder
.maximumDecimals: 2
.Written by Cursor Bugbot for commit c141634. This will update automatically on new commits. Configure here.