Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
94fad4e to
c141634
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #21395 +/- ##
==========================================
- Coverage 77.12% 77.11% -0.01%
==========================================
Files 3615 3615
Lines 89144 89142 -2
Branches 16861 16861
==========================================
- Hits 68748 68746 -2
+ Misses 15719 15717 -2
- Partials 4677 4679 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
Fixes for toasts during order placement.
Changelog
CHANGELOG entry: null
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Screen.Recording.2025-10-17.at.9.17.48.PM.mov
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Adds loading/success toasts and new i18n keys for Predict orders, delays cash-out success, updates price formatting, and simplifies navigation by letting dispatch errors surface; tests updated.
usePredictPlaceOrder):predict.order.strings('predict.order.*')andformatPrice(..., { maximumDecimals: 2 }); failure toast usesorder_failedkey.PredictBuyPreview: callplaceOrderthen immediatelydispatch(StackActions.pop()); remove try/catch; onPlaceBet no longerasync.PredictSellPreview: same dispatch-after-placeOrder change; remove Alert usage; switch price formatting to{ maximumDecimals: 2 }.locales/languages/en.json):predict.ordernamespace:placing_prediction,prediction_placed,cashing_out,cashing_out_subtitle,cashed_out,cashed_out_subtitle,order_failed.placeOrder.maximumDecimals: 2.Written by Cursor Bugbot for commit c141634. This will update automatically on new commits. Configure here.