Skip to content

Conversation

@weitingsun
Copy link
Contributor

@weitingsun weitingsun commented Dec 2, 2025

Description

Changelog

CHANGELOG entry:

Related issues

Fixes:

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Refactors the OTA update workflow to run on push without fingerprint gating, centralizes EAS publish in build.sh with new expo-update scripts, and increases Node heap for iOS bundle generation.

  • Workflows:
    • github/workflows/push-eas-update.yml:
      • Switch trigger to push on chore/expo-update-env-config and set test TARGET_PR_NUMBER/BASE_BRANCH_REF.
      • Temporarily disable fingerprint comparison, approval, and mismatch guard.
      • Add env vars for runtime config (Segment, Sentry, Google, WC, etc.).
      • Replace inline EAS signing/publish with ./scripts/build.sh; run yarn build:expo-update:main:exp.
  • Scripts:
    • scripts/build.sh:
      • Add buildExpoUpdate() to sign and run eas update; support new PLATFORM=expo-update path.
    • package.json:
      • Add build:expo-update:main:* scripts (prod/beta/rc/exp/e2e/dev/test).
  • CI:
    • .github/workflows/ci.yml: Increase iOS bundle NODE_OPTIONS to --max_old_space_size=12288.

Written by Cursor Bugbot for commit 8ab9767. This will update automatically on new commits. Configure here.

@weitingsun weitingsun requested a review from a team as a code owner December 2, 2025 23:45
@github-actions
Copy link
Contributor

github-actions bot commented Dec 2, 2025

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

# BASE_BRANCH_REF: ${{ inputs.base_branch }}
# Hard-coded values for testing this workflow on the current branch:
TARGET_PR_NUMBER: 23570
BASE_BRANCH_REF: wsun/test-ota-update-7.62.88
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Test workflow config bypasses safety checks and approvals

The workflow contains hardcoded test values (TARGET_PR_NUMBER: 23570, BASE_BRANCH_REF: wsun/test-ota-update-7.62.88) and has critical safety mechanisms commented out. The fingerprint comparison job that detects native changes and the approval job requiring mobile platform team sign-off are both disabled. The trigger was also changed from workflow_dispatch (manual) to push on a specific branch. These changes are clearly marked as temporary test configuration in the comments but appear to be accidentally included in this PR.

Additional Locations (1)

Fix in Cursor Fix in Web

@weitingsun weitingsun closed this Dec 3, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Dec 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants