-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
OTA v1 7.62.89 #23648
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OTA v1 7.62.89 #23648
Conversation
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
🔍 Smart E2E Test Selection⏭️ Smart E2E selection skipped - base branch is not main (base: wsun/7.62.89) All E2E tests pre-selected. |
| ) : null} | ||
| <Text | ||
| style={styles.versionInfo} | ||
| >{`this is OTA update v1 text`}</Text> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Debug text accidentally committed to production UI
A hardcoded debug string "this is OTA update v1 text" was added to the App Information screen. This appears to be temporary test code used to verify the OTA update is working and will be visible to all users in the production app. The getFullVersion() call on line 224 already displays proper version information, making this additional text unnecessary for production.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test
Cal-L
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
| ) : null} | ||
| <Text | ||
| style={styles.versionInfo} | ||
| >{`this is OTA update v1 text`}</Text> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test
Description
This PR applies OTA updates to 7.62.89. It's for testing only
Changelog
CHANGELOG entry:
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Bumps OTA version to v1 and shows an OTA v1 message on the App Information screen.
OTA_VERSIONtov1inapp/constants/ota.ts.app/components/Views/Settings/AppInformation/index.js.Written by Cursor Bugbot for commit 92b9efa. This will update automatically on new commits. Configure here.