feat: MUSD-106: Support linea -> linea conversions #23704

Matt561 · 2025-12-05T01:19:00Z

Description

Removed hardcoded mainnet target when converting mUSD.

Changes

Attempt to convert to mUSD on the same network as the payment token. If mUSD isn't deployed on the payment token's network we fallback to mainnet.
Cleaned up repeated hasSeenEducationalScreen logic and centralized into initiateConversion. This way callers don't need to worry about handling educational screen redirects
Fixed bug where mUSD conversion CTA on Asset Overview page wasn't being rendered for BSC.

Changelog

CHANGELOG entry: removed hardcoded mainnet output chainId for mUSD conversion flow

Related issues

Fixes: MUSD-106: Support Linea to Linea conversions

Manual testing steps

Feature: mUSD Conversion Flow


  Scenario: User enters mUSD conversion from Asset List CTA with automatic token selection
    Given user has one or more supported stablecoins in their wallet

    When user taps "Get mUSD" button on the Asset List CTA
    Then the supported stablecoin with the highest balance is automatically selected as the payment token
    And mUSD conversion flow is initiated


  Scenario: mUSD conversion targets same network as payment token when supported
    Given user initiates mUSD conversion with a payment token
    And the payment token is on a network where mUSD is deployed

    When the conversion flow determines the target mUSD chain
    Then target mUSD is on the same network as the payment token


  Scenario: mUSD conversion falls back to Ethereum mainnet when payment token network is unsupported
    Given user initiates mUSD conversion with a payment token
    And the payment token is on a network where mUSD is NOT deployed

    When the conversion flow determines the target mUSD chain
    Then target mUSD falls back to Ethereum mainnet

Screenshots/Recordings

Before

mUSD conversion flow was hardcoded to convert to mainnet mUSD.

After

Linea -> Linea swap demo - link

Pre-merge author checklist

I’ve followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Initiates mUSD conversion on the payment token’s chain when supported (fallback to mainnet) and centralizes education-screen handling; updates CTA/Stake flows and related tests.

mUSD Conversion Flow
- Determine outputChainId via useMusdConversionTokens.getMusdOutputChainId, enabling same-network conversions with fallback to mainnet.
- Centralize education-screen redirect inside useMusdConversion with skipEducationCheck support; callers no longer handle navigation.
- Remove Relay nestedTransactions from addTransaction options.
Hooks
- useMusdConversionTokens: add getMusdOutputChainId, adjust isMusdSupportedOnChain to accept optional chainId and hex-normalize.
- useMusdConversion: add education redirect helper, allow skipEducationCheck, simplify transaction options.
UI
- MusdConversionAssetListCta: remove local education routing; use checksum address; compute outputChainId per token’s chain.
- MusdConversionAssetOverviewCta: compute outputChainId dynamically; call initiateConversion directly.
- StakeButton: simplify mUSD convert path; compute outputChainId via hook.
- EarnBalance: treat convertible stablecoins as lending balance when flag enabled.
Tests
- Update expectations to new params (skipEducationCheck, checksummed addresses, dynamic outputChainId).
- Remove education-navigation path tests from CTAs; adjust mocks accordingly.

^{Written by Cursor Bugbot for commit ea1edb9. This will update automatically on new commits. Configure here.}

github-actions · 2025-12-05T01:19:09Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

…sion entry point. cleanup next.

…ateConversion

… for BSC

…elper

cursor · 2025-12-05T15:36:23Z

app/components/UI/Earn/components/Musd/MusdConversionAssetListCta/index.tsx

-      });
-      return;
+    if (!paymentTokenChainId) {
+      throw new Error('[mUSD Conversion] payment token chainID missing');


Bug: Unhandled throw outside try-catch in handlePress

The throw new Error('[mUSD Conversion] payment token chainID missing') statement at line 66 is outside the try-catch block that starts at line 71. While this defensive check protects against missing paymentTokenChainId, if the condition ever triggers (e.g., due to race conditions or bugs in canConvert logic), the error will be unhandled and could crash the app. Compare with MusdConversionAssetOverviewCta/index.tsx where the similar check is properly wrapped inside the try-catch block starting at line 32.

cursor · 2025-12-05T15:36:24Z

app/components/UI/Earn/components/EarnBalance/index.tsx

  if (!asset.chainId) return null;

-  if (isLendingToken || isReceiptToken) {
+  if (isLendingToken || isReceiptToken || isConvertibleStablecoin) {


Bug: mUSD CTA blocked when stablecoin lending disabled

The new condition || isConvertibleStablecoin routes convertible stablecoins to EarnLendingBalance, but that component has an early return if (!isStablecoinLendingEnabled) return null; on line 179. This means if isMusdConversionFlowEnabled is true but selectStablecoinLendingEnabledFlag is false (these are independent feature flags), convertible stablecoins will be routed to EarnLendingBalance which immediately returns null, preventing the mUSD conversion CTA from ever rendering.

github-actions · 2025-12-05T15:54:42Z

🔍 Smart E2E Test Selection

Selected E2E tags: SmokeStake
Risk Level: medium
AI Confidence: 85%

click to see 🤖 AI reasoning details

The changes are focused exclusively on the Earn/Stake functionality, specifically around mUSD (Meta USD) conversion flows:

Scope: All 13 changed files are within app/components/UI/Earn/ or app/components/UI/Stake/ directories, which are clearly staking-related features.
Nature of Changes:
- Refactoring: The main change is centralizing the education screen redirect logic from individual components (StakeButton, MusdConversionAssetListCta, MusdConversionAssetOverviewCta) into the useMusdConversion hook's initiateConversion function
- New helper: Added getMusdOutputChainId to determine the correct output chain for mUSD conversion
- Cleanup: Removed nestedTransactions from transaction options (Relay-related)
- Bug fix/improvement: Now uses toChecksumAddress for payment token addresses
Risk Assessment - Medium:
- The changes affect the user flow for mUSD conversion (staking/earning feature)
- The refactoring centralizes logic which is a common source of bugs if not properly tested
- However, comprehensive unit tests are included and updated
- No changes to core engine, controllers, or critical infrastructure
Tag Selection:
- SmokeStake: This is the primary tag needed as all changes relate to staking/earning functionality, specifically the mUSD conversion user flow
- The changes don't touch core wallet functionality, accounts, notifications, ramps, swaps, or other distinct features

The changes are contained within the staking domain and include proper unit test updates, making SmokeStake the appropriate tag to validate these changes.

View GitHub Actions results

sonarqubecloud · 2025-12-05T16:14:21Z

Quality Gate failed

Failed conditions
62.7% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

Matt561 added No QA Needed Apply this label when your PR does not need any QA effort. team-earn labels Dec 5, 2025

github-actions bot added the size-L label Dec 5, 2025

Matt561 added 5 commits December 5, 2025 10:29

feat: enforced same chain conversion when possible in all mUSD conver…

19920b9

…sion entry point. cleanup next.

feat: centralized musd education screen redirect behaviour into initi…

463e40c

…ateConversion

fix: fixed mUSD conversion CTA on asset overview screen not appearing…

b0bfa48

… for BSC

feat: centralized outputChainId logic into new getMustOutputChainId h…

d75eef3

…elper

chore: fixing breaking tests

816f05d

Matt561 force-pushed the feat/musd-106-support-linea-to-linea-conversions branch from 0d0fa33 to 816f05d Compare December 5, 2025 15:29

Matt561 marked this pull request as ready for review December 5, 2025 15:30

Matt561 requested a review from a team as a code owner December 5, 2025 15:30

github-actions bot added size-M and removed size-L labels Dec 5, 2025

cursor bot reviewed Dec 5, 2025

View reviewed changes

fix: resolved conflicts in package.json

ea1edb9

nickewansmith self-requested a review December 5, 2025 20:03

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

feat: MUSD-106: Support linea -> linea conversions #23704

feat: MUSD-106: Support linea -> linea conversions #23704

Uh oh!

Matt561 commented Dec 5, 2025 •

edited by cursor bot

Loading

Uh oh!

github-actions bot commented Dec 5, 2025

Uh oh!

cursor bot Dec 5, 2025

Uh oh!

cursor bot Dec 5, 2025

Uh oh!

github-actions bot commented Dec 5, 2025

Uh oh!

sonarqubecloud bot commented Dec 5, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

feat: MUSD-106: Support linea -> linea conversions #23704

Are you sure you want to change the base?

feat: MUSD-106: Support linea -> linea conversions #23704

Uh oh!

Conversation

Matt561 commented Dec 5, 2025 • edited by cursor bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Changes

Changelog

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

github-actions bot commented Dec 5, 2025

Uh oh!

cursor bot Dec 5, 2025

Choose a reason for hiding this comment

Bug: Unhandled throw outside try-catch in handlePress

Uh oh!

cursor bot Dec 5, 2025

Choose a reason for hiding this comment

Bug: mUSD CTA blocked when stablecoin lending disabled

Uh oh!

github-actions bot commented Dec 5, 2025

🔍 Smart E2E Test Selection

Uh oh!

sonarqubecloud bot commented Dec 5, 2025

Quality Gate failed

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Matt561 commented Dec 5, 2025 •

edited by cursor bot

Loading