chore(runway): cherry-pick fix: temporarily disable Remove margin feature cp-7.61.0

[runway-github]

• fix: temporarily disable Remove margin feature cp-7.61.0 (fix: temporarily disable Remove margin feature cp-7.61.0 #23646)

Description

Temporarily disabling the remove margin feature until we can accurately
calculate the max removable amount. HL uses some discreet safety buffer
to prevent users from removing too much margin.

We were using an estimated hardcoded buffer, but it wasn't accurate, and
was causing confusion as to how much margin could actually be removed.

Changelog

CHANGELOG entry: disabled remove margin feature

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/TAT-2205

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I’ve followed MetaMask Contributor
  Docs and MetaMask Mobile
  Coding
  Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format
  if applicable
• I’ve applied the right labels on the PR (see labeling
  guidelines).
  Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the
  app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described
  in the ticket it closes and includes the necessary testing evidence such
  as recordings and or screenshots.

---

Note

Temporarily disables the "Remove Margin" action in the perps adjust margin sheet and comments out its related tests.

• UI/Perps:
  • PerpsAdjustMarginActionSheet: Disable reduce_margin option by commenting it out in actionOptions and add TODO with doc link.
• Tests:
  • Comment out tests for rendering and selecting "Remove Margin"; retain and verify "Add Margin" behavior.

^{Written by Cursor Bugbot for commit 75bf12b. This will update automatically on new commits. Configure here.}

d60af91

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[github-actions]

🔍 Smart E2E Test Selection

• Selected E2E tags: SmokePerps
• Risk Level: medium
• AI Confidence: 75%

click to see 🤖 AI reasoning details

The changes disable the "reduce margin" functionality in the Perps feature by commenting out the UI option and its associated tests. This is a temporary measure due to API limitations for calculating max removable margin amounts.

Change Analysis:

• Modified files: PerpsAdjustMarginActionSheet component and its test file
• Change type: Feature disabling (commenting out reduce/remove margin option)
• Scope: Isolated to margin adjustment action sheet within Perps
• Parent component: PerpsSelectAdjustMarginActionView still references both add and reduce actions

Risk Assessment:

• Medium risk: While this is a UI change that removes functionality rather than adding it, perpetuals trading is a financial feature where margin management is critical
• The change affects user workflows for managing position margins
• The "add margin" functionality remains active and should be tested
• No new functionality is introduced that could break existing flows

Test Tag Selection:

• Selected SmokePerps: This tag is specifically designed for "Perpetuals trading" per the tags.js definition
• Although no E2E tests are currently tagged with SmokePerps (existing perps tests use RegressionTrade), this is the appropriate smoke test category for changes in the perps feature area
• If SmokePerps has no tests, the CI system should handle this gracefully (no tests run)
• The change is self-contained within the Perps module and doesn't affect other wallet functionality like accounts, swaps, or network management

Confidence Level (75%):

• High confidence that SmokePerps is the right tag based on the component location and feature area
• Moderate confidence reduced slightly because: (1) couldn't confirm if SmokePerps tag has actual test coverage, and (2) the parent view still has code paths for reduce_margin that may not be fully tested after this change

View GitHub Actions results

[sonarqubecloud]

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[metamaskbot]

No release label on PR. Adding release label release-7.61.0 on PR, as PR was cherry-picked in branch 7.61.0.