Skip to content

chore: build 7.69.12#26667

Closed
weitingsun wants to merge 3 commits intomainfrom
wsun/build-7.69.12
Closed

chore: build 7.69.12#26667
weitingsun wants to merge 3 commits intomainfrom
wsun/build-7.69.12

Conversation

@weitingsun
Copy link
Contributor

@weitingsun weitingsun commented Feb 26, 2026

Description

Changelog

CHANGELOG entry:

Related issues

Fixes:

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Medium Risk
Medium risk because it changes CI dependency caching/build setup across OSes (including new Cirrus runners and tarball artifacts) and alters OTA update behavior to force a reload during onboarding, which can affect startup flow.

Overview
CI setup changes: setup-node-modules.yml is expanded to support ios/android/generic modes with platform-specific runners, optional submodule checkout, optional build-config application, and optional tarball artifacts to preserve symlinks (with updated artifact naming/permissions and retries for platform setup).

Runtime behavior change: useOTAUpdates now checks selectCompletedOnboarding and, when a new OTA update is fetched during onboarding, calls reloadAsync() instead of showing the OTA modal; tests were updated accordingly.

Version bump: Updates version strings to 7.69.12 across package.json, Android Gradle, iOS MARKETING_VERSION, and Bitrise env vars.

Written by Cursor Bugbot for commit a76f011. This will update automatically on new commits. Configure here.

@weitingsun weitingsun requested a review from a team as a code owner February 26, 2026 22:44
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-mobile-platform Mobile Platform team label Feb 26, 2026
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

error as Error,
'OTA Updates: Error reloading app on onboarding',
);
});
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing platform check for reloadAsync on Android

Medium Severity

The new onboarding path calls reloadAsync() unconditionally on both iOS and Android, but the existing OTAUpdatesModal deliberately only calls reloadAsync() on iOS (if (Platform.OS === 'ios')). On Android, the established pattern is to let the update apply on next cold start — the modal shows "Close and reopen MetaMask to apply the update" with a "Got it" button. The new hook bypasses this platform-specific behavior, which could cause unexpected forced reloads on Android during onboarding.

Fix in Cursor Fix in Web

@github-actions github-actions bot added size-M and removed size-S labels Feb 27, 2026
@github-actions
Copy link
Contributor

🔍 Smart E2E Test Selection

  • Selected E2E tags: None (no tests recommended)
  • Selected Performance tags: None (no tests recommended)
  • Risk Level: low
  • AI Confidence: 85%
click to see 🤖 AI reasoning details

E2E Test Selection:
This PR contains three types of changes:

  1. Version Bumps (7.69.0 → 7.69.12): Multiple files updated for version number changes only - package.json, android/app/build.gradle, bitrise.yml, ios/MetaMask.xcodeproj/project.pbxproj. These are purely metadata changes with no functional impact.

  2. CI Workflow Enhancement (.github/workflows/setup-node-modules.yml): Adds platform-specific setup options (iOS/Android), tarball support for preserving symlinks, and build configuration options. This is infrastructure/CI change that improves the build pipeline but doesn't affect app functionality.

  3. OTA Updates Hook Enhancement (useOTAUpdates.ts): Modifies behavior when an OTA update is available during onboarding - instead of showing a modal, it automatically reloads the app. This is a UX improvement for a specific edge case (OTA update during fresh install/onboarding). The change is:

    • Well-tested (comprehensive unit tests added)
    • Isolated to OTA update flow only
    • Only affects users who happen to have an OTA update available during onboarding
    • Doesn't affect core wallet functionality

None of these changes affect:

  • Transaction flows or confirmations
  • Account management or security
  • Network management
  • Trading/swap/bridge features
  • dApp connections or Snaps
  • Any user-facing wallet features covered by E2E tests

The OTA update behavior during onboarding is an edge case that wouldn't be testable in standard E2E tests anyway (requires actual OTA update availability from Expo). No E2E tags are needed.

Performance Test Selection:
The changes in this PR do not impact app performance:

  1. Version bumps are metadata-only changes with no runtime impact
  2. CI workflow changes affect build infrastructure, not app runtime
  3. The OTA updates hook change only affects behavior when an OTA update is available during onboarding - this is an edge case that doesn't impact normal app performance, startup time, or rendering

No performance-sensitive code paths are modified (no UI rendering changes, no data loading changes, no state management changes, no account/network list components affected).

View GitHub Actions results

@weitingsun weitingsun closed this Feb 27, 2026
@github-actions github-actions bot locked and limited conversation to collaborators Feb 27, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

size-M team-mobile-platform Mobile Platform team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants