Skip to content

chore: update node-version-file in push-eas-update.yml#26844

Merged
weitingsun merged 1 commit intomainfrom
wsun/update-node-version-file
Mar 3, 2026
Merged

chore: update node-version-file in push-eas-update.yml#26844
weitingsun merged 1 commit intomainfrom
wsun/update-node-version-file

Conversation

@weitingsun
Copy link
Contributor

@weitingsun weitingsun commented Mar 3, 2026

Description

We changed node-version-file from 20 to '.nvmrc' in setup-node-modules.yml (here) so we need to do the same in push-eas-update.yml.

testing workflow: https://github.com/MetaMask/metamask-mobile/actions/runs/22603948995

Changelog

CHANGELOG entry:null

Related issues

Fixes:

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Low Risk
Low risk: CI-only change that just aligns Node setup with .nvmrc, though it could affect workflow runs if the file is missing or incompatible.

Overview
Updates the push-eas-update.yml GitHub Actions workflow to source the Node.js version from node-version-file: '.nvmrc' instead of hardcoding Node 20.

This is applied to both the fingerprint comparison job and the EAS update publish job, keeping CI Node version consistent with the repo’s configured version.

Written by Cursor Bugbot for commit 348449d. This will update automatically on new commits. Configure here.

@weitingsun weitingsun requested a review from a team as a code owner March 3, 2026 01:10
@github-actions
Copy link
Contributor

github-actions bot commented Mar 3, 2026

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-mobile-platform Mobile Platform team label Mar 3, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Mar 3, 2026

🔍 Smart E2E Test Selection

  • Selected E2E tags: None (no tests recommended)
  • Selected Performance tags: None (no tests recommended)
  • Risk Level: low
  • AI Confidence: 95%
click to see 🤖 AI reasoning details

E2E Test Selection:
The change modifies only the .github/workflows/push-eas-update.yml workflow file, replacing hardcoded node-version: '20' with node-version-file: '.nvmrc' in two places (fingerprint-comparison and push-update jobs). This is a CI infrastructure change that standardizes Node.js version sourcing to use the project's .nvmrc file instead of a hardcoded version. The change:

  1. Does not modify any application code
  2. Does not modify any E2E test infrastructure or test files
  3. Only affects the OTA (Over-The-Air) update workflow, which is separate from E2E test execution
  4. Is a simple configuration standardization for consistency

Since no application code or test infrastructure is affected, no E2E tests are required to validate this change.

Performance Test Selection:
This change only modifies CI workflow configuration for Node.js version sourcing. It has no impact on application code, UI rendering, data loading, or any runtime behavior that could affect app performance.

View GitHub Actions results

@weitingsun weitingsun requested a review from Cal-L March 3, 2026 01:16
@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 3, 2026

Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@weitingsun weitingsun added this pull request to the merge queue Mar 3, 2026
Merged via the queue into main with commit 99f427f Mar 3, 2026
126 of 141 checks passed
@weitingsun weitingsun deleted the wsun/update-node-version-file branch March 3, 2026 03:12
@github-actions github-actions bot locked and limited conversation to collaborators Mar 3, 2026
@metamaskbot metamaskbot added the release-7.69.0 Issue or pull request that will be included in release 7.69.0 label Mar 3, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-7.69.0 Issue or pull request that will be included in release 7.69.0 size-XS team-mobile-platform Mobile Platform team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants