-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: OpenSea V1 -> V2 patch #8155
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release/7.12.4 #8155 +/- ##
=================================================
Coverage ? 37.39%
=================================================
Files ? 1052
Lines ? 28173
Branches ? 2517
=================================================
Hits ? 10534
Misses ? 17040
Partials ? 599 ☔ View full report in Codecov by Sentry. |
E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/cf6c953e-e771-4876-a815-81d6f253d3dd Regression: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/e065cc34-044d-478b-8fa0-a4715d7b558b |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Quality Gate passedKudos, no new issues were introduced! 0 New issues |
Description
This is a release version of this PR: #8135
Migrate to OpenSea V2 API because V1 is being deprecated. Patches this change from core: MetaMask/core#3654
Related issues
Fixes: https://github.com/MetaMask/MetaMask-planning/issues/1841
Manual testing steps
Screenshots/Recordings
No visible differences between before and after.
Before
After
Screen.Recording.2023-12-18.at.3.12.54.PM.mov
Pre-merge author checklist
Pre-merge reviewer checklist