-
-
Notifications
You must be signed in to change notification settings - Fork 179
fix: create core package with domain protocols and unit test coverage #1313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1313 +/- ##
=======================================
Coverage ? 74.93%
=======================================
Files ? 184
Lines ? 4513
Branches ? 1105
=======================================
Hits ? 3382
Misses ? 1131
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! (lets remove the remote comms dep later)
Explanation
Adding new "@metamask/sdk-multichain" package for new multi-chain code-path, phase 1. Name for the package is temporary until we figure the next one out soon.
Contains a simple interface for multi-chain, logger, event management and storage wrappers that will be used by this package.
Most of this PR are Types but also contain the build configuration, lint with biome and test coverage for some utility functions.
Checklist