Skip to content

fix: create core package with domain protocols and unit test coverage #1313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Jul 11, 2025

Conversation

elribonazo
Copy link
Contributor

Explanation

Adding new "@metamask/sdk-multichain" package for new multi-chain code-path, phase 1. Name for the package is temporary until we figure the next one out soon.

Contains a simple interface for multi-chain, logger, event management and storage wrappers that will be used by this package.

Most of this PR are Types but also contain the build configuration, lint with biome and test coverage for some utility functions.

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate

@elribonazo elribonazo requested a review from a team as a code owner July 10, 2025 13:44
@elribonazo elribonazo changed the title fix: create initial package with domain protocols and unit test coverage fix: create core package with domain protocols and unit test coverage Jul 10, 2025
cursor[bot]

This comment was marked as outdated.

Copy link

socket-security bot commented Jul 10, 2025

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Addednpm/​@​vitest/​coverage-v8@​3.2.4991007097100
Addednpm/​esbuild-plugin-umd-wrapper@​3.0.08710010079100
Addednpm/​uuid@​11.1.010010010084100
Addednpm/​@​metamask/​multichain-api-client@​0.6.49910010097100
Addednpm/​@​biomejs/​biome@​2.0.010010010098100

View full report

cursor[bot]

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

Copy link

codecov bot commented Jul 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@7f61c77). Learn more about missing BASE report.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1313   +/-   ##
=======================================
  Coverage        ?   74.93%           
=======================================
  Files           ?      184           
  Lines           ?     4513           
  Branches        ?     1105           
=======================================
  Hits            ?     3382           
  Misses          ?     1131           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

cursor[bot]

This comment was marked as outdated.

Copy link

Copy link
Collaborator

@chakra-guy chakra-guy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! (lets remove the remote comms dep later)

@elribonazo elribonazo merged commit 94e09da into main Jul 11, 2025
40 checks passed
@elribonazo elribonazo deleted the features/multichain-core-init branch July 11, 2025 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants