fix: create core package with domain protocols and unit test coverage#1313
Merged
elribonazo merged 12 commits intomainfrom Jul 11, 2025
Merged
fix: create core package with domain protocols and unit test coverage#1313elribonazo merged 12 commits intomainfrom
elribonazo merged 12 commits intomainfrom
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1313 +/- ##
=======================================
Coverage ? 74.93%
=======================================
Files ? 184
Lines ? 4513
Branches ? 1105
=======================================
Hits ? 3382
Misses ? 1131
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
chakra-guy
approved these changes
Jul 11, 2025
Collaborator
chakra-guy
left a comment
There was a problem hiding this comment.
LGTM! (lets remove the remote comms dep later)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Explanation
Adding new "@metamask/sdk-multichain" package for new multi-chain code-path, phase 1. Name for the package is temporary until we figure the next one out soon.
Contains a simple interface for multi-chain, logger, event management and storage wrappers that will be used by this package.
Most of this PR are Types but also contain the build configuration, lint with biome and test coverage for some utility functions.
Checklist