Skip to content

fix: multichain core - stores adapters and client implementation #1314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 14, 2025

Conversation

elribonazo
Copy link
Contributor

@elribonazo elribonazo commented Jul 10, 2025

Explanation

Storage adapters are used by the SDK and dApps to store specific values in the native storage, example, the anonId needed for Analytics.

This PR integrates the Storage wrapper, a simple class that will be used across the SDK to abstract from the storage and provide a simple to use interface with, setAnonId, removeAnonId and other utility functions for other attributes.

We also integrate 3 different storages, RN, Browser and Node.
RN is using internally @react-native-async-storage/async-storage
Browser is using internally localstorage
Node is using internally FS

Added basic unitary test coverage

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate

Copy link

codecov bot commented Jul 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.93%. Comparing base (94e09da) to head (9ed0e43).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1314   +/-   ##
=======================================
  Coverage   74.93%   74.93%           
=======================================
  Files         184      184           
  Lines        4513     4513           
  Branches     1105     1105           
=======================================
  Hits         3382     3382           
  Misses       1131     1131           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@elribonazo elribonazo force-pushed the features/multichain-stores branch 2 times, most recently from 4122f73 to 6d69f40 Compare July 11, 2025 06:24
@elribonazo elribonazo force-pushed the features/multichain-stores branch from ca8d15e to e72cedf Compare July 14, 2025 10:50
@elribonazo elribonazo marked this pull request as ready for review July 14, 2025 10:57
@elribonazo elribonazo requested a review from a team as a code owner July 14, 2025 10:57
cursor[bot]

This comment was marked as outdated.

chakra-guy
chakra-guy previously approved these changes Jul 14, 2025
Copy link
Collaborator

@chakra-guy chakra-guy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elribonazo elribonazo merged commit 449a82a into main Jul 14, 2025
8 checks passed
@elribonazo elribonazo deleted the features/multichain-stores branch July 14, 2025 11:07
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants