-
-
Notifications
You must be signed in to change notification settings - Fork 179
fix: multichain core - stores adapters and client implementation #1314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1314 +/- ##
=======================================
Coverage 74.93% 74.93%
=======================================
Files 184 184
Lines 4513 4513
Branches 1105 1105
=======================================
Hits 3382 3382
Misses 1131 1131 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
4122f73
to
6d69f40
Compare
ca8d15e
to
e72cedf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Explanation
Storage adapters are used by the SDK and dApps to store specific values in the native storage, example, the anonId needed for Analytics.
This PR integrates the Storage wrapper, a simple class that will be used across the SDK to abstract from the storage and provide a simple to use interface with, setAnonId, removeAnonId and other utility functions for other attributes.
We also integrate 3 different storages, RN, Browser and Node.
RN is using internally @react-native-async-storage/async-storage
Browser is using internally localstorage
Node is using internally FS
Added basic unitary test coverage
Checklist