Skip to content

Conversation

wenfix
Copy link
Contributor

@wenfix wenfix commented Oct 8, 2025

Explanation

Currently there's no automated way to trigger the existing Github Actions responsible for releasing the packages in the repo to NPM.

This PR:

  • Updates @metamask/create-release-branch to 4.3.1 across all packages.
  • Updates commitlint.config.js to ignore commits created by @metamask/create-release-branch.
  • Updates changelog:* scripts across all repos to match @metamask/core for consistency.
  • Add changelog:format.
  • Deduplicate@metamask/auto-changelog by moving it to the root and update it to 3.4.3
  • Pins workspace package versions across the repo as its required by @metamask/create-release-branch

With these changes we're able to do yarn create-release-branch -i to create a Release branch locally. Pushing and merging that branch should trigger publish-release action.

See Test Release branch here

References

Closes WAPI-739

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate

Note

Standardizes changelog tooling and release workflows, adds Yarn constraints, pins/aligns package versions, and updates CI to detect release commits and validate changelogs.

  • CI/CD:
    • Use changelog:validate in lint-build-test.yml; fix Sonar token block; broaden commit-starts-with patterns for release detection in main.yml.
  • Changelog Tooling:
    • Add scripts/update-changelog.sh, scripts/format-changelog.sh; enhance scripts/validate-changelog.sh to call local binary with prettier.
    • Add changelog:update|validate|format scripts across packages; update docs to reference changelog:validate.
    • commitlint.config.js: ignore auto-generated release commits.
  • Yarn/Config:
    • Add Yarn constraints plugin (.yarn/plugins/@yarnpkg/plugin-constraints.cjs) and register in .yarnrc.yml.
    • Fix .gitignore negation for .yarn/* entries.
  • Dependencies/Versions:
    • Pin internal workspace deps to explicit versions where required (e.g., @metamask/sdk, @metamask/sdk-react, viem).
    • Deduplicate @metamask/auto-changelog to root; bump @metamask/create-release-branch and prettier.
    • Minor package cleanup (remove unused auto-changelog, align playground deps).

Written by Cursor Bugbot for commit 1593ced. This will update automatically on new commits. Configure here.

@wenfix wenfix requested a review from a team as a code owner October 8, 2025 15:05
Copy link

socket-security bot commented Oct 8, 2025

Copy link

socket-security bot commented Oct 8, 2025

Caution

MetaMask internal reviewing guidelines:

  • Do not ignore-all
  • Each alert has instructions on how to review if you don't know what it means. If lost, ask your Security Liaison or the supply-chain group
  • Copy-paste ignore lines for specific packages or a group of one kind with a note on what research you did to deem it safe.
    @SocketSecurity ignore npm/PACKAGE@VERSION
Action Severity Alert  (click "▶" to expand/collapse)
Block Medium
npm/@metamask/[email protected] has Network access.

Module: globalThis["fetch"]

Location: Package overview

From: package.jsonnpm/@metamask/[email protected]

ℹ Read more on: This package | This alert | What is network access?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at [email protected].

Suggestion: Packages should remove all network access that is functionally unnecessary. Consumers should audit network access to ensure legitimate use.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/@metamask/[email protected]. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

Block Medium
npm/@metamask/[email protected] has Network access.

Module: globalThis["fetch"]

Location: Package overview

From: playground/multichain-node/package.jsonnpm/@metamask/[email protected]

ℹ Read more on: This package | This alert | What is network access?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at [email protected].

Suggestion: Packages should remove all network access that is functionally unnecessary. Consumers should audit network access to ensure legitimate use.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/@metamask/[email protected]. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

Block Medium
npm/@metamask/[email protected] has Network access.

Module: globalThis["fetch"]

Location: Package overview

From: ?npm/@metamask/[email protected]npm/@metamask/[email protected]

ℹ Read more on: This package | This alert | What is network access?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at [email protected].

Suggestion: Packages should remove all network access that is functionally unnecessary. Consumers should audit network access to ensure legitimate use.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/@metamask/[email protected]. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

Block Medium
npm/@metamask/[email protected] has Network access.

Module: globalThis["fetch"]

Location: Package overview

From: packages/sdk-react-ui/package.jsonnpm/@metamask/[email protected]

ℹ Read more on: This package | This alert | What is network access?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at [email protected].

Suggestion: Packages should remove all network access that is functionally unnecessary. Consumers should audit network access to ensure legitimate use.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/@metamask/[email protected]. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

View full report

@wenfix wenfix added dependencies Pull requests that update a dependency file github_actions Pull requests that update GitHub Actions code team-wallet-integrations labels Oct 8, 2025
Copy link

codecov bot commented Oct 8, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.99%. Comparing base (7af4f97) to head (1593ced).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1362   +/-   ##
=======================================
  Coverage   74.99%   74.99%           
=======================================
  Files         184      184           
  Lines        4519     4519           
  Branches     1108     1108           
=======================================
  Hits         3389     3389           
  Misses       1130     1130           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

cursor[bot]

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

@wenfix wenfix mentioned this pull request Oct 9, 2025
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file github_actions Pull requests that update GitHub Actions code team-wallet-integrations

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant